Skip to content

Make ImageView zoom scale dynamic with window size#6599

Closed
roryabraham wants to merge 3 commits intomainfrom
Rory-CleanupImage
Closed

Make ImageView zoom scale dynamic with window size#6599
roryabraham wants to merge 3 commits intomainfrom
Rory-CleanupImage

Conversation

@roryabraham
Copy link
Copy Markdown
Contributor

@roryabraham roryabraham commented Dec 6, 2021

Details

Following up on #6535, cc @railway17

Fixed Issues

$ none

Tests / QA Steps

  1. Prepare a very long image.
  2. Send the image to someone.
  3. Click the image thumbnail in the chatbox.
  4. Verify modal opens to display the image.
  5. Verify image is center aligned.
  6. Check the cursor while hovering around the image.
  7. Check the zoom in and zoom out functionality.
  8. Resize the window and make sure the image zoom region adjusts accordingly
  9. Prepare a very wide image and send it to another.
  10. Repeat steps 2-8 with the wide image.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@roryabraham roryabraham self-assigned this Dec 6, 2021
@roryabraham roryabraham changed the title Clean up ImageView component Make ImageView zoom scale dynamic with window size Jan 12, 2022
@roryabraham
Copy link
Copy Markdown
Contributor Author

Don't remember the context here, going to just close this.

@roryabraham roryabraham deleted the Rory-CleanupImage branch July 6, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant