Skip to content

Migrate more right-docked modals to Reanimated #66039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 7 commits into from
Jul 21, 2025
Merged

Migrate more right-docked modals to Reanimated #66039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c5aba7a
Migrate TimeModalPicker, PushRowModal, ValueSelectorModal, NetSuiteCu…
mhawryluk Jul 14, 2025
c9fbedf
Merge branch 'main' into feat/more-3-right-docked-reanimated-modals
mhawryluk Jul 15, 2025
336866b
Merge branch 'main' into feat/more-3-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
cd740b6
Remove some unnecessary props + fix unrelated type error
mhawryluk Jul 17, 2025
cd039df
Merge branch 'main' into feat/more-3-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
357c216
Merge branch 'main' into feat/more-3-right-docked-reanimated-modals
mhawryluk Jul 17, 2025
878df81
Merge branch 'main' into feat/more-3-right-docked-reanimated-modals
mhawryluk Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/PushRowWithModal/PushRowModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function PushRowModal({isVisible, selectedOption, onOptionChange, onClose, optio
type={CONST.MODAL.MODAL_TYPE.RIGHT_DOCKED}
onModalHide={handleClose}
shouldUseCustomBackdrop
useNativeDriver
shouldUseReanimatedModal
>
<ScreenWrapper
includePaddingTop={false}
Expand Down
3 changes: 1 addition & 2 deletions src/components/TimeModalPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,8 @@ function TimeModalPicker({value, errorText, label, onInputChange = () => {}}: Ti
isVisible={isPickerVisible}
onClose={hidePickerModal}
onModalHide={hidePickerModal}
hideModalContentWhileAnimating
useNativeDriver
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
style={styles.pb0}
Expand Down
3 changes: 1 addition & 2 deletions src/components/ValuePicker/ValueSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,10 @@ function ValueSelectorModal({
isVisible={isVisible}
onClose={() => onClose?.()}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
onBackdropPress={onBackdropPress}
shouldHandleNavigationBack
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
includePaddingTop={false}
Expand Down
3 changes: 1 addition & 2 deletions ...counting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListSelectorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ function NetSuiteCustomListSelectorModal({isVisible, currentCustomListValue, onC
isVisible={isVisible}
onClose={onClose}
onModalHide={onClose}
hideModalContentWhileAnimating
useNativeDriver
onBackdropPress={onBackdropPress}
enableEdgeToEdgeBottomSafeAreaPadding
shouldUseReanimatedModal
>
<ScreenWrapper
includePaddingTop={false}
Expand Down
Loading