Skip to content

[CP Staging] Revert "feat: Reduce amount of items displayed per page of SelectionList"#66157

Merged
mountiny merged 1 commit intoExpensify:mainfrom
callstack-internal:revert-65846-feat/65634-reduce-amount-of-items-per-page-of-selection-list
Jul 15, 2025
Merged

[CP Staging] Revert "feat: Reduce amount of items displayed per page of SelectionList"#66157
mountiny merged 1 commit intoExpensify:mainfrom
callstack-internal:revert-65846-feat/65634-reduce-amount-of-items-per-page-of-selection-list

Conversation

@MrMuzyk
Copy link
Contributor

@MrMuzyk MrMuzyk commented Jul 15, 2025 •
edited by mountiny
Loading

Reverts #65846

Fixes #66147

@MrMuzyk MrMuzyk requested a review from a team as a code owner July 15, 2025 13:17
@melvin-bot melvin-bot bot requested a review from chuckdries July 15, 2025 13:18
@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2025

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team July 15, 2025 13:18
mountiny
mountiny approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 2400c7e into Expensify:main Jul 15, 2025
15 of 17 checks passed
@melvin-bot melvin-bot bot added the Emergency label Jul 15, 2025
@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny changed the title [NoQA] Revert "feat: Reduce amount of items displayed per page of SelectionList" [CP Staging] Revert "feat: Reduce amount of items displayed per page of SelectionList" Jul 15, 2025
OSBotify pushed a commit that referenced this pull request Jul 15, 2025
@mountiny @OSBotify
Merge pull request #66157 from callstack-internal/revert-65846-feat/6…
e271b9d 
…5634-reduce-amount-of-items-per-page-of-selection-list

[NoQA] Revert "feat: Reduce amount of items displayed per page of SelectionList"

(cherry picked from commit 2400c7e)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 15, 2025
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jul 15, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.81-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@chuckdries chuckdries Awaiting requested review from chuckdries

Assignees

@MrMuzyk MrMuzyk

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iOS - App crashes when user connect bank account in wallet

3 participants

@MrMuzyk @OSBotify @mountiny