Update VisionCamera to 4.7.0 for Android 16KB memory page size compatibility #66640

chrispader · 2025-07-17T15:43:23Z

@roryabraham

Explanation of Change

Updates react-native-vision-camera to version 4.7.0 which adds compatibility with Android 16 KB memory page sizes.

Fixed Issues

$ #63871
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open app
Click on "+" button in NavBar
Click "Create expense"
Navigate to the "Scan" tab
Make sure the camera loads
Switch tab and make sure that the camera indicator (green dot in the status bar) dissapears
Switch back to "Scan" tab
Capture a photo

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open app
Click on "+" button in NavBar
Click "Create expense"
Navigate to the "Scan" tab
Make sure the camera loads
Switch tab and make sure that the camera indicator (green dot in the status bar) dissapears
Switch back to "Scan" tab
Capture a photo

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-07-17T15:43:34Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-07-17T15:43:58Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2025-07-17T17:54:49Z

Re-assigning you here @roryabraham if that's okay

roryabraham · 2025-07-17T22:51:32Z

Coming from https://expensify.slack.com/archives/C08CZDJFJ77/p1752781508251129, I'd love to see if we can redo and simplify this patch to its most minimal form

…-16kb-memory-page-size-compat

roryabraham

@chrispader the structure of patches has changed in this repo. It should be like this:

patches
|-- react-native-vision-camera
|---- details.md # This is required!
|---- react-native-vision-camera+4.7.0+001+add-new-arch-compatibility.patch
|---- react-native-vision-camera+4.7.0+002+native-stack-unmount-recycle-camera-session.patch

chrispader · 2025-07-22T02:28:24Z

@chrispader the structure of patches has changed in this repo. It should be like this:


patches

|-- react-native-vision-camera

|---- details.md # This is required!

|---- react-native-vision-camera+4.7.0+001+add-new-arch-compatibility.patch

|---- react-native-vision-camera+4.7.0+002+native-stack-unmount-recycle-camera-session.patch

@roryabraham yes, sorry this is still WIP

…-16kb-memory-page-size-compat

chrispader · 2025-08-04T14:55:39Z

@roryabraham apparently we don't need any of these patches anymore. I've just tested vanilla VisionCamera without nay patches on both Standalone and Hybrid iOS and Android.

@roryabraham @WoLewicki do you know if VisionCamera only caused issues with New Arch/Bridgeless on specific (Android) devices? Because i cannot see any issue with latest v4.7.0 on multiple Android devices that i have tested with

…y.patch

github-actions · 2025-08-04T19:17:29Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

roryabraham · 2025-08-04T19:18:55Z

Requested some regression tests: https://expensify.slack.com/archives/C9YU7BX5M/p1754335109766819

github-actions · 2025-08-04T19:59:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #66640.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/66640/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/66640/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/66640/NewExpensify.dmg	https://66640.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

WoLewicki · 2025-08-05T10:58:18Z

@roryabraham @WoLewicki do you know if VisionCamera only caused issues with New Arch/Bridgeless on specific (Android) devices? Because i cannot see any issue with latest v4.7.0 on multiple Android devices that i have tested with

Could you link the patch or issue that you mean here?

chrispader · 2025-08-05T13:16:13Z

@roryabraham @WoLewicki do you know if VisionCamera only caused issues with New Arch/Bridgeless on specific (Android) devices? Because i cannot see any issue with latest v4.7.0 on multiple Android devices that i have tested with

Could you link the patch or issue that you mean here?

@WoLewicki i'm talking about the huge VisionCamera patch that i was about to simplify in this PR and ended up just removing completely: https://github.com/Expensify/App/blob/main/patches/react-native-vision-camera/react-native-vision-camera%2B4.6.1.patch

Were any of the changes from the previous RN upgrade PRs only needed for issues with specific devices?

jayeshmangwani · 2025-08-06T07:39:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-1.mp4

android-2.mp4

Android: mWeb Chrome

mweb-chrome.mp4

iOS: HybridApp

iOS: mWeb Safari

mweb-safari.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2025-08-06T07:42:57Z

@roryabraham , I tested on Android, mweb Chrome, and mweb Safari, camera worked well across all. I also tried a few edge cases like switching between foreground/background, locking the screen, and leaving the camera screen open for 10 minutes, and everything worked fine.

I’m not able to test on iOS since my UDID isn’t added for the adhocs. You’ll either need to test iOS yourself, or if it’s possible to add my UDID, I can send it to you.

WoLewicki · 2025-08-06T09:07:02Z

Were any of the changes from the previous RN upgrade PRs only needed for issues with specific devices?

I don't think so. It might be a case that the interop layer for using components was bad at the moment we added this patch and now it works well enough. Because if I understand it correctly, the package still is not officially moved to new arch yeah? So it now goes through interop layer when you removed the patch, so as long as it works correctly, we should be good. At the same time, I am not an expert on interop layer so can't say much about what are potential issues with such approach.

roryabraham

Regression tests completed, no issues found

Testing was done on 2 different iPhones and 5 different Android phones

roryabraham · 2025-08-07T16:56:03Z

filled in the remainder of @jayeshmangwani's checklist since Applause tested on iOS

jayeshmangwani · 2025-08-07T17:03:44Z

Thanks for testing on iOS ❤️

OSBotify · 2025-08-07T17:07:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-08T02:28:18Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.91-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-12T04:07:39Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

chrispader added 2 commits July 17, 2025 22:40

chore: update VisionCamera

9771cde

Update details.md

0a82941

chrispader requested a review from a team as a code owner July 17, 2025 15:43

chrispader mentioned this pull request Jul 17, 2025

Enable 16KB memory page size on Android #64640

Closed

51 tasks

melvin-bot bot requested review from srikarparsi and removed request for a team July 17, 2025 15:43

srikarparsi requested review from roryabraham and removed request for srikarparsi July 17, 2025 17:54

chrispader added 5 commits July 18, 2025 20:04

Merge branch 'main' into @chrispader/update-vision-camera-for-android…

8b21653

…-16kb-memory-page-size-compat

chore: split up patches

7e5e2f2

chore: remove gradle and linting specific files from vision camera patch

1262c81

chore: remove generated .js files from VisionCamera patch

588558a

chore: remove CameraViewNativeComponent spec

b8a89fa

roryabraham requested changes Jul 22, 2025

View reviewed changes

chrispader marked this pull request as draft July 22, 2025 09:33

chrispader added 8 commits July 22, 2025 17:26

chore: remove RNCameraView from VisionCamera patch

b7daebb

Merge branch 'main' into pr/66640

2e10847

Merge branch 'main' into pr/66640

89b2403

chore: update VisionCamera pod

1053d9f

Merge branch 'main' into pr/66640

cff26e8

Merge branch 'main' into pr/66640

09125d2

chore: remove VisionCamera CameraSession patch

311489f

Merge branch 'main' into @chrispader/update-vision-camera-for-android…

81a419e

…-16kb-memory-page-size-compat

chrispader marked this pull request as ready for review August 4, 2025 16:26

chrispader added 2 commits August 4, 2025 18:26

Delete react-native-vision-camera+4.7.0+001+add-new-arch-compatibilit…

d98f072

…y.patch

Delete details.md

3a79eab

roryabraham mentioned this pull request Aug 5, 2025

[HOLD https://github.com/callstackincubator/android/issues/15] [$250] Enable 16KB memory page size on Android #63871

Open

roryabraham approved these changes Aug 7, 2025

View reviewed changes

roryabraham merged commit daeff95 into Expensify:main Aug 7, 2025
30 of 31 checks passed

github-actions bot mentioned this pull request Aug 8, 2025

Deploy Checklist: New Expensify 2025-08-08 #68168

Closed

75 tasks

Julesssss mentioned this pull request Aug 13, 2025

[Due for payment 2025-09-04] Android - User signed out of app when updating to '9.1.89-7' #67949

Closed

16 tasks

chrispader mentioned this pull request Aug 28, 2025

Tracking: Remove VisionCamera CameraSession on Fabric patch once the library was fully migrated to New Arch #49988

Closed

roryabraham mentioned this pull request Aug 28, 2025

[HOLD] Enable 16KB memory page size on Android #69161

Closed

51 tasks

Update VisionCamera to 4.7.0 for Android 16KB memory page size compatibility #66640

Update VisionCamera to 4.7.0 for Android 16KB memory page size compatibility #66640

Uh oh!

Conversation

chrispader commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jul 17, 2025

Uh oh!

melvin-bot bot commented Jul 17, 2025

Uh oh!

srikarparsi commented Jul 17, 2025

Uh oh!

roryabraham commented Jul 17, 2025

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

chrispader commented Jul 22, 2025

Uh oh!

chrispader commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

roryabraham commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

WoLewicki commented Aug 5, 2025

Uh oh!

chrispader commented Aug 5, 2025

Uh oh!

jayeshmangwani commented Aug 6, 2025 • edited by roryabraham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Aug 6, 2025

Uh oh!

WoLewicki commented Aug 6, 2025

Uh oh!

roryabraham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Aug 7, 2025

Uh oh!

Uh oh!

jayeshmangwani commented Aug 7, 2025

Uh oh!

OSBotify commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

github-actions bot commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chrispader commented Jul 17, 2025 •

edited

Loading

jayeshmangwani commented Aug 6, 2025 •

edited by roryabraham

Loading

roryabraham left a comment •

edited

Loading