Remove Onyx.connect() for the key: ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT by DylanDylann · Pull Request #66740 · Expensify/App

DylanDylann · 2025-07-18T17:07:17Z

Explanation of Change

Fixed Issues

$ #66323
PROPOSAL:

Tests

Login a new account
Open 1:1 chat
Create a scan request on the chat in step 2
When clicking confirm button, the location permission modal appear
Click Got it or Not now
Click on FAB button and click on the quick action button
Verify that the location permission modal doesn't appear again

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-19.at.21.01.03.mov

Android: mWeb Chrome

Screen.Recording.2025-07-19.at.20.59.05.mov

iOS: Native

Screen.Recording.2025-07-19.at.20.59.53.mov

iOS: mWeb Safari

Screen.Recording.2025-07-19.at.20.56.07.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-19.at.20.44.57.mov

MacOS: Desktop

Screen.Recording.2025-07-19.at.20.51.26.mov

DylanDylann · 2025-07-19T14:01:54Z

@allgandalf The PR is ready

allgandalf

dummy review to keep PR in k2 and in sight, sorry for the delay @DylanDylann , the PR was not in my K2 so i totally forgot to review this one today

allgandalf · 2025-07-23T05:38:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-07-30.at.12.44.37.PM.mov

MacOS: Desktop

Screen.Recording.2025-07-30.at.12.48.08.PM.mov

allgandalf

@DylanDylann can you add an automated test for this one?

DylanDylann · 2025-07-23T09:29:41Z

@allgandalf You mean UTs for shouldStartLocationPermissionFlow func, right?

allgandalf · 2025-07-23T09:30:46Z

I think UI test will make more sense here right?

DylanDylann · 2025-07-23T09:55:01Z

I think UI test will make more sense here right?

@allgandalf Why do you think that? this only be an until function. You mean we need to cover test for all the flow, right?

allgandalf · 2025-07-23T09:56:59Z

yeah, are you planning to add a UT for this? i'm a bit confused by what you meant

DylanDylann · 2025-07-23T10:10:14Z

@allgandalf Yeah I think UT for shouldStartLocationPermissionFlow func is enough

DylanDylann · 2025-07-24T05:09:51Z

@allgandalf Any update?

allgandalf

Tests well and LGTM!

danieldoglas

Instead of adding lastLocationPermissionPrompt as a parameter here, can we instead:

create a useIOUUtils that will return the current functions
leave NVP_LAST_LOCATION_PERMISSION_PROMPT as a connectWithoutView dependency here
use the shouldStartLocationPermissionFlow function as a dependency in the functions that use it

That way we don't need to add a dependency for NVP_LAST_LOCATION_PERMISSION_PROMPT in all places that use that function.

@DylanDylann @allgandalf please let me know if you think this would be a better approach

allgandalf · 2025-07-25T03:24:20Z

Makes sense to me @danieldoglas !

DylanDylann · 2025-07-25T04:02:39Z

@danieldoglas @allgandalf If we use connectWithoutView, the component won't re-render when shouldStartLocationPermissionFlow changes, which might lead to unexpected behavior. Also, since the above suggestion still uses useIOUUtils directly within the UI, I’m not certain connectWithoutView is applicable in this case. Please feel free to correct me if I’m mistaken.

github-actions · 2025-07-25T04:13:13Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

danieldoglas · 2025-07-25T20:43:44Z

If we use connectWithoutView, the component won't re-render when shouldStartLocationPermissionFlow changes, which might lead to unexpected behavior. Also, since the above suggestion still uses useIOUUtils directly within the UI, I’m not certain connectWithoutView is applicable in this case. Please feel free to correct me if I’m mistaken.

I think (and I might be wrong, @allgandalf @tgolen please correct me if I am) that if you create a useIOUUtils that returns shouldStartLocationPermissionFlow, you can add the shouldStartLocationPermissionFlow function as a dependency on the useCallback's you added the lastLocationPermissionPrompt object instead.

That way if there's any changes in the NVP_LAST_LOCATION_PERMISSION_PROMPT value inside the IOU utils, the function it self will change, and it would trigger the updates in the views depending on it.

but again, I might be misunderstanding this. So I'll let the others chime in.

DylanDylann · 2025-07-28T04:26:19Z

Discussing here

DylanDylann · 2025-07-29T09:21:38Z

@allgandalf Could you please review this PR?

src/hooks/useIOUUtils.ts

package.json

github-actions · 2025-07-31T12:17:05Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-04T19:24:00Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove Onyx.connect

2d4ff63

DylanDylann requested a review from a team as a code owner July 18, 2025 17:07

add dependency

6a7b568

DylanDylann marked this pull request as draft July 18, 2025 17:12

DylanDylann changed the title ~~Remove Onyx.connect~~ Remove Onyx.connect() for the key: ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT Jul 18, 2025

DylanDylann added 2 commits July 19, 2025 00:17

make it cleaner

b85b7eb

Merge branch 'main' into refactor-IOUUtils

dabebea

DylanDylann marked this pull request as ready for review July 19, 2025 14:01

allgandalf reviewed Jul 22, 2025

View reviewed changes

allgandalf reviewed Jul 23, 2025

View reviewed changes

add Uts

a02c2eb

allgandalf approved these changes Jul 24, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas July 24, 2025 19:56

danieldoglas assigned DylanDylann Jul 24, 2025

danieldoglas requested changes Jul 24, 2025

View reviewed changes

DylanDylann added 2 commits July 25, 2025 11:08

Merge branch 'main' into refactor-IOUUtils

79a9648

update --max-warnings

ffe9e84

DylanDylann added 2 commits July 25, 2025 11:15

revert mobile-expensify

53fe687

update --max-warnings

ca87b52

DylanDylann added 2 commits July 26, 2025 16:04

Merge branch 'main' into refactor-IOUUtils

92ab6cd

revert Mobile-Expensify

3d9d8e6

DylanDylann added 6 commits July 28, 2025 23:55

update to use custom hook

1c7c64b

Merge branch 'main' into refactor-IOUUtils

a844067

update --max-warnings

363fe15

eslint failed

c272d92

Merge branch 'main' into refactor-IOUUtils

8fd80b8

update --max-warnings

18ab48a

danieldoglas reviewed Jul 29, 2025

View reviewed changes

src/hooks/useIOUUtils.ts Show resolved Hide resolved

allgandalf approved these changes Jul 30, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas July 30, 2025 07:10

allgandalf reviewed Jul 30, 2025

View reviewed changes

package.json Show resolved Hide resolved

danieldoglas approved these changes Jul 30, 2025

View reviewed changes

danieldoglas merged commit c0b6bcb into Expensify:main Jul 30, 2025
32 checks passed

This was referenced Jul 30, 2025

[Due for payment 2025-08-11] Investigate workflow job failing on main: lint / ESLint check #67435

Closed

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

melvin-bot bot mentioned this pull request Aug 4, 2025

[Due for payment 2025-08-11] Remove Onyx.connect() for the key: ONYXKEYS.NVP_LAST_LOCATION_PERMISSION_PROMPT in src/libs/IOUUtils.ts #66323

Closed

bernhardoj mentioned this pull request Feb 15, 2026

IOURequestStepScan clean-up, phase 2: Extract shared business logic into useReceiptScan hook #82130

Merged

53 tasks

Conversation

DylanDylann commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jul 19, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 23, 2025

Uh oh!

allgandalf commented Jul 23, 2025

Uh oh!

DylanDylann commented Jul 23, 2025

Uh oh!

allgandalf commented Jul 23, 2025

Uh oh!

DylanDylann commented Jul 23, 2025

Uh oh!

DylanDylann commented Jul 24, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

danieldoglas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jul 25, 2025

Uh oh!

DylanDylann commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

danieldoglas commented Jul 25, 2025

Uh oh!

DylanDylann commented Jul 28, 2025

Uh oh!

DylanDylann commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DylanDylann commented Jul 18, 2025 •

edited

Loading

allgandalf commented Jul 23, 2025 •

edited

Loading

danieldoglas left a comment •

edited

Loading