Skip to content

Fix/65746 Enable scroll for per diem when keyboard is open#66747

Merged
marcochavezf merged 10 commits intoExpensify:mainfrom
Eskalifer1:fix/65746
Jul 30, 2025
Merged

Fix/65746 Enable scroll for per diem when keyboard is open#66747
marcochavezf merged 10 commits intoExpensify:mainfrom
Eskalifer1:fix/65746

Conversation

@Eskalifer1
Copy link
Contributor

@Eskalifer1 Eskalifer1 commented Jul 18, 2025

Explanation of Change

Fixed Issues

$#65746
PROPOSAL:#65746 (comment)

Tests

  1. Launch app

  2. Go to workspace settings - more features - enable permission diem

  3. Upload perdiem file attached below
    PerDiem-2025-07-19.18_35_01.550.csv

  4. Open workpace chat

  5. Tap plus icon from compose box - create expense - per diem

  6. Enter some text in search box like - sa

  7. Try to scroll the results

  8. Make sure that the result is scrolled and the keyboard is not hidden during scrolling

  • Verify that no errors appear in the JS console

Offline tests

Precondition: have imported per diem to workspace

  1. Tap plus icon from compose box - create expense - per diem
  2. Enter some text in search box like - sa
  3. Try to scroll the results
  4. Make sure that the result is scrolled and the keyboard is not hidden during scrolling

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
65746-android.mp4
Android: mWeb Chrome
65746-android-web.mp4
iOS: Native
65746-ios.mp4
iOS: mWeb Safari
65746-ios-web.mp4
MacOS: Chrome / Safari
65746-web.mp4
MacOS: Desktop
65746-desktop.mp4

@Eskalifer1 Eskalifer1 requested a review from a team as a code owner July 18, 2025 20:59
@melvin-bot melvin-bot bot requested review from ikevin127 and removed request for a team July 18, 2025 20:59
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2025

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Eskalifer1 Eskalifer1 changed the title Fix/65746 Fix/65746 Enable scroll for per diem when keyboard is open Jul 18, 2025
@ikevin127
Copy link
Contributor

ikevin127 commented Jul 19, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android-hybrid.mp4
Android: mWeb Chrome
android-mweb.mp4
iOS: HybridApp
ios-hybrid.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

Comment on lines 62 to +68
if (!isScreenTouched) {
return;
}

if (!shouldHideKeyboardOnScroll) {
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two can be combined (and comment adjusted):

Suggested change
if (!isScreenTouched) {
return;
}
if (!shouldHideKeyboardOnScroll) {
return;
}
// Only dismiss the keyboard whenever the user scrolls the screen or `shouldHideKeyboardOnScroll` is true
if (!isScreenTouched || !shouldHideKeyboardOnScroll) {
return;
}

@ikevin127
Copy link
Contributor

@Eskalifer1 🔴 I found a blocker issue while testing on Android / iOS: mWeb where because we hardcode shouldHideKeyboardOnScroll={false} in DestinationPicker, when scrolling horizontally, the keyboard will remain open on other tab screens where we're not supposed to have a soft keyboard - and when typing, text will be added to the Per diem input, breaking the UI:

I think we have to somehow dynamically set shouldHideKeyboardOnScroll in DestinationPicker such that we allow Keyboard.dismiss() as soon as we left the Per diem tab / page.

Android: mWeb iOS: mWeb
issue-android-mweb.mp4
issue-ios-mweb.mp4

🟡 I completed the reviewer checklist but won't be able to approve until the blocker issue is resolved which I'll have to retest. Make sure to test the fix on both native / mweb before deciding to push it, to ensure it doesn't break other logic.

@ikevin127
Copy link
Contributor

Almost forgot: for the PR description testing section step: 3. Upload perdiem file attached below, make sure to add this per diem file so QA can test this PR once merged 👇

PerDiem-2025-07-19 18_35_01.550.csv

@Eskalifer1
Copy link
Contributor Author

Thanks, I'll take a look on Monday

@Eskalifer1
Copy link
Contributor Author

@ikevin127 By the way, I looked and this bug is reproducible without my changes in the code, here's a video of the staging

2025-07-19.23.59.59.mov

@Eskalifer1
Copy link
Contributor Author

I propose to fix this bug by adding Keyboard.dismiss() in this function, what do you think about it?

const resetIOUTypeIfChanged = useCallback(
(newIOUType: IOURequestType) => {
if (transaction?.iouRequestType === newIOUType) {
return;
}
setIsMultiScanEnabled(false);
initMoneyRequest({
reportID,
policy,
isFromGlobalCreate,
currentIouRequestType: transaction?.iouRequestType,
newIouRequestType: newIOUType,
});
},
[policy, reportID, isFromGlobalCreate, transaction],
);

cc: @ikevin127

@ikevin127
Copy link
Contributor

@ikevin127 By the way, I looked and this bug is reproducible without my changes in the code, here's a video of the staging

That's true, thanks for letting me know. I guess adding Keyboard.dismiss() at the top of the resetIOUTypeIfChanged would be more than enough for this given that the issue was already present on staging / production 👍

Once the change is applied, I'll Approve 🟢

@ikevin127
Copy link
Contributor

@Eskalifer1 Thanks for applying the keyboard fix!

Looks like there are some failing workflows, let me know once all checks pass so I can review and Approve.

Copy link
Contributor

@ikevin127 ikevin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

(failing spell check not related to our PR changes)

@melvin-bot melvin-bot bot requested a review from marcochavezf July 21, 2025 08:52
@Eskalifer1
Copy link
Contributor Author

@ikevin127 Thank you, I think we need to open another task to close the keyboard, because Keyboard.dismiss on onTabSelected is triggered too late for me, so if you quickly type a few characters, the bug will appear. We can leave Keyboard.dismiss as a temporary solution, but it would be nice if this is solved properly. If it's worth it to fix it, of course.

@ikevin127
Copy link
Contributor

I noticed it's a bit slow and the keyboard is closed after navigation to the other tab is completed, but it's still better than not closing at all. IMO that's fine, as the issue existed previously on staging / production so it shouldn't be reported as a regression of this PR.

cc @marcochavezf for context

@Eskalifer1
Copy link
Contributor Author

@ikevin127 Wait a second, I found the regression, I'm working on a fix.

On IOS native strage behavior due to shouldEnableKeyboardAvoidingView

-.-2025-07-21-.-12.20.26.mp4

@ikevin127
Copy link
Contributor

ikevin127 commented Jul 21, 2025

You can edit the PR title and add either [WIP] or [HOLD] at the beginning to let CME know that it's work in progress or on hold until you fix all issues.

@Eskalifer1 Eskalifer1 changed the title Fix/65746 Enable scroll for per diem when keyboard is open [HOLD] Fix/65746 Enable scroll for per diem when keyboard is open Jul 21, 2025
@Eskalifer1
Copy link
Contributor Author

Eskalifer1 commented Jul 22, 2025

By the way, I noticed another bug, on IOS native when switching between tabs (via the tab button) on the PerDiem page, the keyboard closes as soon as it opens, and this is not related to my changes, I saw the same behavior on the latest main

2025-07-22.14.13.57.mov

I can also fix it

@Eskalifer1
Copy link
Contributor Author

Let me know what you think, thanks)

cc: @ikevin127

@ikevin127
Copy link
Contributor

ikevin127 commented Jul 23, 2025

By the way, I noticed another bug, on IOS native when switching between tabs (via the tab button) on the PerDiem page, the keyboard closes as soon as it opens, and this is not related to my changes, I saw the same behavior on the latest main

I think we're good on this one, way out of scope.

@ikevin127 This is the solution I can offer

That was quite the read, appreciate the effort. I looked into your solution with swipeStart and swipeEnd events with different logic for Native vs Web and here's my review:

Strengths:
• Addresses the platform-specific behavior differences
• Uses appropriate events (swipeEnd instead of onTabSelected which fires too late on mWeb)
• Maintains existing behavior on Native while fixing mWeb

Potential Issues/Improvements:

  1. Index-based Logic Fragility:
   if (swipeStartIndexRef.current === 3 && currentIndex === 2) {

This hardcoded index comparison (3→2 for PerDiem→Distance) is fragile and could break if tab order changes.

  1. Better Platform Detection:
    Instead of detecting platform in the component, you could consider using platform-specific files (as stated in contributing styles).

  2. Event Reliability:
    The solution relies on swipeEnd events which might not be consistently fired across all browsers / devices.

@Eskalifer1 To streamline the process and avoid going too much out of scope, given that this mWeb issue is proving to be difficult to address / align with native - I'd say let's simply disable tab navigator swipe on mWeb only for the Per Diem page, this way we avoid the keyboard issue, while maintaining the current logic on native - even though the behaviour will be slightly different.

In IOURequestStartPage, pass isMobile() to the disableSwipe like so:

import { isMobile } from '@libs/Browser';

// We're disabling swipe on mWeb fo the Per Diem tab because the keyboard will hang on the other tab after switching
disableSwipe={(isMultiScanEnabled && selectedTab === CONST.TAB_REQUEST.SCAN) || (selectedTab === CONST.TAB_REQUEST.PER_DIEM && isMobile())}

making sure to add that comment for context, this way we avoid the issue of keyboard hanging on the other tab, and if tab is switched by pressing on the button the keyboard is dismissed right away.

@marcochavezf If you agree with the fix, I think we can address the issue separately if needed to align the behaviour with native when it comes to this already existing issue on staging / production.

♻️ Once this and the above changes are addressed by the author, and all workflows are passing - I think you can remove the [HOLD] and we should be ready to merge!

@Eskalifer1
Copy link
Contributor Author

@ikevin127 Thank you for your update. Just to confirm, we are simply disabling swiping on the Per-diem page, as well as on mobile devices. This means that we are getting rid of the swipe logic between tabs on native devices, which in turn will remove the keyboard bug, and I can report the task of hiding the keyboard on iOS, and it will be a separate task. Correct me if I'm wrong, thank you.

@Eskalifer1
Copy link
Contributor Author

Eskalifer1 commented Jul 23, 2025

Oh, wait, I think I understand. We don't completely disable swiping on mobile devices, only for the PerDiem page. I think we should correct the condition to

disableSwipe={(isMultiScanEnabled && selectedTab === CONST.TAB_REQUEST.SCAN) || (selectedTab === CONST.TAB_REQUEST.SCAN && isMobile())}

@Eskalifer1
Copy link
Contributor Author

Eskalifer1 commented Jul 23, 2025

Just fo information:

Index-based Logic Fragility:

I think that we can search not only by index, but also by tab name, so it's not a big problem.

Better Platform Detection:

Yes, i agree

The solution relies on swipeEnd events which might not be consistently fired across all browsers / devices.

Yes, this is the only problem that remains, because it works differently on native devices and browsers, and this is an internal implementation that we cannot influence.

@ikevin127
Copy link
Contributor

@Eskalifer1 My bad, just edited the comment, I think it should be:

disableSwipe={(isMultiScanEnabled && selectedTab === CONST.TAB_REQUEST.SCAN) || (selectedTab === CONST.TAB_REQUEST.PER_DIEM && isMobile())}

to only disable horizontal swipe on the Per Diem page and when isMobile, meaning on mWeb only while on Per Diem page.

@Eskalifer1
Copy link
Contributor Author

I think we are waiting for confirmation regarding the PR, correct? Or Can I start working on the changes now?

@ikevin127
Copy link
Contributor

I think you're good to move forward and apply this change, don't forget about adding the comment above disableSwipe:

// We're disabling swipe on mWeb fo the Per Diem tab because the keyboard will hang on the other tab after switching

and change this while you're at it, then once changes are applied CME can take a look and decide whether we will move forward with merge given the context mentioned here.

@Eskalifer1
Copy link
Contributor Author

Okay, thank you, I'll update the PR tomorrow morning.

@Eskalifer1
Copy link
Contributor Author

PR is updated

@ikevin127
Copy link
Contributor

Thanks, you can remove [HOLD] from PR title now that its ready for review & merge.

@Eskalifer1 Eskalifer1 changed the title [HOLD] Fix/65746 Enable scroll for per diem when keyboard is open Fix/65746 Enable scroll for per diem when keyboard is open Jul 24, 2025
Copy link
Contributor

@ikevin127 ikevin127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

cc @marcochavezf please check out this comment before during review and merge

@marcochavezf
Copy link
Contributor

marcochavezf commented Jul 25, 2025

Thanks guys! For the comment regarding disabling the tab navigator swipe on mWeb, could you please bring it to the open-source channel and tag us? 🙏🏽 I'm not sure about this solution, and probably there could be someone else who already had this problem and can point us in the right direction

@Eskalifer1
Copy link
Contributor Author

Hi, i have this situation first time, should i do this or C+?

@Eskalifer1
Copy link
Contributor Author

@marcochavezf
Copy link
Contributor

Thanks for bringing this up in the open-source channel. Probably this is the first time we're experiencing this issue, so let's go with the current solution

Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks guys!

@marcochavezf marcochavezf merged commit 8b04250 into Expensify:main Jul 30, 2025
20 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.1.88-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

<ScreenWrapper
includePaddingTop={false}
keyboardVerticalOffset={variables.contentHeaderHeight + top + variables.tabSelectorButtonHeight + variables.tabSelectorButtonPadding}
testID={`${IOURequestStepDestination.displayName}-container`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from this issue #72833, we’re wrapping the StepScreenWrapper with ScreenWrapper. However, since StepScreenWrapper has its own offline indicator and ScreenWrapper does too, the offline indicator was appearing twice. We’ve fixed that here: #72833 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants