Skip to content

File ordering + cleanup#66812

Merged
lakchote merged 17 commits intoExpensify:mainfrom
callstack-internal:chore/65722-follow-ups-and-cleanup-pt3
Jul 23, 2025
Merged

File ordering + cleanup#66812
lakchote merged 17 commits intoExpensify:mainfrom
callstack-internal:chore/65722-follow-ups-and-cleanup-pt3

Conversation

@koko57
Copy link
Contributor

@koko57 koko57 commented Jul 21, 2025

Explanation of Change

This PR covers follow-ups and cleanup from #65722

The main improvement is that the pdf files are no longer displayed as last - the order of the files selected is preserved.

🚨 VERY IMPORTANT NOTE 🚨
For iOS (native app/ mobile web app) files are mixed up after selecting them from the Files folder. So the files won't be in the order they were originally marked as selected. It is a native iOS problem - you can check WhatsApp for reference. It usually happens when selecting more than 2 files. It didn't happen for me for just 2 files.

So for the file ordering on iOS (native / mobile safari):

Before changes:

  • images/other file types are displayed first in the attachment modal / or in the IOU confirmation
    Expected result after changes:
  • images are not always first, files are in a mixed order

🚨 VERY IMPORTANT NOTE 2 🚨
Another known issue #66794 - will be handled separately.
When selecting mixed images/pdfs on iOS the "Corrupted file" error is thrown ocasionally (it's not 100% times reproducible)

As the validation hook required substantial modifications, I would greatly appreciate a detailed and in-depth review. Both adding attachments and IOU/receipts flow are affected, so I included all the test steps from the previous Stage 3 and Stage 5 PRs.

Fixed Issues

$ #65722
PROPOSAL: -

Tests

[WEB / DESKTOP]

  1. Go to any chat
  2. Drag and drop several files (mixed images/pdfs) onto the Add attachment dropzone
  3. Verify that the modal carousel arrows are shown when hovering over
  4. Verify that the files are in the order they were dragged onto the dropzone (the pdfs are not displayed after all images) <- IMPORTANT
  5. Click Send
  6. Verify that all the files you dropped are sent
  7. Now instead of dropping files click "+" in the composer
  8. Select Add Attachment
  9. Verify that you're able to select several attachments
  10. Repeat steps 3.-5.

[MOBILE]

  1. Go to any chat
  2. click "+" in the composer
  3. Select Add Attachment
  4. Choose either Photo Library (Choose from Gallery) / Choose Files (Choose file) option
  5. Verify that the attachment carousel works as expected
  6. Verify that the attachments are in the order you've selected them (for IOS check the Very Important Note above) <- IMPORTANT
  7. Click Send
  8. Verify that all the files you dropped are sent

[CHECK THE ERROR HANDLING]

  1. Try to drag and drop or attach via composer several files with one that will throw an error (MAX_SIZE > 24 MB, MIN_SIZE < 240 bytes, corrupted image) or try to attach more than 30 files
  2. Verify that the error modal appears with the attachment modal underneath
  3. Verify that the modal has 2 options: Continue and Cancel
  4. Verify that after clicking Continue the modal is closed and attachment modal is shown
  5. Verify that you can preview all the valid attachments clicking carousel arrows
  6. Click Send in the attachment modal
  7. Verify that the valid attachments are sent
  8. Repeat steps 1.-3., this time click Cancel
  9. Verify that both modals - the error modal and the attachment modal close and the attachment flow is discontinued.
  10. Now try to drop a folder on an attachment or receipt dropzone <- IMPORTANT
  11. Verify that the error modal with an error message for folders appears <- IMPORTANT

RECEIPTS

[WEB / DESKTOP]

  1. FAB -> Create Expense -> Scan
  2. Drop several files on the drop zone
  3. Verify that you're redirected to the participant step
  4. Choose a participant, go to confirmation
  5. Verify that on the confirmation step you see the carousel for the receipts and the transactions count is equal to the receipts count and they are in the order they were dragged onto the dropzone <- IMPORTANT
  6. Click "Create expenses" - verify that the transactions are created

Adding a new file

  1. Repeat steps 1-5
  2. Go back to the Scan step
  3. Drop a few more files
  4. Go to the confirmation
  5. Verify that the transaction count is equal to the count of the files you've dropped in at the beginning and the files you've dropped later.

Starting the flow from the Chat

  1. Go to a DM or Workspace Chat
  2. Drop several files on the drop zone
  3. Verify that you're redirected to the confirmation step
  4. Verify that the participant is displayed correctly
  5. Click "Create expenses" - verify that the transactions are created

Error handling

  1. Start the IOU flow either from the FAB or the chat
  2. Drop several files - choose some that exceed size limit (10MB), doesn't have a supported type or drop more than 30 files
  3. Verify that the error modal appears with a correct message
  4. Click Continue - verify that you are navigated to the next step
  5. On confirmation step verify that only valid files were added
  6. If all the files were not valid, verify that instead of continuing the flow, the flow was cancelled
  7. Start the IOU flow either from the FAB or the chat
  8. Drop a folder <- IMPORTANT
  9. Verify that the error modal with a correct message for folder appears <- IMPORTANT

[MOBILE]

  1. FAB -> Create Expense -> Scan
  2. Click Gallery button -> Choose FIles / Choose from Gallery
  3. Verify that you can select several files
  4. Verify that you're redirected to the participant step
  5. Choose a participant, go to confirmation
  6. Verify that on the confirmation step you see the carousel for the receipts and the transactions count is equal to the receipts count
  7. Click "Create expenses" - verify that the transactions are created
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-07-21.at.19.24.17.mp4
Android: mWeb Chrome
Screen.Recording.2025-07-21.at.16.40.20.mp4
iOS: Native
Screen.Recording.2025-07-21.at.13.05.00.mp4
Screen.Recording.2025-07-21.at.12.50.00.mp4
iOS: mWeb Safari
Screen.Recording.2025-07-21.at.13.12.53.mp4
Screen.Recording.2025-07-21.at.13.11.24.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-07-21.at.11.37.45.mp4
Screen.Recording.2025-07-21.at.11.36.19.mp4
MacOS: Desktop
Screen.Recording.2025-07-21.at.12.06.26.mp4
Screen.Recording.2025-07-21.at.12.05.48.mp4

@github-actions
Copy link
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2025

@rayane-d Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@DylanDylann
Copy link
Contributor

@rayane-d I already got assigned to the issue, let me review this PR

@DylanDylann
Copy link
Contributor

BUG: "Choose recipient" RHP still display when closing the error modal

Screen.Recording.2025-07-22.at.15.22.52.mov

@DylanDylann
Copy link
Contributor

BUG: The PDF file displays at first, although I select it in the third position

Screen.Recording.2025-07-22.at.15.27.25.mov

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

BUG: The PDF file displays at first, although I select it in the third position

Screen.Recording.2025-07-22.at.15.27.25.mov

@DylanDylann It won't work this way - look at how the files are dragged - the pdf you selected as last is first in the dragged batch. I have no means to control the order of selection from the folder to drag. That's why I wrote in the test steps - in the order they were dragged onto the dropzone (I had no better idea how to explain that)

@DylanDylann
Copy link
Contributor

BUG:

  • When uploading a single file (22,4MB), the error display "Attachment size is larger than 10 MB limit"
  • When uploading two file (22,4MB and 300kb), the error display "Files must be under 24 MB. Any larger files won't be uploaded."

--> It seems inconsistent. And in the second time, there are no file larger than 24MB

Screen.Recording.2025-07-22.at.15.39.53.mov

@DylanDylann
Copy link
Contributor

@DylanDylann It won't work this way - look at how the files are dragged - the pdf you selected as last is first in the dragged batch. I have no means to control the order of selection from the folder to drag. That's why I wrote in the test steps - in the order they were dragged onto the dropzone (I had no better idea how to explain that)

Ah oke, got it

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@DylanDylann the selection order is preserved when you select from the Add Attachment picker
Screenshot 2025-07-22 at 10 46 20

@DylanDylann
Copy link
Contributor

BUG: In the video below, the Continue button doesn't display in the second error modal. As I understand, we always display the Continue button if there are still next error modals or if there is any valid file. We only don't display the Continue button if this is the last error modal and there are no valid files

Screen.Recording.2025-07-22.at.15.47.59.mov

@DylanDylann
Copy link
Contributor

@koko57 Could we disable the folder in the picker? It means that users can't drag a folder to our dropzone

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@koko57 Could we disable the folder in the picker? It means that users can't drag a folder to our dropzone

the picker open the folders to choose a file from the folder. You cannot restrict dragging a folder onto the dropzone. Why would you want that?

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@DylanDylann but what part do you mean - you can drag anything on the dropzone - I can't restrict that because it's dragging files from the system UI (finder, file explorer, whatever you call it). I don't have an access there. The user can select anything and drag anything.

For the pickers - it's how the pickers work and I also cannot do anything about that - you can open a folder not select it.

If I understood you correctly you mean this behavior of selecting the files to drag vs selecting the files from picker - I cannot make them work the same bc it's how the system works.

Dragging on the dropzone works the same way for attachments and receipts. Same with pickers - should work the same for both attachments and receipts. But I can't make selecting files for drop and selecting files from the picker work the same

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

BUG: In the video below, the Continue button doesn't display in the second error modal. As I understand, we always display the Continue button if there are still next error modals or if there is any valid file. We only don't display the Continue button if this is the last error modal and there are no valid files

Screen.Recording.2025-07-22.at.15.47.59.mov

@DylanDylann I'm having a problem with reproducing this one, could you please share a bit more details of the files you used?

@DylanDylann
Copy link
Contributor

Sent via Slack

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@DylanDylann thank you! the bug is now fixed

@DylanDylann
Copy link
Contributor

DylanDylann commented Jul 22, 2025

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-07-23.at.16.48.17.mov
Android: mWeb Chrome
Screen.Recording.2025-07-23.at.16.50.08.mov
iOS: HybridApp

My IOS crashed when opening the file selection and I still try to fix. It isn;t related to our PR

iOS: mWeb Safari
Screen.Recording.2025-07-23.at.16.40.24.mov
MacOS: Chrome / Safari
Screen.Recording.2025-07-23.at.16.09.45.mov
MacOS: Desktop
Screen.Recording.2025-07-23.at.16.08.09.mov

<>
<Modal
type={modalType}
type={CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koko57 Why do you change this line?

I see a comment

If our attachment is a PDF, return the unswipeable Modal type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because modal type was chosen right after validation. As we removed validation it will always be CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE (as a default state value) so we don't need to have a state for that as it won't be changed anymore

setIsLoaderVisible(true);

return Promise.all(otherFiles.map((file) => convertHeicImageToJpegPromise(file))).then((convertedImages) => {
// Update originalFileOrder map with converted files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Update originalFileOrder map with converted files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koko57 Could you remove some redundant comment?

collectedErrors.current = [];

Promise.all(files.map((file) => isValidFile(file, files.length > 1).then((isValid) => (isValid ? file : null))))
// Store original file order using URI as key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Store original file order using URI as key

// Check if we need to resize images
if (convertedImages.some((file) => (file.size ?? 0) > CONST.API_ATTACHMENT_VALIDATIONS.RECEIPT_MAX_SIZE)) {
return Promise.all(convertedImages.map((file) => resizeImageIfNeeded(file))).then((processedFiles) => {
// Update originalFileOrder map with resized files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Update originalFileOrder map with resized files

if (otherFiles.some((file) => (file.size ?? 0) > CONST.API_ATTACHMENT_VALIDATIONS.RECEIPT_MAX_SIZE)) {
setIsLoaderVisible(true);
return Promise.all(otherFiles.map((file) => resizeImageIfNeeded(file))).then((processedFiles) => {
// Update originalFileOrder map with resized files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Update originalFileOrder map with resized files

@DylanDylann
Copy link
Contributor

@koko57 Some minor comments. The rest looks fine to me

@DylanDylann
Copy link
Contributor

DylanDylann commented Jul 22, 2025

@koko57 There is one more problem, both attachment and receipt modal are displayed when trying to drag many type of files (Only happen on Desktop App)

Screen.Recording.2025-07-22.at.17.54.36.mov

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@DylanDylann does it happen consistently? What OS are you on? I cannot repro

@DylanDylann
Copy link
Contributor

@koko57 Yes, It happens consistently on desktop App. I am using macOS 15.5

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

hmmm, I was suspecting Windows. Running the same OS, cannot recreate it. Any more details why it might happen? Can you compare it with the production version? I guess if the problem was persistent it would be already reported. The code doesn't touch the dropzones behavior on drop, only the validation, so it shouldn't be the problem

@DylanDylann
Copy link
Contributor

@koko57 Let me investigate on my side

@koko57
Copy link
Contributor Author

koko57 commented Jul 22, 2025

@DylanDylann ok, thanks!

@DylanDylann
Copy link
Contributor

I will give an update tomorrow

@DylanDylann
Copy link
Contributor

DylanDylann commented Jul 23, 2025

Hmmm, I tried many times but can't reproduce the above bug anymore. It's so weird. Anyways, I will continue processing this PR. We may handle it later if it happens again

@koko57
Copy link
Contributor Author

koko57 commented Jul 23, 2025

@DylanDylann great, thanks! yeah, we'll handle it later if it still occurs or someone reports it

Copy link
Contributor

@DylanDylann DylanDylann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot bot requested a review from lakchote July 23, 2025 09:52
@DylanDylann
Copy link
Contributor

@koko57 Kindly bump: #66812 (comment)

@koko57
Copy link
Contributor Author

koko57 commented Jul 23, 2025

@DylanDylann done!

@koko57
Copy link
Contributor Author

koko57 commented Jul 23, 2025

checkspell failing but not because of this PR

@lakchote lakchote merged commit d692cdc into Expensify:main Jul 23, 2025
18 checks passed
@github-actions
Copy link
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.86-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.1.86-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants