mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible by Krishna2323 · Pull Request #67010 · Expensify/App

Krishna2323 · 2025-07-23T20:56:33Z

Explanation of Change

Fixed Issues

$ #64107
PROPOSAL: #64107 (comment)

Tests

Open a Workspace chat
Tap plus icon> Create expense
Enter amount & tap next
Tap merchant
Enter a text
Tap top app's left arrow
Note Discard changes pop up box is displayed
Tap device back button
Verify discard changes popup is closed without navigating back

Verify that no errors appear in the JS console

Offline tests

Open a Workspace chat
Tap plus icon> Create expense
Enter amount & tap next
Tap merchant
Enter a text
Tap top app's left arrow
Note Discard changes pop up box is displayed
Tap device back button
Verify discard changes popup is closed without navigating back

QA Steps

Open a Workspace chat
Tap plus icon> Create expense
Enter amount & tap next
Tap merchant
Enter a text
Tap top app's left arrow
Note Discard changes pop up box is displayed
Tap device back button
Verify discard changes popup is closed without navigating back

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…anges popup briefly visible. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-07-24T20:32:25Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2025-08-04T05:16:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

discardAndroid.mov

Android: mWeb Chrome

discardAndroidmWeb.mov

iOS: HybridApp

discardiOS.mov

iOS: mWeb Safari

discardiOSmWeb.mov

MacOS: Chrome / Safari

discardChrome.mov

MacOS: Desktop

discardDesktop.mov

c3024

LGTM!

MarioExpensify

This is really good, thank you @Krishna2323 and @c3024

OSBotify · 2025-08-04T12:24:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-04T19:59:42Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-06T19:30:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

suneox · 2025-12-25T08:13:59Z

src/pages/iou/request/step/DiscardChangesConfirmation/index.tsx

+            onModalHide={() => {
+                shouldNavigateBack.current = false;
+                onCancel?.();
+            }}


Coming from #75014 BugZero checklist:

This PR caused a regression where users cannot discard unsaved changes in the description field on Android mWeb when using the browser back button.

Root Cause: The onModalHide callback added in this PR creates a race condition with the InteractionManager.runAfterInteractions() in the onConfirm handler. The callback sets shouldNavigateBack.current = false immediately when the modal starts hiding, but the navigation logic is queued to run after animations complete. By the time the navigation logic executes, the flag has already been reset, causing an early return before navigation can occur.

The Issue: When users confirm "Discard changes", the modal closes but they remain on the same page with their unsaved text still in the field.

Current Fix: The fix in #76492 addresses this by:

Adding an isConfirmed ref to track whether user confirmed or cancelled

Only resetting shouldNavigateBack.current when user cancels

Using setNavigationActionToMicrotaskQueue() to ensure proper execution timing

Krishna2323 added 2 commits July 14, 2025 22:09

fix: mWeb - Incorrect navigation to confirm details page & discard ch…

98de762

…anges popup briefly visible. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/64107_2

dcbea93

Krishna2323 changed the title ~~Krishna2323/issue/64107 2~~ mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible Jul 23, 2025

Krishna2323 marked this pull request as ready for review July 24, 2025 20:32

Krishna2323 requested a review from a team as a code owner July 24, 2025 20:32

melvin-bot bot requested review from c3024 and removed request for a team July 24, 2025 20:32

Krishna2323 mentioned this pull request Jul 24, 2025

[Due for payment 2025-08-13] [$250] mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible #64107

Closed

8 tasks

Merge branch 'Expensify:main' into krishna2323/issue/64107_2

c095444

c3024 approved these changes Aug 4, 2025

View reviewed changes

melvin-bot bot requested a review from MarioExpensify August 4, 2025 07:51

MarioExpensify approved these changes Aug 4, 2025

View reviewed changes

MarioExpensify merged commit e246376 into Expensify:main Aug 4, 2025
19 checks passed

github-actions bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

c3024 mentioned this pull request Aug 13, 2025

fix: discard changes modal not show when using browser back button #56527

Merged

50 tasks

tsa321 mentioned this pull request Nov 30, 2025

[Due for payment 2025-12-25] [$250] Expense: Unable to discard the filled description #75014

Closed

8 tasks

suneox reviewed Dec 25, 2025

View reviewed changes

blazejkustra mentioned this pull request Feb 20, 2026

[$250] [BATCH 1] Migrate ConfirmModals & ReanimatedModals #83061

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible#67010

mWeb - Incorrect navigation to confirm details page & discard changes popup briefly visible#67010
MarioExpensify merged 3 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/64107_2

Krishna2323 commented Jul 23, 2025 •

edited

Loading

Uh oh!

melvin-bot bot commented Jul 24, 2025

Uh oh!

c3024 commented Aug 4, 2025 •

edited

Loading

Uh oh!

c3024 left a comment

Uh oh!

MarioExpensify left a comment

Uh oh!

Uh oh!

OSBotify commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

suneox Dec 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Krishna2323 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 24, 2025

Uh oh!

c3024 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

suneox Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented Jul 23, 2025 •

edited

Loading

c3024 commented Aug 4, 2025 •

edited

Loading