[SIDE PANEL] Update the logic and fix help panel appearing without NVP#67159
Conversation
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dominictb what's your ETA on review? |
|
It's midnight here. I'll review this in the morning (~ several hours). |
|
Perfect, thank you! @dominictb |
|
Bump on the above @dominictb |
|
Anything else other than this bug? @dominictb
I tried it locally and it looks different to me, have you added additional padding? |
|
The margin bug only happens if the text below the list is not a heading. Because the heading text itself already has top margin. For example: App/help/ref/workspaces/:policyID/members/index.md Lines 32 to 39 in b70d010 |
|
That's all. Testing on mobile is all good. |
|
After some trial and error, I finally managed to fix it!💡Here's the final result:
@dominictb let me know wdyt 😄 |
|
Performance tests are flaky lately @dominictb, so don't mind it 🙏 |
|
What's the ETA here? |
|
@dominictb is going to review today |
Reviewer Checklist
Screenshots/Videos |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #68462 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚀Deployed to NewHelp production! 🚀 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.1.98-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀
|























Explanation of Change
Fixed Issues
$ #68462
PROPOSAL: N/A
Tests
Prerequisites:
Open help panel on several pages and verify that the content is correct:
Private chat:

Concierge:

Create distance expense:

Workspace:

Open the help panel on all platforms and verify it works and animates correctly.
Offline tests
N/A
QA Steps
Same as tests +
Native Android:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
untitled.webm
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-13.at.19.19.40.mp4
MacOS: Chrome / Safari
QuickTime.movie.mov