Skip to content

Conversation

@MrMuzyk
Copy link
Contributor

@MrMuzyk MrMuzyk commented Jul 25, 2025

Explanation of Change

  • added new option on Wallet page - enabling global reimbursements for business accounts (its behind beta currently)
  • added new route where we display flow of enabling global reimbursements for business accounts
  • created new reusable full step and sub step components
  • refactored non USD flow to use freshly created components

Fixed Issues

$ #66995
PROPOSAL:

Tests

Same as QA steps

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Scenario A:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and doesnt have a + in it's login email

  1. Create new CAD/AUD workspace
  2. Go to workflows and press on Connect bank account
  3. Header should show 7 steps
  4. Proceed to step 6
  5. Accept all agreements and proceed to step 7
  6. Upload a previously downloaded form and finish the flow

Scenario B:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and doesnt have a + in it's login email

  1. Create new GBP workspace
  2. Go to workflows and press on Connect bank account
  3. Header should show 7 steps
  4. Proceed to step 6
  5. Accept all agreements and finish the flow

Scenario C:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and has added and verified USD business reimbursements account

  1. Go to Account -> Wallet
  2. Press on verified USD business reimbursements account
  3. New option Enable global reimbursements should show in popover
  4. Click on the new option and go to new flow
  5. Flow consisting 2 steps should be shown
  6. Accept all agreements and go to 2nd step
  7. Upload a file and submit it
  8. After pressing on the account from the list user shouldn't see Enable global reimbursements option anymore as he just enabled them
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4

@MrMuzyk MrMuzyk marked this pull request as ready for review August 13, 2025 11:19
@MrMuzyk MrMuzyk requested a review from a team as a code owner August 13, 2025 11:19
@melvin-bot melvin-bot bot requested a review from hungvu193 August 13, 2025 11:19
@melvin-bot
Copy link

melvin-bot bot commented Aug 13, 2025

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team August 13, 2025 11:19
@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 13, 2025

Hey @hungvu193! This is ready for review but there are 2 things to keep in mind.

  1. Im waiting for confirmation of translations
  2. Finals API call is failing at the moment. This is most likely purely BE issue that should get resolved without any FE changes. Once its done then the final bit of the flow can be tested

Copy link
Contributor

@hungvu193 hungvu193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a big one. I'll do some testing start off the week

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 18, 2025

@hungvu193 I've pushed requested changes. You're still yet to test it, right?

@hungvu193
Copy link
Contributor

@hungvu193 I've pushed requested changes. You're still yet to test it, right?

Yeah. I'll do it later today

@hungvu193
Copy link
Contributor

@MrMuzyk how did you add business bank account in wallet page?

Screenshot 2025-08-18 at 17 50 25

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 18, 2025

Followed this guide

@hungvu193
Copy link
Contributor

I did the same thing. Btw did you connect bank account in this wallet page or from a different page? I'm seeing that from wallet page it's redirected to personal bank account flow.

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 18, 2025

From Workspaces -> workflows. Has to be business account I think

@hungvu193
Copy link
Contributor

From Workspaces -> workflows. Has to be business account I think

I see. Btw, let's clear the error if we close the flow:

Screen.Recording.2025-08-18.at.18.06.19.mov

@madmax330
Copy link
Contributor

Oh nice catch, I will get a PR for that right away

@madmax330
Copy link
Contributor

@hungvu193 can you finish the review here as well?
I've made the backend fix for the issue mentioned above, but we should not block the pr on this

@hungvu193
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Androidhybrid.mov
Android: mWeb Chrome
Screen.Recording.2025-08-18.at.22.34.22.mov
iOS: HybridApp
Screen.Recording.2025-08-18.at.22.50.58.mov
iOS: mWeb Safari
Screen.Recording.2025-08-18.at.22.29.45.mov
MacOS: Chrome / Safari
Screen.Recording.2025-08-18.at.22.09.05.mov
Screen.Recording.2025-08-18.at.22.07.24.mov
MacOS: Desktop
Screen.Recording.2025-08-18.at.22.28.48.mov

@melvin-bot melvin-bot bot requested a review from madmax330 August 27, 2025 15:36
@madmax330 madmax330 merged commit f113df6 into Expensify:main Aug 27, 2025
21 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kavimuru
Copy link

@hungvu193 @MrMuzyk @madmax330
globalReimbursementsOnND beta enabled - which domain is beta enabled?

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.0-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@hungvu193
Copy link
Contributor

@hungvu193 @MrMuzyk @madmax330 globalReimbursementsOnND beta enabled - which domain is beta enabled?

globalReimbursementsOnND is the beta name, I thought all the applause testing email will have all beta enabled by default. No?

@IuliiaHerets
Copy link

@hungvu193 Do we have to use an account without +? Because we only use applausefail+ accounts for testing, where the beta version is used. The account without + is the main one, and we cannot use it for testing

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 28, 2025

@IuliiaHerets Account with a + will not let you get past the final step and see the finish screen - Corpay treats such emails as invalid. If you dont have account without a + then maybe we can change the condition Ive made for testing to work on staging too. Wdyt @hungvu193 ?

@hungvu193
Copy link
Contributor

@MrMuzyk That's cool but let's also add it under beta 😄 So we can remove it later once we remove beta check.

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Aug 28, 2025

Followup is up :)

@kavimuru
Copy link

@MrMuzyk @hungvu193 let us know when we are good to use alias email accounts to test this PR.

@hungvu193
Copy link
Contributor

hungvu193 commented Sep 2, 2025

@MrMuzyk @hungvu193 let us know when we are good to use alias email accounts to test this PR.

@kavimuru You can test this PR on #69433, it added an additional check so you can test it with email that has "+" symbol.

@kavimuru
Copy link

kavimuru commented Sep 2, 2025

@hungvu193 Can we use any random data on the fields? Throwing error if we use random data.

20250902_202456.mp4
20250902_203120.mp4

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Sep 2, 2025

@kavimuru Looking at the recording probably this PR is not yet on staging because it shouldn't let you get passed by Step 5 by pressing on Hang tight button. This PR that I've linked is the final missing piece.

Can you try checking Yes in Step 5 when asked whether you're director or senior officer?

@kavimuru
Copy link

kavimuru commented Sep 2, 2025

@MrMuzyk still the same.

20250902_213541.mp4

@arosiclair
Copy link
Contributor

@MrMuzyk @hungvu193 @madmax330 the QA steps seem incomplete here. I'm going to check this off since this is a new feature, but please QA on production 🙏

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 failure ❌
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2025

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MrMuzyk
Copy link
Contributor Author

MrMuzyk commented Sep 5, 2025

@arosiclair Hey, what seems to be missing in your opinion so I prepare better QA steps next time?

@arosiclair
Copy link
Contributor

It sounds like QA was having trouble with your preconditions so I think we should include more details to set that up before merging. Or possibly just reach out to Applause directly about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants