-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: Enable Global Reimbursements for USD accounts #67172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Global Reimbursements for USD accounts #67172
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey @hungvu193! This is ready for review but there are 2 things to keep in mind.
|
hungvu193
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a big one. I'll do some testing start off the week
|
@hungvu193 I've pushed requested changes. You're still yet to test it, right? |
Yeah. I'll do it later today |
|
@MrMuzyk how did you add business bank account in wallet page?
|
|
I did the same thing. Btw did you connect bank account in this wallet page or from a different page? I'm seeing that from wallet page it's redirected to personal bank account flow. |
|
From Workspaces -> workflows. Has to be business account I think |
I see. Btw, let's clear the error if we close the flow: Screen.Recording.2025-08-18.at.18.06.19.mov |
|
Oh nice catch, I will get a PR for that right away |
|
@hungvu193 can you finish the review here as well? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroidhybrid.movAndroid: mWeb ChromeScreen.Recording.2025-08-18.at.22.34.22.moviOS: HybridAppScreen.Recording.2025-08-18.at.22.50.58.moviOS: mWeb SafariScreen.Recording.2025-08-18.at.22.29.45.movMacOS: Chrome / SafariScreen.Recording.2025-08-18.at.22.09.05.movScreen.Recording.2025-08-18.at.22.07.24.movMacOS: DesktopScreen.Recording.2025-08-18.at.22.28.48.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@hungvu193 @MrMuzyk @madmax330 |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.0-0 🚀
|
|
|
@hungvu193 Do we have to use an account without +? Because we only use applausefail+ accounts for testing, where the beta version is used. The account without + is the main one, and we cannot use it for testing |
|
@IuliiaHerets Account with a + will not let you get past the final step and see the finish screen - Corpay treats such emails as invalid. If you dont have account without a + then maybe we can change the condition Ive made for testing to work on staging too. Wdyt @hungvu193 ? |
|
@MrMuzyk That's cool but let's also add it under beta 😄 So we can remove it later once we remove beta check. |
|
@MrMuzyk @hungvu193 let us know when we are good to use alias email accounts to test this PR. |
@kavimuru You can test this PR on #69433, it added an additional check so you can test it with email that has "+" symbol. |
|
@hungvu193 Can we use any random data on the fields? Throwing error if we use random data. 20250902_202456.mp420250902_203120.mp4 |
|
@MrMuzyk still the same. 20250902_213541.mp4 |
|
@MrMuzyk @hungvu193 @madmax330 the QA steps seem incomplete here. I'm going to check this off since this is a new feature, but please QA on production 🙏 |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
@arosiclair Hey, what seems to be missing in your opinion so I prepare better QA steps next time? |
|
It sounds like QA was having trouble with your preconditions so I think we should include more details to set that up before merging. Or possibly just reach out to Applause directly about it. |

Explanation of Change
Fixed Issues
$ #66995
PROPOSAL:
Tests
Same as QA steps
Offline tests
QA Steps
Scenario A:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and doesnt have a + in it's login email
Scenario B:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and doesnt have a + in it's login email
Scenario C:
Precondition: Be on account that has globalReimbursementsOnND beta enabled and has added and verified USD business reimbursements account
Enable global reimbursementsshould show in popoverEnable global reimbursementsoption anymore as he just enabled themPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4