[NoQA] Show the TestDrive demo to users if they migrated from Classic by fabioh8010 · Pull Request #67348 · Expensify/App

fabioh8010 · 2025-07-29T17:19:19Z

Explanation of Change

Slack thread: https://expensify.slack.com/archives/C07HPDRELLD/p1753694192775019

Fixed Issues

$ #67447
PROPOSAL:

Tests

Login with a new account in NewDot
Go to Account -> Switch to Expensify Classic
In OldDot, run NVP.set('introSelected', null); in the Web Console to remove the user's introSelected data.
Run JSON.stringify(NVP.get('tryNewDot')) to get the user's tryNewDot NVP data.

Add "nudgeMigration": {"timestamp": "2025-06-20T13:53:07.597Z"} to this data and set to the user again with NVP.set('tryNewDot', <nvp_data>);, where <nvp_data> is the JSON data you just edited. For example:

NVP.set('tryNewDot',{
    "classicRedirect": {
        "completedHybridAppOnboarding": true,
        "dismissed": true,
        "dismissedReasons": [
            {
                "reason": "featureNotAvailable - 1",
                "timestamp": "2025-07-29 18:34:45.269"
            }
        ],
        "timestamp": "2025-07-29 18:34:45.269"
    },
    "nudgeMigration": {
        "timestamp": "2025-06-20T13:53:07.597Z"
    }
});

Go back to NewDot, assert you see the migrated user welcome modal.
Go to FAB and click the Take a 2-minute test drive option. Assert you see the Employee demo if you are not the Admin of an Workspace, or the Admin demo if you are the Admin of an Workspace.

NOTES:

To test in Android/iOS, my advice is to do Steps 1-5 in the browser, and 6-7 in the native app.
Since we are using an unconventional flow to test the migrated user (NewDot account -> Classic -> NewDot again), we'll have the Test Drive task in Concierge because the account was created in NewDot. You can safely ignore this use case because this won't happen in the normal situation (OldDot user -> Migrate to NewDot).

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Admin demo

Screen.Recording.2025-07-30.at.18.33.38-compressed.mov

Android: mWeb Chrome

Admin demo

Screen.Recording.2025-07-30.at.18.40.32-compressed.mov

iOS: Native

Employee demo

Screen.Recording.2025-07-30.at.18.51.55-compressed.mov

iOS: mWeb Safari

Employee demo

Screen.Recording.2025-07-30.at.18.56.53-compressed.mov

MacOS: Chrome / Safari

Admin demo

Screen.Recording.2025-07-30.at.19.02.23-compressed.mov

Employee demo

Screen.Recording.2025-07-30.at.19.07.02-compressed.mov

MacOS: Desktop

Admin demo

Screen.Recording.2025-07-30.at.19.11.54-compressed.mov

src/libs/TourUtils.ts

danieldoglas

We have some other calls to the test drive route, do we need to check those out too?

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Lines 101 to 103 in cbe1f49

    
           InteractionManager.runAfterInteractions(() => { 
        
               Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route); 
        
           });

App/src/libs/ReportUtils.ts

Lines 10145 to 10152 in cbe1f49

    
           let testDriveURL: string; 
        
           if (([CONST.ONBOARDING_CHOICES.MANAGE_TEAM, CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER, CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE] as OnboardingPurpose[]).includes(engagementChoice)) { 
        
               testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT; 
        
           } else if (introSelected?.choice === CONST.ONBOARDING_CHOICES.SUBMIT && introSelected.inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) { 
        
               testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT; 
        
           } else { 
        
               testDriveURL = ROUTES.TEST_DRIVE_MODAL_ROOT.route; 
        
           }

App/src/libs/navigateAfterOnboarding.ts

Lines 45 to 50 in cbe1f49

    
           // We're using Navigation.isNavigationReady here because without it, on iOS, 
        
           // Navigation.dismissModal runs after Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route) 
        
           // And dismisses the modal before it even shows 
        
           Navigation.isNavigationReady().then(() => { 
        
               Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route); 
        
           });

fabioh8010 · 2025-07-30T16:24:46Z

We have some other calls to the test drive route, do we need to check those out too?

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Lines 101 to 103 in cbe1f49

InteractionManager.runAfterInteractions(() => {

Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);

});

App/src/libs/ReportUtils.ts

Lines 10145 to 10152 in cbe1f49

let testDriveURL: string;

if (([CONST.ONBOARDING_CHOICES.MANAGE_TEAM, CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER, CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE] as OnboardingPurpose[]).includes(engagementChoice)) {

testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT;

} else if (introSelected?.choice === CONST.ONBOARDING_CHOICES.SUBMIT && introSelected.inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) {

testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT;

} else {

testDriveURL = ROUTES.TEST_DRIVE_MODAL_ROOT.route;

}

App/src/libs/navigateAfterOnboarding.ts

Lines 45 to 50 in cbe1f49

// We're using Navigation.isNavigationReady here because without it, on iOS,

// Navigation.dismissModal runs after Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route)

// And dismisses the modal before it even shows

Navigation.isNavigationReady().then(() => {

Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);

});

From my tests the migrated user doesn't pass through the onboarding flow, so we don't need to check these.

src/components/TestDrive/TestDriveDemo.tsx

…ve-migrated-accounts

melvin-bot · 2025-07-30T18:24:21Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2025-07-30T19:04:11Z

testing...

…ve-migrated-accounts

parasharrajat · 2025-07-31T14:22:12Z

Testing it again now.

…ve-migrated-accounts

parasharrajat · 2025-08-01T15:00:35Z

Thanks for waiting. We had a dev server issue earlier, which has been resolved now. I will try to prioritize this asap.

danieldoglas · 2025-08-01T19:00:17Z

@parasharrajat let's please move this one forward ASAP.

parasharrajat · 2025-08-01T19:01:08Z

Yes. I will have updates coming shortly.

parasharrajat · 2025-08-01T20:52:12Z

BUG: IOS SAFARI: Double-migrated user modal. It animates twice while hiding.

BUG: Also, clicking near the Let's go button on the modal hides it.

02.08.2025_02.20.16_REC.mp4

danieldoglas · 2025-08-01T20:53:14Z

Is that also happening on main?

parasharrajat · 2025-08-01T20:53:54Z

@danieldoglas is there a way to create an account on oldDot and remain on oldDot after account creation?

parasharrajat · 2025-08-01T20:54:09Z

Is that also happening on main?

Need to check that. Looking.

parasharrajat · 2025-08-01T21:25:13Z

It's not a glitch. I can reproduce everyone only on this PR.

02.08.2025_02.54.22_REC.mp4

fabioh8010 · 2025-08-04T13:26:40Z

Tested here and seems to happen only in this PR, looking for a fix.

fabioh8010 · 2025-08-04T13:32:51Z

Although I dont understand why this would happen as my PR is not touching the part responsible for showing the modal, maybe my test steps/scenario is wrong.. investigating it.

fabioh8010 · 2025-08-04T13:57:41Z

@parasharrajat Actually I was able to reproduce on main (dev) now, this part is being executed twice and thus making two modals appear

App/src/hooks/useOnboardingFlow.ts

Lines 64 to 70 in 18d4f1e

    
           if (hasBeenAddedToNudgeMigration && !isProductTrainingElementDismissed('migratedUserWelcomeModal', dismissedProductTraining)) { 
        
               const defaultCannedQuery = buildCannedSearchQuery(); 
        
               const query = defaultCannedQuery; 
        
               Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query})); 
        
               Navigation.navigate(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(true)); 
        
               return; 
        
           }

Screen.Recording.2025-08-04.at.14.53.31.mov

I think there's something wrong with the test steps that is producing a invalid user's state. @danieldoglas Could you confirm if a migrated user from Classic have the exact structure for this NVP?

NVP.set('tryNewDot',{
    "classicRedirect": {
        "completedHybridAppOnboarding": true,
        "dismissed": true,
        "dismissedReasons": [
            {
                "reason": "featureNotAvailable - 1",
                "timestamp": "2025-07-29 18:34:45.269"
            }
        ],
        "timestamp": "2025-07-29 18:34:45.269"
    },
    "nudgeMigration": {
        "timestamp": "2025-06-20T13:53:07.597Z"
    }
});

parasharrajat · 2025-08-04T15:24:55Z

Yeah, this is a tricky case to test, as we have to manipulate the data for testing. We can't replicate a real migrated user, as after login, oldDot forwards the user to newDot for onboarding.

danieldoglas · 2025-08-04T20:07:03Z

@parasharrajat what are we missing to finish this here?

parasharrajat · 2025-08-04T20:08:32Z

There is an issue reported above #67348 (comment). I am waiting on resoluton on that.

parasharrajat · 2025-08-04T20:09:29Z

Here is the continued discussion #67348 (comment)

fabioh8010 · 2025-08-05T14:06:10Z

I discussed with @danieldoglas and we think this bug was already on main for some time now, and we agreed to investigate it and try to fix in this PR.

parasharrajat · 2025-08-05T14:08:12Z

Ok, Thanks for the update. Please let me know when it is ready for another review.

…ve-migrated-accounts

fabioh8010 · 2025-08-06T14:12:58Z

@parasharrajat Could you test it again? It should be fixed now.

fabioh8010 · 2025-08-06T14:17:40Z

There is one TS error, looking

parasharrajat · 2025-08-06T17:40:18Z

Screenshots

🔲 iOS / native

02.08.2025_02.07.57_REC.mp4

🔲 iOS / Safari

06.08.2025_23.08.59_REC.mp4

🔲 MacOS / Desktop

02.08.2025_01.45.38_REC.mp4

🔲 MacOS / Chrome

02.08.2025_01.38.46_REC.mp4

🔲 Android / Chrome

02.08.2025_01.57.41_REC.mp4

🔲 Android / native

02.08.2025_01.57.41_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2025-08-06T18:33:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-08-06T20:16:16Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.1.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-08T02:08:31Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fabioh8010 added 2 commits July 29, 2025 17:40

Extract startTestDrive logic to its TourUtils

1aceecf

Show the TestDrive demo to users if they migrated from Classic

8c8ed9f

danieldoglas reviewed Jul 29, 2025

View reviewed changes

src/libs/TourUtils.ts Outdated Show resolved Hide resolved

danieldoglas reviewed Jul 29, 2025

View reviewed changes

Move startTestDrive function to action file

d15d5d9

fabioh8010 changed the title ~~Show the TestDrive demo to users if they migrated from Classic~~ [WIP] Show the TestDrive demo to users if they migrated from Classic Jul 30, 2025

Check if user is admin of workspace when is migrated user

d7b3653

danieldoglas reviewed Jul 30, 2025

View reviewed changes

src/components/TestDrive/TestDriveDemo.tsx Show resolved Hide resolved

fabioh8010 added 2 commits July 30, 2025 18:15

Merge remote-tracking branch 'origin/main' into bugfix/start-test-dri…

7060b32

…ve-migrated-accounts

Fix isUserPolicyAdmin function

baf0ad1

fabioh8010 changed the title ~~[WIP] Show the TestDrive demo to users if they migrated from Classic~~ [NoQA] Show the TestDrive demo to users if they migrated from Classic Jul 30, 2025

fabioh8010 requested a review from danieldoglas July 30, 2025 18:23

fabioh8010 marked this pull request as ready for review July 30, 2025 18:23

fabioh8010 requested a review from a team as a code owner July 30, 2025 18:23

melvin-bot bot requested review from mollfpr and removed request for a team July 30, 2025 18:24

danieldoglas assigned fabioh8010 Jul 30, 2025

Merge remote-tracking branch 'origin/main' into bugfix/start-test-dri…

f4145a8

…ve-migrated-accounts

Merge remote-tracking branch 'origin/main' into bugfix/start-test-dri…

2f15e7d

…ve-migrated-accounts

Merge branch 'main' into bugfix/start-test-drive-migrated-accounts

e5b21a6

Merge branch 'main' into bugfix/start-test-drive-migrated-accounts

4a6c409

fabioh8010 added 3 commits August 5, 2025 17:26

Merge branch 'main' into bugfix/start-test-drive-migrated-accounts

78ac2f6

Merge remote-tracking branch 'origin/main' into bugfix/start-test-dri…

0f16811

…ve-migrated-accounts

Fix duplicate migrated user modal

caa6b29

fabioh8010 added 2 commits August 6, 2025 15:29

Fix TS

26154a1

Fix Prettier

9044135

parasharrajat approved these changes Aug 6, 2025

View reviewed changes

danieldoglas approved these changes Aug 6, 2025

View reviewed changes

danieldoglas merged commit 99e0888 into Expensify:main Aug 6, 2025
20 checks passed

github-actions bot mentioned this pull request Aug 6, 2025

Deploy Checklist: New Expensify 2025-08-06 #68050

Closed

melvin-bot bot mentioned this pull request Aug 8, 2025

[Due for payment 2025-08-29] [$500] We're showing the wrong test drive when an user is migrated. #67447

Closed

daledah mentioned this pull request Aug 8, 2025

[Due for payment 2025-09-22] [$250] Workspace - Unable to select members of workspace chat from list. #68184

Closed

8 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 3] Migrate Navigation usage v2 #83064

Open

	InteractionManager.runAfterInteractions(() => {
	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
	});

	let testDriveURL: string;
	if (([CONST.ONBOARDING_CHOICES.MANAGE_TEAM, CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER, CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE] as OnboardingPurpose[]).includes(engagementChoice)) {
	testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT;
	} else if (introSelected?.choice === CONST.ONBOARDING_CHOICES.SUBMIT && introSelected.inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) {
	testDriveURL = ROUTES.TEST_DRIVE_DEMO_ROOT;
	} else {
	testDriveURL = ROUTES.TEST_DRIVE_MODAL_ROOT.route;
	}

	// We're using Navigation.isNavigationReady here because without it, on iOS,
	// Navigation.dismissModal runs after Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route)
	// And dismisses the modal before it even shows
	Navigation.isNavigationReady().then(() => {
	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
	});

Conversation

fabioh8010 commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

danieldoglas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabioh8010 commented Jul 30, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Jul 30, 2025

Uh oh!

parasharrajat commented Jul 30, 2025

Uh oh!

parasharrajat commented Jul 31, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

danieldoglas commented Aug 1, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

danieldoglas commented Aug 1, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

parasharrajat commented Aug 1, 2025

Uh oh!

fabioh8010 commented Aug 4, 2025

Uh oh!

fabioh8010 commented Aug 4, 2025

Uh oh!

fabioh8010 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Aug 4, 2025

Uh oh!

danieldoglas commented Aug 4, 2025

Uh oh!

parasharrajat commented Aug 4, 2025

Uh oh!

parasharrajat commented Aug 4, 2025

Uh oh!

fabioh8010 commented Aug 5, 2025

Uh oh!

parasharrajat commented Aug 5, 2025

Uh oh!

fabioh8010 commented Aug 6, 2025

Uh oh!

fabioh8010 commented Aug 6, 2025

Uh oh!

parasharrajat commented Aug 6, 2025

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented Aug 6, 2025

Uh oh!

fabioh8010 commented Jul 29, 2025 •

edited

Loading

danieldoglas left a comment •

edited

Loading

fabioh8010 commented Aug 4, 2025 •

edited

Loading