fix keyboard type#6762
fix keyboard type#6762puneetlath merged 4 commits intoExpensify:mainfrom thesahindia:thesahindia/ux/fix-keyboard-type
Conversation
MelvinBot
requested review from
parasharrajat and
puneetlath
and removed request for
a team
src/CONST.js
Outdated
| NUMERIC: 'numeric', | ||
| PHONE_PAD: 'phone-pad', | ||
| NUMBER_PAD: 'number-pad', | ||
| DECIMAL_PAD: 'decimal-pad', |
There was a problem hiding this comment.
I know in the original proposal we agreed in using the decimal-pad keyboard type. However, from reading this, it looks like numeric and decimal-pad are equivalent. So could we just use the existing numeric option instead of adding this new decimal-pad option?
There was a problem hiding this comment.
Hmm... If they are the same, it does not matter unless we depend on the virtual keyboard on Android/IOS. So @thesahindia Could you retest on platforms after this change?
There was a problem hiding this comment.
Both keyboards are giving the same results. So which one should be used? @parasharrajat
There was a problem hiding this comment.
So could we just use the existing numeric option instead of adding this new decimal-pad option?
From puneet's comment.
|
|
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
As Keyboard does not affect WEB| Desktop | Mobile web. it looks good to me.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @puneetlath in version: 1.1.21-2 🚀
|
|
🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀
|
4 participants
Details
Fixed keyboard type on
IOUAmountPagefor iPad & tabletFixed Issues
$ #6635
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android