Skip to content

fix image left alignment issue#6774

Merged
iwiznia merged 1 commit intoExpensify:mainfrom
railway17:han-fix-magnifying-glass
Dec 16, 2021
Merged

fix image left alignment issue#6774
iwiznia merged 1 commit intoExpensify:mainfrom
railway17:han-fix-magnifying-glass

Conversation

@railway17
Copy link
Contributor

@railway17 railway17 commented Dec 15, 2021

Details

Regress the image alignment issue

Fixed Issues

#6714

Tests

  1. Send the image to someone
  2. Open image by clicking image thumbnail

QA Steps

  1. Send the image to someone
  2. Open image by clicking the image thumbnail

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web testing

Desktop

Desktop testing

Android

Android testing

iOS

iOS testing

Mobile Web

Safari testing

@railway17 railway17 requested a review from a team as a code owner December 15, 2021 17:57
@MelvinBot MelvinBot requested review from iwiznia and parasharrajat and removed request for a team December 15, 2021 17:57
@railway17
Copy link
Contributor Author

railway17 commented Dec 15, 2021

Hi, @parasharrajat
Looks like you are right.
I have tried to find what was changed but failed.
It's strange but not sure how it was not displayed when I take a video in a previous pull request.
Anyway, I made changes based on the current code and created a pull request here.
Please review and let me know if you disagree.
Thank you

@parasharrajat
Copy link
Member

Please add testing videos for the rest of the platforms?

@railway17
Copy link
Contributor Author

I added 3 more videos for Android/iOS and iOS safari testing videos.
But as I mentioned here, mobile apps are
not using my changes.

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Looks good..

cc: @iwiznia

@iwiznia iwiznia merged commit 53e3e07 into Expensify:main Dec 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @iwiznia in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants