[No QA] Fix bugs in isPullRequestMergeable action#6787
Merged
Conversation
roryabraham
changed the title
Contributor
Author
|
Not sure why pullerbear got trigger-happy there |
Julesssss
approved these changes
Dec 16, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.21-2 🚀
|
Contributor
|
🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This fixes some inaccurate logs and incorrect retry count logic in the
isPullRequestMergeableaction. I discovered these bugs while investigating https://expensify.slack.com/archives/C03V9A4TB/p1639596103227400. While this action isn't actually the cause of our troubles there, this PR still corrects some code that was wrong.Fixed Issues
$ n/a
Tests
I added an automated unit test to cover this change.
Note: This test was guaranteed to take at least 3 minutes, so I added a ternary flag to speed it up for testing.
QA Steps
None.
Tested On
Jest / GitHub live testing only