Skip to content

[CP staging] Fix app stuck on Signing out dialog after signing out of classic on HybridApp#67905

Merged
Julesssss merged 2 commits intoExpensify:mainfrom
software-mansion-labs:war-in/fix-app-blocked-on-signing-out-dialog
Aug 5, 2025
Merged

[CP staging] Fix app stuck on Signing out dialog after signing out of classic on HybridApp#67905
Julesssss merged 2 commits intoExpensify:mainfrom
software-mansion-labs:war-in/fix-app-blocked-on-signing-out-dialog

Conversation

@war-in
Copy link
Copy Markdown
Contributor

@war-in war-in commented Aug 5, 2025 •
edited by Julesssss
Loading

Explanation of Change

We blocked on prefferedLocale being loaded, which caused the mentioned issue. Now we hide the dialog without waiting for the language to finish loading.
Even if the locales aren't loaded (for some reason) user will be able to continue signing in

Fixed Issues

$ #67812 (comment)
PROPOSAL:

Tests

  1. Sign in to NewDot in HybridApp
  2. Switch to classic with Account > Switch to...
  3. In classic navigate to settings
  4. Sign out
  5. You should be signed out and land at the NewDot sign in page
  6. it is known that the translations won't display correctly (issue)

Offline tests

QA Steps

  1. Sign in to NewDot in HybridApp
  2. Switch to classic with Account > Switch to...
  3. In classic navigate to settings
  4. Sign out
  5. You should be signed out and land at the NewDot sign in page

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@war-in war-in marked this pull request as ready for review August 5, 2025 16:24
@war-in war-in requested a review from a team as a code owner August 5, 2025 16:24
@melvin-bot melvin-bot bot requested review from s77rt and removed request for a team August 5, 2025 16:24
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Aug 5, 2025

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2025

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #67905.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/67905/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/67905/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/67905/NewExpensify.dmg https://67905.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@Julesssss Julesssss requested review from Julesssss and removed request for s77rt August 5, 2025 17:45
Julesssss
Julesssss approved these changes Aug 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves on the current state where users are completely unable to use the app. I'm okay with the user not seeing strings, as it is a bit of an edge case and will be resolved on the next sign-in.

@Julesssss
Copy link
Copy Markdown
Contributor

Julesssss commented Aug 5, 2025

Works as discussed. If users sign into classic then this doesn't occur, only if signing into ND, switching to classic and then signing out does this occur. I created a follow up issue to further resolve the issue.

Signoutofclassic-strings.mp4

@Julesssss

This comment was marked as resolved.

Sign in to view
@Julesssss Julesssss merged commit 4880208 into Expensify:main Aug 5, 2025
18 of 20 checks passed
@Julesssss
Copy link
Copy Markdown
Contributor

Julesssss commented Aug 5, 2025 •
edited
Loading

The perf tests are broken on all PRs, ignoring

@Julesssss Julesssss changed the title Fix app stuck on Signing out dialog after signing out of classic on HybridApp [CP staging] Fix app stuck on Signing out dialog after signing out of classic on HybridApp Aug 5, 2025
OSBotify pushed a commit that referenced this pull request Aug 5, 2025
@Julesssss @OSBotify
Merge pull request #67905 from software-mansion-labs/war-in/fix-app-b…
88b2644 
…locked-on-signing-out-dialog

Fix app stuck on `Signing out` dialog after signing out of classic on HybridApp

(cherry picked from commit 4880208)

(cherry-picked to staging by Julesssss)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 5, 2025
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Aug 5, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Closed
@Julesssss Julesssss mentioned this pull request Aug 5, 2025
Closed
16 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2025

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.89-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2025

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.89-15 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@mountiny mountiny mentioned this pull request Aug 6, 2025
Merged
49 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 6, 2025

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.1.90-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2025

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these changes

Assignees

No one assigned

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@war-in @Julesssss @OSBotify