Skip to content

fix amount field ui#6796

Merged
chiragsalian merged 1 commit intoExpensify:mainfrom
thesahindia:thesahindia/ui/fix-amount-field
Dec 16, 2021
Merged

fix amount field ui#6796
chiragsalian merged 1 commit intoExpensify:mainfrom
thesahindia:thesahindia/ui/fix-amount-field

Conversation

@thesahindia
Copy link
Member

Details

fixed the breaking of amount field

Fixed Issues

$ #6647

Tests

QA Steps

  1. Open the app in a Android tablet
  2. Navigate to a conversation
  3. Request money via the attachment button

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Screenshot 2021-12-16 at 4 16 45 PM

@thesahindia thesahindia requested a review from a team as a code owner December 16, 2021 11:15
@MelvinBot MelvinBot requested review from chiragsalian and parasharrajat and removed request for a team December 16, 2021 11:15
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc; @chiragsalian

Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@chiragsalian chiragsalian merged commit c81e301 into Expensify:main Dec 16, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.21-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants