Fix NewRoomPage visibility dropdown#6805
Merged
TomatoToaster merged 1 commit intomainfrom Dec 16, 2021
Merged
Conversation
jasperhuangg
requested review from
TomatoToaster
and removed request for
pecanoro
Contributor
|
I know the screenshots won't work here but can you post a mini video of the tests steps showing it's working now? |
pecanoro
approved these changes
Dec 16, 2021
TomatoToaster
approved these changes
Dec 16, 2021
Contributor
|
Lol good find 🤦🏾 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
31 tasks
Contributor
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.21-2 🚀
|
Contributor
|
@jasperhuangg Don't forget to add that mini video as proof of testing. |
Contributor
|
🚀 Deployed to production by @sketchydroide in version: 1.1.22-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea how this got past review but the
valueprop for the dropdown in theWorkspaceNewRoomPagewas being hard-coded toCONST.REPORT.VISIBILITY.RESTRICTEDpreventing the dropdown from updating with the selected value.Fixed Issues
$ #6757
Tests/QA
Screenshots
Web
Mobile Web
Desktop
iOS
Android