Composer - Keyboard overlaps the composer after selecting emoji #68099

nkdengineer · 2025-08-07T09:46:25Z

Explanation of Change

Fixed Issues

$ #67022
PROPOSAL: #67022 (comment)

Tests

Open iOS Native app
Tap on Reports tab
Tap on FAB
Create report
Send any msg to the report
Edit the message
Add an emoji from the emoji picker
The composer will be refocused with the keyboard not overlapping or cutting off the composer

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-08-07.at.16.26.46.mov

Android: mWeb Chrome

Screen.Recording.2025-08-07.at.16.33.21.mov

iOS: Native

Screen.Recording.2025-08-07.at.16.26.23.mov

iOS: mWeb Safari

Screen.Recording.2025-08-07.at.16.32.03.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-07.at.15.03.41.mov

MacOS: Desktop

Screen.Recording.2025-08-07.at.16.39.02.mov

melvin-bot · 2025-08-07T09:46:58Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-08-07T09:52:52Z

Hi @kirillzyusko, I'm doing the issue where the keyboard overlaps the composer and I see you had the PR to fix the quite same issue using renderScrollComponent, but it seems like it is used for inverted FlatList only so it doesn't work when I use it in normal FlatList. Do you know how to apply it for normal FlatList?

kirillzyusko · 2025-08-07T10:57:08Z

@nkdengineer I'm afraid you will have to write similar code to the one that is used in renderScrollComponent since original component most likely was relying on the fact that it will be used only in inverted lists 🤔

Let me know if you find a way how to make it simpler!

nkdengineer · 2025-08-07T11:15:52Z

@kirillzyusko Actually I tried, but the result was worse than without using it because I don't really understand this complex logic. Can you help me to understand the idea?

I think the the animation (showing keyboard) interrupt the scroll behavior, so I just use some delay then it works well. @getusha what do you think?

kirillzyusko · 2025-08-07T15:09:54Z

Actually I tried, but the result was worse than without using it because I don't really understand this complex logic. Can you help me to understand the idea?

The idea is to shift content via translateY (or by applying a padding) depending on the state machine. For example if keyboard is shown then we shift it by keyboard distance. When bottom sheet gets shown and keyboard was shown we shift it by the height diff between keyboard/bottom-sheet, etc.

The idea is simple, but implementation is complex, it's truth.

nkdengineer · 2025-08-08T03:16:45Z

@getusha renderScrollComponent is used for iOS native only, but this issue happens on Android as well. I believe the root cause is about animation because when we add some delays, it works well. We also did the same in useAutoFocus.

nkdengineer · 2025-08-12T02:20:29Z

@getusha can you please review this PR?

nkdengineer · 2025-08-15T02:50:22Z

@getusha bump

nkdengineer · 2025-08-20T02:26:11Z

@getusha kindly bump again

nkdengineer · 2025-08-26T02:17:28Z

@getusha bump

nkdengineer · 2025-09-03T02:02:50Z

@getusha Can you review this PR?

getusha · 2025-09-04T11:22:40Z

Fell through the cracks. reviewing right now. can you fix lint? thanks

getusha · 2025-09-04T11:24:12Z

src/pages/home/report/ReportActionItemMessageEdit.tsx

+    const scrollToIndex = useCallback(
+        (index: number, isEditing?: boolean, viewPosition?: number, shouldDelay = false) => {
+            if (shouldDelay) {
+                setTimeout(() => {


Comment about this? and lets use the const value if we can use CONST.ANIMATED_TRANSITION

getusha · 2025-09-04T11:25:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

N/a - there is ongoing issue on autofocus of the edit composer on android

Android: mWeb Chrome

android-rec-47.webm

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-04.at.15.09.34.mp4

iOS: mWeb Safari

N/a

MacOS: Chrome / Safari

N/a

MacOS: Desktop

N/a

getusha · 2025-09-04T14:37:21Z

It doesn't scroll to the input when focused on mWeb

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-04.at.17.09.53.mp4

nkdengineer · 2025-09-08T01:59:05Z

will take a look today

nkdengineer · 2025-09-09T05:54:37Z

@getusha After spending a lot of time to investigate this issue, I find out that: it has the different RCA from the original one.

In the OP, we just need to fix the edit composer, but the issue is about main composer.
We don't have the logic to scroll to bottom or index like what we did in edit composer

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 804 to 807 in a24b0c0

    
           onFocus={() => { 
        
               // The last composer that had focus should re-gain focus 
        
               setUpComposeFocusManager(true); 
        
               onFocus();

I don't know what the exact RCA is, so I think we should handle it in other issue. What about you?

getusha · 2025-09-10T09:39:01Z

In the OP, we just need to fix the edit composer, but #68099 (comment) is about main composer.

@nkdengineer btw i am trying to focus the edit composer in the video.

nkdengineer · 2025-09-12T03:29:47Z

Weird, it worked on my side before. Not sure what happens, will check today

nkdengineer · 2025-09-15T03:36:03Z

@getusha I believe it's different issue/RCA. We can reproduce it on staging with main composer (only happen on mweb safari, not ios native). I don't know why the list scroll to bottom then scroll to top. Do you have any idea?

Screen.Recording.2025-09-15.at.09.58.47.mov

nkdengineer · 2025-09-22T03:21:14Z

@getusha kindly bump

nkdengineer · 2025-09-29T10:17:25Z

@getusha what do you think about my comment above?

nkdengineer · 2025-10-03T02:37:44Z

@getusha Can you please take a look at this PR?

getusha · 2025-10-03T09:55:51Z

@getusha I believe it's different issue/RCA. We can reproduce it on staging with main composer (only happen on mweb safari, not ios native). I don't know why the list scroll to bottom then scroll to top. Do you have any idea?

I confirmed that this only happens on Safari not other browsers, which makes it trivial. Could you fix conflicts?

getusha · 2025-10-03T13:19:31Z

Also issue is marked reproducible on android and the edit composer doesn't get focused. I am wondering if it has similar root cause.

android-rec-49.webm

nkdengineer · 2025-10-06T04:53:56Z

@getusha We already had the issue to fix it #71760.

getusha · 2025-10-06T07:14:36Z

@nkdengineer could you fix the conflict?

codecov · 2025-10-06T16:33:33Z

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../pages/home/report/ReportActionItemMessageEdit.tsx	0.00%	12 Missing ⚠️
src/hooks/useReportScrollManager/index.ts	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx	`1.49% <ø> (ø)`
src/hooks/useReportScrollManager/index.native.ts	`60.00% <100.00%> (-10.00%)`	⬇️
src/pages/home/report/PureReportActionItem.tsx	`52.87% <ø> (ø)`
...pages/home/report/ReportActionItemParentAction.tsx	`4.00% <ø> (-15.24%)`	⬇️
...ages/home/report/ReportActionsListItemRenderer.tsx	`87.50% <ø> (-6.25%)`	⬇️
src/hooks/useReportScrollManager/index.ts	`0.00% <0.00%> (ø)`
.../pages/home/report/ReportActionItemMessageEdit.tsx	`1.74% <0.00%> (-0.09%)`	⬇️

... and 1043 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nkdengineer · 2025-10-07T02:29:48Z

@getusha Done

nkdengineer · 2025-10-13T03:30:02Z

@getusha can you please review this PR asap?

nkdengineer · 2025-10-16T03:37:05Z

DM-ed to @getusha

getusha · 2025-10-16T17:18:18Z

Sorry, thought i had approved it. Lets fix conflicts @nkdengineer

nkdengineer · 2025-10-21T04:26:24Z

@getusha Merged main

nkdengineer · 2025-10-27T02:31:03Z

@getusha kindly bump

getusha · 2025-10-29T16:21:32Z

Conflicts @nkdengineer

nkdengineer · 2025-10-29T17:15:20Z

@getusha Updated.

getusha · 2025-10-29T17:20:56Z

@nkdengineer lint is failing 🙏

nkdengineer · 2025-10-29T17:29:38Z

runAfterInteractions is deprecated, let me check another approach.

nkdengineer · 2025-11-03T15:48:57Z

@getusha My proposal doesn't work anymore. I can't find another approach, please open this for contributor.

Composer - Keyboard overlaps the composer after selecting emoji

92819fa

nkdengineer marked this pull request as ready for review August 7, 2025 09:46

nkdengineer requested a review from a team as a code owner August 7, 2025 09:46

melvin-bot bot requested review from getusha and removed request for a team August 7, 2025 09:46

getusha reviewed Sep 4, 2025

View reviewed changes

merge main

bfd8943

nkdengineer requested a review from a team as a code owner September 5, 2025 02:54

fix conflicts

7510405

Merge branch 'main' into fix/67022

0412124

resolve conflicts

729eff4

prettier

38db00f

merge main

8828980

resolve conflict

ae90cd9

nkdengineer closed this Nov 7, 2025

Composer - Keyboard overlaps the composer after selecting emoji #68099

Composer - Keyboard overlaps the composer after selecting emoji #68099

Uh oh!

Conversation

nkdengineer commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 7, 2025

Uh oh!

nkdengineer commented Aug 7, 2025

Uh oh!

kirillzyusko commented Aug 7, 2025

Uh oh!

nkdengineer commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirillzyusko commented Aug 7, 2025

Uh oh!

nkdengineer commented Aug 8, 2025

Uh oh!

nkdengineer commented Aug 12, 2025

Uh oh!

nkdengineer commented Aug 15, 2025

Uh oh!

nkdengineer commented Aug 20, 2025

Uh oh!

nkdengineer commented Aug 26, 2025

Uh oh!

nkdengineer commented Sep 3, 2025

Uh oh!

getusha commented Sep 4, 2025

Uh oh!

getusha Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

getusha commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Sep 4, 2025

Uh oh!

nkdengineer commented Sep 8, 2025

Uh oh!

nkdengineer commented Sep 9, 2025

Uh oh!

getusha commented Sep 10, 2025

Uh oh!

nkdengineer commented Sep 12, 2025

Uh oh!

nkdengineer commented Sep 15, 2025

Uh oh!

nkdengineer commented Sep 22, 2025

Uh oh!

nkdengineer commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Oct 3, 2025

Uh oh!

getusha commented Oct 3, 2025

Uh oh!

getusha commented Oct 3, 2025

Uh oh!

nkdengineer commented Oct 6, 2025

Uh oh!

getusha commented Oct 6, 2025

Uh oh!

codecov bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nkdengineer commented Oct 7, 2025

Uh oh!

nkdengineer commented Aug 7, 2025 •

edited

Loading

nkdengineer commented Aug 7, 2025 •

edited

Loading

getusha commented Sep 4, 2025 •

edited

Loading

nkdengineer commented Sep 29, 2025 •

edited

Loading

codecov bot commented Oct 6, 2025 •

edited

Loading