-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Remove redundant mobile selection mode call #68161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.1.91-0 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
This CP didn't complete btw: https://expensify.slack.com/archives/C07J32337/p1754608592281109 |
|
PR is failing with original issue #68087 on iOS |
|
The fix wasn't CP'd succesfully before - it's being handled now |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀
|
cc: @jasperhuangg @amyevans
Explanation of Change
#64616 changed the modal timing in
SearchSelectedNarrow.tsxresulting in there being a redundantturnOffMobileSelectionMode()call.Fixed Issues
$ #68087
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.-.2025-08-07.at.23.35.36.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.-.2025-08-07.at.23.47.53.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-08-07.at.23.48.43.mov
MacOS: Desktop