Rename ExpensiPicker #6837

mateusbra · 2021-12-19T23:15:21Z

Details

Rename component ExpensiPicker to Picker, rename folder Picker to NativePicker in order to solve import conflicts

Fixed Issues

$ #6760

Tests

Run the app and see that Picker still working

QA Steps

Run the app and see that Picker still working

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

src/components/NativePicker/pickerStyles/index.android.js

src/components/Picker.js

parasharrajat · 2021-12-23T16:48:46Z

src/components/Picker/BasePicker/index.js

+import * as pickerPropTypes from './pickerPropTypes';
+import pickerStyles from './pickerStyles';
+
+const Picker = props => (


parasharrajat · 2021-12-23T16:48:57Z

src/components/Picker/BasePicker/index.js

+Picker.propTypes = pickerPropTypes.propTypes;
+Picker.defaultProps = pickerPropTypes.defaultProps;
+Picker.displayName = 'Picker';


parasharrajat · 2021-12-23T16:49:04Z

src/components/Picker/BasePicker/index.js

+Picker.defaultProps = pickerPropTypes.defaultProps;
+Picker.displayName = 'Picker';
+
+export default Picker;


parasharrajat · 2021-12-23T16:53:46Z

src/components/Picker/BasePicker/index.js

+import * as pickerPropTypes from './pickerPropTypes';
+import pickerStyles from './pickerStyles';


Let's prefix these files with base if they are only used for basePicker.

mateusbra · 2021-12-23T19:57:09Z

@parasharrajat should we do the same to all the index.js inside the pickerstyles folder?
index.js,
index.ios.js,
index.android.js

parasharrajat · 2021-12-23T20:06:00Z

Doesn't matter much. I leave this up to you.

mateusbra · 2021-12-23T21:19:36Z

Ok, so I think thats it, just need your approval 😄

parasharrajat

LGTM

cc; @puneetlath

puneetlath

@mateusbra just like the other PR. Thanks for your patience through the holidays. Everything looks good to me, but you've picked up some merge conflicts. Once you fix those I can quickly re-approve and merge. Thanks!

mateusbra · 2022-01-04T02:10:26Z

@puneetlath I think we got a problem with ExpensifyText, it looks like we still have a file calling ExpensifyText instead of Text

mateusbra · 2022-01-04T02:12:31Z

you think its ok to deal about it in this PR? or may I open another PR dealing that? What you think we should do?

mateusbra · 2022-01-04T02:39:07Z

@puneetlath I think we got a problem with ExpensifyText, it looks like we still have a file calling ExpensifyText instead of Text

looks like some PR was merged using ExpensifyText instead of Text after we merged the renaeme ExpensifyText PR

parasharrajat · 2022-01-04T12:02:41Z

@mateusbra~~Could you fix that issue as you are in charge of these changes? I don't think we mind one extra change in this PR if it is all about renaming.~~

The fix is merged. You can pull main.

mateusbra · 2022-01-04T14:17:15Z

thanks @parasharrajat 😄

parasharrajat · 2022-01-04T14:20:24Z

android/app/build.gradle

-        versionCode 1001012419
-        versionName "1.1.24-19"
+        versionCode 1001012422
+        versionName "1.1.24-22"


How are these changes related to this PR?

I am not sure. But when we merge main, do the new changes show in PR changes?

I think they shoudn't show, I'm not understanding why its showing, we are currently using version 1.1.24-22 it shouldn't show as a change

I'll try to revert the last commit changes

This reverts commit dca45a8.

parasharrajat

Seems like the test will pass. SO LGTM. Nice work.

cc: @puneetlath
🎀 👀 🎀 C+ reviewed

puneetlath

@mateusbra when I try to compile it it's failing because it seems there is still a reference to ExpensifyText in src/pages/home/report/ReportActionItemMessage.js even though there is no longer an ExpensifyText component.

puneetlath · 2022-01-04T18:28:43Z

Actually, looks like that is addressed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1641299616468900

OSBotify · 2022-01-04T18:29:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-06T00:55:21Z

🚀 Deployed to staging by @puneetlath in version: 1.1.25-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-01-10T19:03:17Z

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mateusbra added 2 commits December 19, 2021 16:23

Rename ExpensiPicker

6f998d2

Rename native Picker

c38ac5e

mateusbra requested a review from a team as a code owner December 19, 2021 23:15

MelvinBot requested review from parasharrajat and puneetlath and removed request for a team December 19, 2021 23:15

parasharrajat suggested changes Dec 20, 2021

View reviewed changes

src/components/NativePicker/pickerStyles/index.android.js Outdated Show resolved Hide resolved

src/components/Picker.js Outdated Show resolved Hide resolved

styles changed to cameCase,NativePicker-> BasePicker

6b3f4a5

mateusbra requested a review from parasharrajat December 23, 2021 00:20

parasharrajat suggested changes Dec 23, 2021

View reviewed changes

picker -> basepicker

01cc891

Merge branch 'main' into rename-ExpensiPicker

430dec1

mateusbra requested a review from parasharrajat December 27, 2021 23:24

parasharrajat previously approved these changes Dec 28, 2021

View reviewed changes

puneetlath previously approved these changes Jan 4, 2022

View reviewed changes

Merge branch 'main' into rename-ExpensiPicker

9414679

mateusbra dismissed stale reviews from puneetlath and parasharrajat via 9414679 January 4, 2022 01:52

Merge branch 'main' into rename-ExpensiPicker

dca45a8

parasharrajat suggested changes Jan 4, 2022

View reviewed changes

Revert "Merge branch 'main' into rename-ExpensiPicker"

7e932d7

This reverts commit dca45a8.

parasharrajat approved these changes Jan 4, 2022

View reviewed changes

puneetlath requested changes Jan 4, 2022

View reviewed changes

puneetlath self-requested a review January 4, 2022 18:28

puneetlath approved these changes Jan 4, 2022

View reviewed changes

puneetlath merged commit 667570c into Expensify:main Jan 4, 2022

OSBotify mentioned this pull request Jan 5, 2022

Deploy Checklist: New Expensify 2022-01-05 #7051

Closed

21 tasks

botify mentioned this pull request Jan 10, 2022

[HOLD for payment 2022-01-17] [HOLD for payment 2022-01-11] [HOLD for payment 2022-01-04] [HOLD for payment 2021-12-28] Rename ExpensifyText, ExpensifyButton, ExpensiTextInput, ExpensiPicker components #6760

Closed

		import * as pickerPropTypes from './pickerPropTypes';
		import pickerStyles from './pickerStyles';

Rename ExpensiPicker #6837

Rename ExpensiPicker #6837

Uh oh!

Conversation

mateusbra commented Dec 19, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateusbra commented Dec 23, 2021

Uh oh!

parasharrajat commented Dec 23, 2021

Uh oh!

mateusbra commented Dec 23, 2021

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

mateusbra commented Jan 4, 2022

Uh oh!

mateusbra commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateusbra commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateusbra commented Jan 4, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Jan 4, 2022

Uh oh!

OSBotify commented Jan 4, 2022

Uh oh!

OSBotify commented Jan 6, 2022

Uh oh!

OSBotify commented Jan 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mateusbra commented Jan 4, 2022 •

edited

Loading

mateusbra commented Jan 4, 2022 •

edited

Loading

parasharrajat commented Jan 4, 2022 •

edited

Loading