Remove call to "getReportNameValuePairs()" in method "getPolicyExpenseChatName" from "ReportUtils.ts". #68465

Krishna2323 · 2025-08-13T16:58:11Z

Explanation of Change

Fixed Issues

$ #67093
PROPOSAL: #67093

Tests

Create a workspace
Go to workspace expenses report > Note the report name
Send a message
Go to workspace overview page > Delete the workspace
Search for the workspace expenses report from step 2
Verify report name also includes (archived)

Verify that no errors appear in the JS console

Offline tests

Create a workspace
Go to workspace expenses report > Note the report name
Send a message
Go to workspace overview page > Delete the workspace
Search for the workspace expenses report from step 2
Verify report name also includes (archived)

QA Steps

Create a workspace
Go to workspace expenses report > Note the report name
Send a message
Go to workspace overview page > Delete the workspace
Search for the workspace expenses report from step 2
Verify report name also includes (archived)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…eChatName" from "ReportUtils.ts". Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-08-13T17:09:15Z

src/libs/ReportUtils.ts

    // This will get removed as part of https://github.com/Expensify/App/issues/59961
    // eslint-disable-next-line deprecation/deprecation
-    if (isArchivedNonExpenseReport(report, !!getReportNameValuePairs(report?.reportID)?.private_isArchived)) {
+    if (isArchivedNonExpenseReport(report, isReportArchived)) {


@DylanDylann, can you help me with the testing steps if you're familiar with the scenario mentioned above? I’ve been trying to make the condition (archiveReason === CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED && policyExpenseChatRole !== CONST.POLICY.ROLE.ADMIN) evaluate to true, but haven’t succeeded yet.

Here’s what I’ve tried:

Created two different accounts (Account A and Account B).

Added Account A as a member in a workspace created by Account B.

Merged Account B into Account A.

Despite this, the condition isn’t being met. I’ve already spent a good amount of time on this, so it would be great if you could help. Thanks!

I think we don't need to pass isReportArchived here because it's for existing messages.

Could you please detail the reason here? It could be a moved report action in an archived workspace chat

@DylanDylann I need to test this scenario to confirm and provide a proper explanation. What I meant was that we shouldn't modify already existing messages if the workspace was archived afterward.

@Krishna2323 Please check this PR: #14779

@DylanDylann Even after carefully following the test steps from this PR, I couldn’t reach the condition below (line 3806). The reason is that reportOwnerDisplayName already evaluates to true, and even when I tried commenting out the condition, the archiveReason (line 3808) returns default instead of CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED.

App/src/libs/ReportUtils.ts

Lines 3802 to 3812 in 1ef115b

// If this user is not admin and this policy expense chat has been archived because of account merging, this must be an old expense chat

// of the account which was merged into the current user's account. Use the name of the policy as the name of the report.

// This will get removed as part of https://github.com/Expensify/App/issues/59961

// eslint-disable-next-line deprecation/deprecation

if (isArchivedNonExpenseReport(report, !!getReportNameValuePairs(report?.reportID)?.private_isArchived)) {

const lastAction = getLastVisibleActionReportActionsUtils(report?.reportID);

const archiveReason = isClosedAction(lastAction) ? getOriginalMessage(lastAction)?.reason : CONST.REPORT.ARCHIVE_REASON.DEFAULT;

if (archiveReason === CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED && policyExpenseChatRole !== CONST.POLICY.ROLE.ADMIN) {

return getPolicyName({report, policy, policies, reports});

}

}

App/src/libs/ReportUtils.ts

Lines 3788 to 3793 in 1ef115b

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

const reportOwnerDisplayName = getDisplayNameForParticipant({accountID: ownerAccountID, shouldRemoveDomain: true}) || login;

if (reportOwnerDisplayName) {

return translateLocal('workspace.common.policyExpenseChatName', {displayName: reportOwnerDisplayName});

}

App/src/libs/ReportUtils.ts

Line 3808 in 1ef115b

const archiveReason = isClosedAction(lastAction) ? getOriginalMessage(lastAction)?.reason : CONST.REPORT.ARCHIVE_REASON.DEFAULT;

NOTE: Chat Report (archived) in the video is shown because I commented out the first condition where reportOwnerDisplayName evaluates to true.

Monosnap.screencast.2025-08-20.00-06-10.mp4

Krishna2323 · 2025-08-13T17:26:42Z

@DylanDylann getPolicyExpenseChatName is also used in ModifiedExpenseMessage, and I think we don't need to pass isReportArchived here because it's for existing messages.

App/src/libs/ModifiedExpenseMessage.ts

Lines 133 to 153 in 9874e84

    
           function getForExpenseMovedFromSelfDM(destinationReportID: string) { 
        
               const destinationReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${destinationReportID}`]; 
        
               const rootParentReport = getRootParentReport({report: destinationReport}); 
        
               // In OldDot, expenses could be moved to a self-DM. Return the corresponding message for this case. 
        
               if (isSelfDM(rootParentReport)) { 
        
                   return translateLocal('iou.movedToPersonalSpace'); 
        
               } 
        
               // In NewDot, the "Move report" flow only supports moving expenses from self-DM to: 
        
               // - A policy expense chat 
        
               // - A 1:1 DM 
        
               const reportName = isPolicyExpenseChat(rootParentReport) ? getPolicyExpenseChatName({report: rootParentReport}) : buildReportNameFromParticipantNames({report: rootParentReport}); 
        
               const policyName = getPolicyName({report: rootParentReport, returnEmptyIfNotFound: true}); 
        
               // If we can't determine either the report name or policy name, return the default message 
        
               if (isEmpty(policyName) && !reportName) { 
        
                   return translateLocal('iou.changedTheExpense'); 
        
               } 
        
               return translateLocal('iou.movedFromPersonalSpace', { 
        
                   reportName, 
        
                   workspaceName: !isEmpty(policyName) ? policyName : undefined, 
        
               }); 
        
           }

DylanDylann · 2025-08-18T04:15:55Z

I think we don't need to pass isReportArchived here because it's for existing messages.

@Krishna2323 Could you please detail the reason here? It could be a moved report action in an archived workspace chat

DylanDylann · 2025-08-19T04:35:14Z

src/libs/ReportUtils.ts

    // This will get removed as part of https://github.com/Expensify/App/issues/59961
    // eslint-disable-next-line deprecation/deprecation


Suggested change

// This will get removed as part of https://github.com/Expensify/App/issues/59961

// eslint-disable-next-line deprecation/deprecation

DylanDylann · 2025-08-20T09:11:35Z

From this comment, after check it more detail, this is my summary

In this PR, we need to remove call to "getReportNameValuePairs()" in the method "getPolicyExpenseChatName".

App/src/libs/ReportUtils.ts

Lines 3805 to 3816 in 4d7d44a

    
           // If this user is not admin and this policy expense chat has been archived because of account merging, this must be an old expense chat 
        
           // of the account which was merged into the current user's account. Use the name of the policy as the name of the report. 
        
           // This will get removed as part of https://github.com/Expensify/App/issues/59961 
        
           // eslint-disable-next-line deprecation/deprecation 
        
           if (isArchivedNonExpenseReport(report, !!getReportNameValuePairs(report?.reportID)?.private_isArchived)) { 
        
               const lastAction = getLastVisibleActionReportActionsUtils(report?.reportID); 
        
               const archiveReason = isClosedAction(lastAction) ? getOriginalMessage(lastAction)?.reason : CONST.REPORT.ARCHIVE_REASON.DEFAULT; 
        
               if (archiveReason === CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED && policyExpenseChatRole !== CONST.POLICY.ROLE.ADMIN) { 
        
                   return getPolicyName({report, policy, policies, reports}); 
        
               } 
        
           } 
        
           return report?.reportName;

This logic was introduced by this PR (long time ago, so I am not sure the behavior at that time) and in this PR we expect that:

// If this user is not admin and this policy expense chat has been archived because of account merging, this must be an old expense chat
// of the account which was merged into the current user's account. Use the name of the policy as the name of the report.

Recently, we had an update on how to display the workspace name to <displayName>'s expenses (ref: #56123). With this update, I believe the isArchivedNonExpenseReport check is no longer necessary, so we can safely remove it in this PR

cc @tgolen @Krishna2323

tgolen · 2025-08-20T14:54:43Z

Hm, it still sounds to me like we would display the policy name for that archived report. I don't understand why changing the workspace name to <displayName>'s expenses would mean the archived report check can be removed. Can you explain that a little better?

DylanDylann · 2025-08-20T17:18:19Z

@tgolen Let's see this PR

In this update, we changed the condition from report?.isOwnPolicyExpenseChat to reportOwnerDisplayName. With this change, even if a report is archived, we can still retrieve reportOwnerDisplayName, ensuring the report name is displayed the same way as before it was archived. Therefore, I don’t see any reason to update it to use the policy name.

Additionally, there’s no reason to use the policy name for non-expense reports.

App/src/libs/ReportUtils.ts

Lines 3805 to 3816 in 4d7d44a

    
           // If this user is not admin and this policy expense chat has been archived because of account merging, this must be an old expense chat 
        
           // of the account which was merged into the current user's account. Use the name of the policy as the name of the report. 
        
           // This will get removed as part of https://github.com/Expensify/App/issues/59961 
        
           // eslint-disable-next-line deprecation/deprecation 
        
           if (isArchivedNonExpenseReport(report, !!getReportNameValuePairs(report?.reportID)?.private_isArchived)) { 
        
               const lastAction = getLastVisibleActionReportActionsUtils(report?.reportID); 
        
               const archiveReason = isClosedAction(lastAction) ? getOriginalMessage(lastAction)?.reason : CONST.REPORT.ARCHIVE_REASON.DEFAULT; 
        
               if (archiveReason === CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED && policyExpenseChatRole !== CONST.POLICY.ROLE.ADMIN) { 
        
                   return getPolicyName({report, policy, policies, reports}); 
        
               } 
        
           } 
        
           return report?.reportName;

tgolen · 2025-08-20T20:25:13Z

Aha! Thank you. Makes total sense now. Let's remove it completely then.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-08-20T22:33:59Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-08-21T09:14:24Z

src/libs/ReportUtils.ts

-        report,
-        !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived,
-    );
+    const isReportArchived = !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived;


Please use isArchivedReport function

We already have a function named isArchivedReport.

@Krishna2323 Use this function please

DylanDylann · 2025-08-21T09:15:00Z

src/libs/ReportUtils.ts

-    policies?: SearchPolicy[];
-    reports?: SearchReport[];
-}): string | undefined {
+function getPolicyExpenseChatName({report}: {report: OnyxEntry<Report>}): string | undefined {


Please add some unit tests for this function

DylanDylann · 2025-08-21T09:17:02Z

src/libs/ReportUtils.ts

    }

    if (isPolicyExpenseChat(report)) {
-        formattedName = getPolicyExpenseChatName({report, policy, personalDetailsList: personalDetails, reports});


Why do you remove personalDetailsList param here?

sorry, it was a mistake. Thanks for catching that 🙇🏻

DylanDylann · 2025-08-22T03:20:54Z

@Krishna2323 Kindly bump

Krishna2323 · 2025-08-22T03:50:34Z

@DylanDylann my dog Daisy passed away last night 💔. I’m not in a state to work today, thank you for understanding.

DylanDylann · 2025-08-22T04:04:44Z

@Krishna2323 My heartfelt sympathy. I hope you can get through

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann · 2025-08-25T05:07:09Z

src/libs/ReportUtils.ts

-        report,
-        !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived,
-    );
+    const isReportArchived = !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived;


@Krishna2323 Use this function please

DylanDylann · 2025-08-25T05:07:52Z

src/libs/ReportUtils.ts

-        report,
-        !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived,
-    );
+    const isReportArchived = !!reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`]?.private_isArchived;


const isReportArchived = isArchivedReport(reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)}`])

DylanDylann · 2025-08-25T05:08:57Z

And Please add unit test for getPolicyExpenseChatName function

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann · 2025-08-26T06:48:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-08-26.at.14.39.51.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-08-26T16:06:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-28T01:38:48Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.2.0-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T22:17:42Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T23:10:55Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove call to "getReportNameValuePairs()" in method "getPolicyExpens…

cf56b72

…eChatName" from "ReportUtils.ts". Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 commented Aug 13, 2025

View reviewed changes

DylanDylann reviewed Aug 19, 2025

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/67093

8d87f64

Krishna2323 added 2 commits August 21, 2025 03:39

update getPolicyExpenseChatName.

31077a9

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/67093

90b9443

Krishna2323 marked this pull request as ready for review August 20, 2025 22:33

Krishna2323 requested a review from a team as a code owner August 20, 2025 22:33

melvin-bot bot requested a review from DylanDylann August 20, 2025 22:33

melvin-bot bot removed the request for review from a team August 20, 2025 22:33

DylanDylann reviewed Aug 21, 2025

View reviewed changes

minor updates.

1ce1d29

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann reviewed Aug 25, 2025

View reviewed changes

Krishna2323 added 4 commits August 26, 2025 03:56

use isArchivedReport.

36c4c67

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

add unit tests for getPolicyExpenseChatName.

b4afaea

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/67093

9038892

fix ESLint.

1c81348

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

DylanDylann approved these changes Aug 26, 2025

View reviewed changes

melvin-bot bot requested a review from tgolen August 26, 2025 07:40

tgolen approved these changes Aug 26, 2025

View reviewed changes

tgolen merged commit 8788468 into Expensify:main Aug 26, 2025
21 checks passed

OSBotify mentioned this pull request Aug 28, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

melvin-bot bot mentioned this pull request Sep 2, 2025

[Due for payment 2025-09-09] Remove call to getReportNameValuePairs() in method getPolicyExpenseChatName from ReportUtils.ts #67093

Closed

	// If this user is not admin and this policy expense chat has been archived because of account merging, this must be an old expense chat
	// of the account which was merged into the current user's account. Use the name of the policy as the name of the report.
	// This will get removed as part of https://github.com/Expensify/App/issues/59961
	// eslint-disable-next-line deprecation/deprecation
	if (isArchivedNonExpenseReport(report, !!getReportNameValuePairs(report?.reportID)?.private_isArchived)) {
	const lastAction = getLastVisibleActionReportActionsUtils(report?.reportID);
	const archiveReason = isClosedAction(lastAction) ? getOriginalMessage(lastAction)?.reason : CONST.REPORT.ARCHIVE_REASON.DEFAULT;
	if (archiveReason === CONST.REPORT.ARCHIVE_REASON.ACCOUNT_MERGED && policyExpenseChatRole !== CONST.POLICY.ROLE.ADMIN) {
	return getPolicyName({report, policy, policies, reports});
	}
	}

	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const reportOwnerDisplayName = getDisplayNameForParticipant({accountID: ownerAccountID, shouldRemoveDomain: true}) \|\| login;

	if (reportOwnerDisplayName) {
	return translateLocal('workspace.common.policyExpenseChatName', {displayName: reportOwnerDisplayName});
	}

Remove call to "getReportNameValuePairs()" in method "getPolicyExpenseChatName" from "ReportUtils.ts". #68465

Remove call to "getReportNameValuePairs()" in method "getPolicyExpenseChatName" from "ReportUtils.ts". #68465

Uh oh!

Conversation

Krishna2323 commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Aug 13, 2025

Uh oh!

DylanDylann commented Aug 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Aug 20, 2025

Uh oh!

tgolen commented Aug 20, 2025

Uh oh!

DylanDylann commented Aug 20, 2025

Uh oh!

tgolen commented Aug 20, 2025

Uh oh!

melvin-bot bot commented Aug 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Aug 22, 2025

Uh oh!

Krishna2323 commented Aug 22, 2025

Uh oh!

DylanDylann commented Aug 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Aug 25, 2025

Uh oh!

DylanDylann commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Krishna2323 commented Aug 13, 2025 •

edited

Loading

DylanDylann commented Aug 26, 2025 •

edited

Loading