feat: use standardized payment button on search page by getusha · Pull Request #68526 · Expensify/App

getusha · 2025-08-14T11:52:19Z

Explanation of Change

Fixed Issues

$ #68283
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Go to Search page → Pay.
Go offline
Press the pay button
Mark as paid
Verify that only the loading indicator is shown on the button without the chevron

QA Steps

Preconditions

You have IOUs in USD from another account.

Go to Search page → Pay.
Click the Pay button on the report.
Confirm that the following payment options are displayed:

Pay with personal account / Pay with wallet
Pay with business account / Pay via workspaces
Mark as paid

Complete payment for the IOU.
Verify that the button changes to Split and defaults to the most recently used payment method.
Create a workspace
Navigate to search > pay
Press pay and Pay via %workspace%
Verify that the IOU is moved to the workspace

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-14.at.16.09.42.mp4

iOS: mWeb Safari

Simulator Screenshot - iPhone 16 Pro - 2025-08-14 at 17 07 55

MacOS: Chrome / Safari

Screen.Recording.2025-08-14.at.2.37.28.in.the.afternoon.mov

MacOS: Desktop

Screenshot 2025-08-14 at 5 05 34 in the afternoon

melvin-bot · 2025-08-14T15:01:36Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-08-14T15:09:38Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

joekaufmanexpensify · 2025-08-14T18:04:01Z

I tested and found some bugs!

hungvu193 · 2025-08-17T15:05:43Z

Still discussing pay with workspace bug here:
https://expensify.slack.com/archives/C082KSNREGK/p1754926798278419

github-actions · 2025-08-20T12:21:21Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-20T12:54:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68526.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/68526/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68526/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/68526/NewExpensify.dmg	https://68526.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-08-21T13:09:43Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-21T13:43:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68526.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/68526/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68526/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/68526/NewExpensify.dmg	https://68526.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-08-21T17:31:48Z

The loading state for the dropdown button (NOT the split button) seems broken:

Here is a full vid:
https://github.com/user-attachments/assets/7796a796-2c20-400b-9cb1-e1307f30e2ab

JmillsExpensify · 2025-08-22T10:14:49Z

Quickly testing this one. Is there any reason why I'm not seeing the pay option for these cases?

getusha · 2025-08-22T11:00:12Z

Quickly testing this one. Is there any reason why I'm not seeing the pay option for these cases?

Bulk payments is planned to be handled separately. Is this different behavior from staging?

JmillsExpensify · 2025-08-22T11:25:11Z

Ah ok, I see. @joekaufmanexpensify let me know when we have bulk payment and I'll happily test it on my test account.

joekaufmanexpensify · 2025-08-22T13:42:01Z

Will do! Yep, this is just adding the new pay button pattern on the reports page for single payments, and then we'll handle bulk pay in a follow up PR.

joekaufmanexpensify · 2025-08-22T16:36:40Z

The loading state for the dropdown button (NOT the split button) seems broken:

Interesting. I'm not seeing the loading state on the button when I mark an IOU as paid. Maybe it's only with an active wallet? I will test some more.

2025-08-22_12-36-00.mp4

shawnborton · 2025-08-22T16:45:29Z

@joekaufmanexpensify it has to be the dropdown button I think, not the split button:

joekaufmanexpensify · 2025-08-22T17:43:20Z

Tested the PR again today and everything else looks good from my perspective 🫡

hungvu193 · 2025-08-25T04:51:04Z

Small UI bug: While paying for the first time, the loading indicator is too close to the right arrow

bug1.mov

src/components/ButtonWithDropdownMenu/index.tsx

grgia · 2025-08-28T09:07:18Z

src/components/Search/index.tsx

+    selectedTransactions: SelectedTransactions,
+    canSelectMultiple: boolean,
+    shouldAnimateInHighlight: boolean,
+    hash?: number,


I see comments about the hash being used for Search payments, can you explain a little more what the function of this argument is and how we use hash in this function?

We decided to use payMoneyRequestOnSearch, and hash is a required parameter. I’m not exactly sure what it does, since I didn’t dive into it.

grgia · 2025-08-28T09:07:45Z

src/components/SettlementButton/index.tsx


    function getLatestBankAccountItem() {
-        if (!hasVBBA(policy?.id)) {
+        if (!policy?.achAccount?.bankAccountID) {


why are we not using hasVBBA anymore?

It is impure function which uses the deprecated getPolicy function

grgia

Code is looking good, I have a few questions for clarity. Also would you merge main 🙏

…tton-reports-page

dannymcclain · 2025-08-29T12:49:21Z

That makes sense, here is what it looks like right now.

That looks much better!

This is mostly a question for the @Expensify/design team, but I'm wondering if we should bump the size of that loader in the button down to be a bit smaller? Feels a little big in there. #not-a-blocker

grgia · 2025-08-29T13:59:36Z

@dannymcclain I think you're the only design team online today, do you want to change it in this PR?

hungvu193 · 2025-08-29T14:49:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-30.at.11.18.08.mov

Android: mWeb Chrome

Screen.Recording.2025-08-30.at.11.02.48.mov

iOS: HybridApp

Screen.Recording.2025-08-30.at.10.50.35.mov

iOS: mWeb Safari

Screen.Recording.2025-08-29.at.22.02.14.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-29.at.21.45.30.mov

MacOS: Desktop

Screen.Recording.2025-08-29.at.21.46.49.mov

hungvu193

LGTM. I'm having uploading issues but will update the rest of screenshots ASAP.

dannymcclain · 2025-08-29T15:49:39Z

I think you're the only design team online today, do you want to change it in this PR?

@grgia let's leave it be for now. It's working fine as-is, so when the rest of the design team is on we can talk about it, and if we need to we can always just make a little follow-up issue.

grgia

WOOO

grgia · 2025-08-29T16:00:50Z

@hungvu193 please ping when screenshots are up and I will merge

joekaufmanexpensify · 2025-08-29T16:30:19Z

I will approve for product as I have extensively tested this one 👍

hungvu193 · 2025-08-30T04:18:58Z

All yours @grgia 😄

@hungvu193 please ping when screenshots are up and I will merge

joekaufmanexpensify · 2025-09-01T19:15:16Z

Wooo, exciting! Thank you all for the effort here.

OSBotify · 2025-09-02T22:45:37Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-05T19:32:36Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2025-11-10T10:17:39Z

src/components/SelectionList/Search/ActionCell.tsx


+    if (action === CONST.SEARCH.ACTION_TYPES.PAY && !isInvoiceReport(iouReport)) {
+        return (
+            <SettlementButton


As this component is wrapped with SearchScopeProvider (as inside <Search />), this caused #73722 which came from inconsistency between Onyx data and snapshot data.

feat: use standardized payment button on search page

4cf28da

getusha marked this pull request as ready for review August 14, 2025 15:01

getusha requested a review from a team as a code owner August 14, 2025 15:01

melvin-bot bot requested review from hungvu193 and removed request for a team August 14, 2025 15:01

This comment has been minimized.

Sign in to view

getusha added 2 commits August 20, 2025 14:53

feat: fix bugs

0ed3cf4

fix: prettier and spell

9ec9198

getusha added 2 commits August 21, 2025 13:09

fix: wrong ba connection path

49acaeb

fix: popover padding

7c3e2af

getusha requested a review from a team as a code owner August 21, 2025 10:28

grgia requested review from grgia and removed request for a team August 21, 2025 10:53

grgia reviewed Aug 28, 2025

View reviewed changes

src/components/ButtonWithDropdownMenu/index.tsx Show resolved Hide resolved

grgia reviewed Aug 28, 2025

View reviewed changes

Merge remote-tracking branch 'exfy/main' into feat-standardize-pay-bu…

446efc1

…tton-reports-page

getusha requested a review from a team as a code owner August 29, 2025 12:39

grgia approved these changes Aug 29, 2025

View reviewed changes

hungvu193 approved these changes Aug 29, 2025

View reviewed changes

melvin-bot bot requested a review from grgia August 29, 2025 15:27

grgia approved these changes Aug 29, 2025

View reviewed changes

joekaufmanexpensify approved these changes Aug 29, 2025

View reviewed changes

grgia merged commit 4982940 into Expensify:main Sep 1, 2025
22 of 23 checks passed

OSBotify mentioned this pull request Sep 2, 2025

Deploy Checklist: New Expensify 2025-09-02 #69693

Closed

jponikarchuk mentioned this pull request Sep 3, 2025

[$250] [Due for payment 2025-10-15] Workspace - Able to create new Workspace with invalid currency #69737

Closed

8 tasks

VickyStash mentioned this pull request Sep 5, 2025

Reports - App crashes when sorting expenses while expenses are selected #69698

Closed

8 tasks

melvin-bot bot mentioned this pull request Sep 5, 2025

[Due for payment 2025-09-12] [Standardize the pay button] Add new pay pattern for expenses/IOUs on reports page #68283

Closed

situchan reviewed Nov 10, 2025

View reviewed changes

Conversation

getusha commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

This comment has been minimized.

joekaufmanexpensify commented Aug 14, 2025

Uh oh!

hungvu193 commented Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

shawnborton commented Aug 21, 2025

Uh oh!

JmillsExpensify commented Aug 22, 2025

Uh oh!

getusha commented Aug 22, 2025

Uh oh!

JmillsExpensify commented Aug 22, 2025

Uh oh!

joekaufmanexpensify commented Aug 22, 2025

Uh oh!

joekaufmanexpensify commented Aug 22, 2025

Uh oh!

shawnborton commented Aug 22, 2025

Uh oh!

joekaufmanexpensify commented Aug 22, 2025

Uh oh!

hungvu193 commented Aug 25, 2025

Uh oh!

Uh oh!

grgia Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

getusha Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

grgia Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

getusha Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Aug 29, 2025

Uh oh!

grgia commented Aug 29, 2025

Uh oh!

hungvu193 commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

dannymcclain commented Aug 29, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

getusha commented Aug 14, 2025 •

edited

Loading

hungvu193 commented Aug 17, 2025 •

edited

Loading

hungvu193 commented Aug 29, 2025 •

edited

Loading

situchan Nov 10, 2025 •

edited

Loading