Auto show/hide columns depending on available data #68561

youssef-lr · 2025-08-14T20:42:42Z

Explanation of Change

Fixed Issues

$ #45450 (comment)

Tests

Verify that no errors appear in the JS console

Test that if all transactions are from the current user, we only show the "To" column
Test that if all transactions are submitted to the current user, we only show the "From" column
Test that we only show merchant, description, category, or tag columns only if at least one transaction has them set.
Test that when we fetch new transactions with different columns a clean fadeOut/fadeIn happen.
Verify these steps in the Reports groupBy as well.
Verify that tasks show up properly
Verify that when going to the expense reports view, then inbox, then clicking on browser's Back button the expenses/reports show up properly and not an empty page
Verify that markdown works for descriptions in both the reports page and the expense report view (a report having more than one expense)
Verify total column is on the right end of table in IOU report when merchant is missing
Verify that total and action column are not in the middle of expense row briefly after submitting an invoice (enable invoice feature in the workspace first then create it from the Reports page's empty view)
Verify that expenses are sorted after clicking on Description table header

Offline tests

QA Steps

Test that if all transactions are from the current user, we only show the "To" column
Test that if all transactions are submitted to the current user, we only show the "From" column
Test that we only show merchant, description, category, or tag columns only if at least one transaction has them set.
Test that when we fetch new transactions with different columns a clean fadeOut/fadeIn happen.
Verify these steps in the Reports groupBy as well.
Verify that tasks show up properly
Verify that when going to the expense reports view, then inbox, then clicking on browser's Back button the expenses/reports show up properly and not an empty page
Verify that markdown works for descriptions in both the reports page and the expense report view (a report having more than one expense)
Verify total column is on the right end of table in IOU report when merchant is missing
Verify that total and action column are not in the middle of expense row briefly after submitting an invoice (enable invoice feature in the workspace first then create it from the Reports page's empty view)
Verify that expenses are sorted after clicking on Description table header

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-08-15T22:56:15Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2025-08-18T17:02:40Z

@youssef-lr what are next steps here? Is this ready for a review? Let's get the original C+ assigned to this one too, right?

youssef-lr · 2025-08-18T17:05:47Z

Yeah this is ready for review. There's one last bug remaining that is fixed by removing the animation when navigating using side bar. I will remove it for now from this PR. cc @ishpaul777

shawnborton · 2025-08-18T17:06:16Z

Looks like we are missing the ellipsis truncation on the merchant and description columns now:

youssef-lr · 2025-08-18T17:07:39Z

Will fix! I'm AFK right now and will be on in an hour.

github-actions · 2025-08-26T20:23:03Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-26T20:54:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68561.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/68561/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68561/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://68561.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

src/components/Search/index.tsx

ishpaul777 · 2025-08-27T14:16:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-08-27.at.10.25.36.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-27.at.3.10.03.AM.mov

MacOS: Desktop

github-actions · 2025-08-27T17:34:29Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-27T18:07:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68561.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/68561/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68561/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://68561.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

ishpaul777

lgtm!

melvin-bot · 2025-08-27T19:01:55Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM and tests well

OSBotify · 2025-08-27T21:52:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-28T01:38:51Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.0-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…lumns_2" This reverts commit 332d296, reversing changes made to 5f6e6ee.

vincdargento · 2025-08-29T18:02:48Z

@youssef-lr This PR is failing because of issue #69566
The issue is reproducible in: iOS

bug.mp4

OSBotify · 2025-09-02T22:17:45Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T23:10:58Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ishpaul777 · 2025-09-11T20:31:56Z

src/components/TransactionItemRow/DataCells/MerchantCell.tsx

+    const html = useMemo(() => {
+        if (!shouldRenderAsHTML) {
+            return merchantOrDescription;
+        }
+        return Parser.replace(merchantOrDescription, {shouldEscapeText: false});
+    }, [merchantOrDescription, shouldRenderAsHTML]);


{bz checklist} there was this regression #69402, Long expense description is not truncated

youssef-lr added 2 commits August 14, 2025 21:42

Auto show/hide columns depending on available data

776b093

Lint

0149379

youssef-lr mentioned this pull request Aug 15, 2025

[Due for payment 2025-09-09] [$350] Conditionally show/hide columns on the Search page depending on available data #45450

Closed

youssef-lr self-assigned this Aug 15, 2025

youssef-lr added 6 commits August 15, 2025 13:32

Fix task headers misaligned

59ab8a6

Fix header width when optional columns are hidden

449c06f

Lint

7fb4e4f

Merge branch 'main' into youssef_auto_hide_columns_2

0bb14af

Fix task headers again

ac00480

Allow markdown in description

bac3e6b

youssef-lr added the Ready To Build label Aug 15, 2025

This comment has been minimized.

Sign in to view

youssef-lr added 5 commits August 16, 2025 21:33

Allow sorting by description

cae9481

Lint

a59f64d

Fix tests and remove deprecated code

c833d37

Lint

648b800

Fix another test and TS

0e11085

youssef-lr requested a review from ishpaul777 August 18, 2025 17:06

youssef-lr marked this pull request as ready for review August 18, 2025 17:06

youssef-lr requested review from a team as code owners August 18, 2025 17:06

melvin-bot bot requested review from nkuoch and removed request for a team August 18, 2025 17:07

This comment has been minimized.

Sign in to view

youssef-lr removed the request for review from nkuoch August 18, 2025 17:08

youssef-lr added 3 commits August 26, 2025 21:28

Fix TS

7f41fdb

Fix tests

fafffa2

Fix TS

0442029

ishpaul777 reviewed Aug 26, 2025

View reviewed changes

src/components/Search/index.tsx Show resolved Hide resolved

Remove redundant condition

8e1e8d1

ishpaul777 approved these changes Aug 27, 2025

View reviewed changes

melvin-bot bot requested a review from lakchote August 27, 2025 19:01

luacmartins approved these changes Aug 27, 2025

View reviewed changes

luacmartins merged commit 332d296 into main Aug 27, 2025
27 of 29 checks passed

luacmartins deleted the youssef_auto_hide_columns_2 branch August 27, 2025 19:32

github-actions bot mentioned this pull request Aug 27, 2025

[Due for payment 2025-09-12] Investigate workflow job failing on main: test / test (job 3) #69389

Closed

VickyStash mentioned this pull request Aug 27, 2025

Update several transactions expense in the chat to work as expected if no optimistic thread report was created #68536

Merged

51 tasks

OSBotify mentioned this pull request Aug 28, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

This was referenced Aug 28, 2025

[Due for payment 2025-09-12] Reports - Long expense description is not truncated #69402

Closed

[Due for payment 2025-09-12] [Due for payment 2025-09-09] Expense - Expenses are not sorted after clicking on Description table header #69403

Closed

jponikarchuk mentioned this pull request Aug 28, 2025

[Due for payment 2025-09-12] [Due for payment 2025-09-09] Expense - User mention in expense description is not displayed, <mention-user>@ on small screen #69405

Closed

8 tasks

NikkiWines added a commit that referenced this pull request Aug 28, 2025

Revert "Merge pull request #68561 from Expensify/youssef_auto_hide_co…

54e3a88

…lumns_2" This reverts commit 332d296, reversing changes made to 5f6e6ee.

vincdargento mentioned this pull request Aug 29, 2025

iOS - “To” column incorrectly displayed in iOS when expenses are submitted #69566

Closed

8 tasks

ishpaul777 reviewed Sep 11, 2025

View reviewed changes

Auto show/hide columns depending on available data #68561

Auto show/hide columns depending on available data #68561

Uh oh!

Conversation

youssef-lr commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

This comment has been minimized.

shawnborton commented Aug 18, 2025

Uh oh!

youssef-lr commented Aug 18, 2025

Uh oh!

shawnborton commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

youssef-lr commented Aug 18, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

Uh oh!

ishpaul777 commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 27, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 27, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

vincdargento commented Aug 29, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

ishpaul777 Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

youssef-lr commented Aug 14, 2025 •

edited

Loading

shawnborton commented Aug 18, 2025 •

edited

Loading

ishpaul777 commented Aug 27, 2025 •

edited

Loading

ishpaul777 Sep 11, 2025 •

edited

Loading