Background is changed when reloading keyboard shortcut modal #68741

dukenv0307 · 2025-08-19T11:06:23Z

Explanation of Change

Fixed Issues

$ #67944
PROPOSAL: #67944 (comment)

Tests

Case 1:

Go to Account -> About page
Click the View keyboard shortcuts button
Reload the page
4.Verify that background isn't changed

Case 2:

Go to settings > About > App download links
Press Ctrl + J or Cmd + J
Refresh page
Press back
Verify app goes back to App download links page

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-08-19.at.18.02.03.mov

Android: mWeb Chrome

Screen.Recording.2025-08-19.at.18.00.27.mov

iOS: Native

Screen.Recording.2025-08-19.at.18.02.51.mov

iOS: mWeb Safari

Screen.Recording.2025-08-19.at.17.59.56.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-19.at.17.58.26.mov

MacOS: Desktop

Screen.Recording.2025-08-19.at.18.03.07.mov

melvin-bot · 2025-08-19T11:10:57Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-08-20T15:19:11Z

src/pages/KeyboardShortcutsPage.tsx


-function KeyboardShortcutsPage() {
+type KeyboardShortcutsPageProps = {
+    backTo: Routes;


backTo param does not work here, it should be taken from route. See how it should be here:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

Line 59 in b70d010

type ReimbursementAccountPageProps = WithPolicyOnyxProps & PlatformStackScreenProps<ReimbursementAccountNavigatorParamList, typeof SCREENS.REIMBURSEMENT_ACCOUNT_ROOT>;

After fixing this, please add this test case:

Go to settings > About > App download links

Press Ctrl + J or Cmd + J

Refresh page

Press back

Verify app goes back to App download links page

@dukenv0307 Maybe you missed to add the above test case 👆

Maybe you missed👆

Thank you, I added!

dominictb · 2025-08-20T15:25:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-26.at.16.07.31.mov

Android: mWeb Chrome

Screen.Recording.2025-08-26.at.16.02.56.mov

iOS: HybridApp

Screen.Recording.2025-08-20.at.22.33.35.mov

iOS: mWeb Safari

Screen.Recording.2025-08-20.at.22.34.16.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-20.at.22.26.34.mov

MacOS: Desktop

Screen.Recording.2025-08-20.at.22.26.09.mov

dukenv0307 · 2025-08-22T08:48:55Z

@dominictb Thanks for your feedback. I updated!

dominictb

OSBotify · 2025-08-26T11:37:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-28T01:39:03Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.2.0-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T22:17:57Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T23:11:10Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 added 2 commits August 19, 2025 18:04

Background is changed when reloading keyboard shortcut modal

b2c5cfd

update backTo

f656b89

dukenv0307 marked this pull request as ready for review August 19, 2025 11:10

dukenv0307 requested a review from a team as a code owner August 19, 2025 11:10

melvin-bot bot requested a review from dominictb August 19, 2025 11:10

melvin-bot bot removed the request for review from a team August 19, 2025 11:10

Merge branch 'main' into fix/67944

78e1178

dominictb suggested changes Aug 20, 2025

View reviewed changes

update backTo

b40128a

dukenv0307 added 2 commits August 22, 2025 16:41

lint fix

47b5171

Merge branch 'main' into fix/67944

e81ee74

dominictb approved these changes Aug 26, 2025

View reviewed changes

melvin-bot bot requested a review from techievivek August 26, 2025 09:08

techievivek approved these changes Aug 26, 2025

View reviewed changes

techievivek merged commit f54a2c1 into Expensify:main Aug 26, 2025
21 checks passed

OSBotify mentioned this pull request Aug 28, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

melvin-bot bot mentioned this pull request Sep 2, 2025

[Due for payment 2025-09-09] [$250] Background is changed when reloading keyboard shortcut modal #67944

Closed

16 tasks

Background is changed when reloading keyboard shortcut modal #68741

Background is changed when reloading keyboard shortcut modal #68741

Uh oh!

Conversation

dukenv0307 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 19, 2025

Uh oh!

dominictb Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Aug 22, 2025

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 26, 2025

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Aug 19, 2025 •

edited

Loading

dominictb commented Aug 20, 2025 •

edited

Loading