-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix/68191 - Keyboard appear briefly when press device back button on selector #68818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-08-26.at.04.14.55.movAndroid: mWeb ChromeScreen.Recording.2025-08-26.at.04.07.57.movScreen.Recording.2025-08-26.at.04.06.26-compressed.movScreen.Recording.2025-08-26.at.04.08.44.moviOS: HybridAppScreen.Recording.2025-08-26.at.04.11.40.moviOS: mWeb SafariScreen.Recording.2025-08-26.at.04.13.24.movScreen.Recording.2025-08-26.at.04.12.53-compressed.movMacOS: Chrome / SafariScreen.Recording.2025-08-26.at.04.10.04-compressed.movMacOS: Desktop |
|
@dmkt9 Conflicts. |
I have just merged the latest version of the main. |
dominictb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
Explanation of Change
Fixed Issues
$ #68191
PROPOSAL: #68191 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
/enable-payments, the add bank account flow, orProfile > Date of birthPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
The issue does not occur.
iOS: mWeb Safari
The issue does not occur.
MacOS: Chrome / Safari
The issue does not occur.
MacOS: Desktop
The issue does not occur.