Skip to content

Merge expense - Tooltip is shown when hovered over category when category is not truncated #68849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 3 commits into from
Aug 22, 2025
Merged

Merge expense - Tooltip is shown when hovered over category when category is not truncated #68849

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bbfd81
fix: tooltip is shown when hover even category is not truncated
thelullabyy Aug 20, 2025
cb017f0
update code
thelullabyy Aug 20, 2025
9f561d4
fix lint
thelullabyy Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 14 additions & 21 deletions src/components/SelectionList/Search/TextWithIconCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import React from 'react';
import {View} from 'react-native';
import type {StyleProp, TextStyle} from 'react-native';
import Icon from '@components/Icon';
import Text from '@components/Text';
import Tooltip from '@components/Tooltip';
import TextWithTooltip from '@components/TextWithTooltip';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import type IconAsset from '@src/types/utils/IconAsset';
Expand All @@ -24,24 +23,18 @@ export default function TextWithIconCell({icon, text, showTooltip, textStyle}: T
}

return (
<Tooltip
shouldRender={showTooltip}
text={text}
>
<View style={[styles.flexRow, styles.flexShrink1, styles.gap1]}>
<Icon
src={icon}
fill={theme.icon}
height={12}
width={12}
/>
<Text
numberOfLines={1}
style={[styles.optionDisplayName, styles.label, styles.pre, styles.justifyContentCenter, styles.textMicro, styles.textSupporting, styles.flexShrink1, textStyle]}
>
{text}
</Text>
</View>
</Tooltip>
<View style={[styles.flexRow, styles.flexShrink1, styles.gap1]}>
<Icon
src={icon}
fill={theme.icon}
height={12}
width={12}
/>
<TextWithTooltip
text={text}
shouldShowTooltip={showTooltip}
style={[styles.optionDisplayName, styles.label, styles.pre, styles.justifyContentCenter, styles.textMicro, styles.textSupporting, styles.flexShrink1, textStyle]}
/>
</View>
);
}
Loading