[No QA] Chore: Bump `react-native-web` to 0.21.2 by staszekscp · Pull Request #68902 · Expensify/App

staszekscp · 2025-08-21T07:38:12Z

Explanation of Change

Bumps react-native-web to 0.21.2. It is necessary to fix a memory leak that currently is handled by a patch. By looking at the diff it seems like the changes to react-native-web were pretty cosmetic so it shouldn't cause any problems

Fixed Issues

$ #68951
PROPOSAL:

Tests

To test the memory leak

Go to the Inspect -> Performance Monitor
If you don't have it, you should be able to find it here:

Look for the DOM Nodes value
Start switching tabs
Notice if once in a while the number of DOM Nodes drops drastically

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

Screen.Recording.2025-08-21.at.09.16.48.mov

iOS: Native

N/A

iOS: mWeb Safari

Screen.Recording.2025-08-21.at.09.37.13.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-21.at.09.15.13.mov

MacOS: Desktop

Screen.Recording.2025-08-21.at.09.22.03.mov

melvin-bot · 2025-08-21T07:38:18Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-08-21T07:38:23Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

mountiny · 2025-08-21T11:12:14Z

@sobitneupane can you review please

sobitneupane · 2025-08-21T12:05:58Z

Sure @mountiny

sobitneupane

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-08-21.at.20.25.19.mov

iOS: HybridApp

Screen.Recording.2025-08-21.at.20.31.37.mov

iOS: mWeb Safari

Screen.Recording.2025-08-20.at.19.24.12.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-21.at.19.45.35.mov

MacOS: Desktop

Screen.Recording.2025-08-21.at.20.38.08.mov

sobitneupane · 2025-08-21T15:11:26Z

@staszekscp I was able to reproduce a strange issue on Android (mWeb: Chrome). When I open a chat and try to tap the composer, it doesn’t get focus. Instead, it triggers the navbar in the background. Could you please test this on your end?

Screen.Recording.2025-08-21.at.20.30.50.mov

mountiny · 2025-08-21T18:38:24Z

@sobitneupane is that not repro on main/ staging?

…ve-web

staszekscp · 2025-08-21T19:11:19Z

Three things that need to be said:

@sobitneupane - Great catch, thanks!
@mountiny - It's not reproducible on main
I think I know the suspect and tomorrow I'll have a look!

roryabraham · 2025-08-21T19:39:58Z

patches/react-native-web/details.md

 - PR introducing patch: https://github.com/Expensify/App/pull/67552

-### [react-native-web+0.20.0+011+fix-memory-leak.patch](react-native-web+0.20.0+011+fix-memory-leak.patch)
+### [react-native-web+0.21.1+011+fix-memory-leak.patch](react-native-web+0.21.1+011+fix-memory-leak.patch)


Shouldn't we remove this details.md entry, since the patch has been deleted?

Oh, right, I forgot about it, thanks for reminding!

mountiny · 2025-08-21T19:44:15Z

@staszekscp do you have some test steps for @sobitneupane to confirm the memory leak is no longer reproducible too? thanks!

staszekscp · 2025-08-22T06:05:16Z

@mountiny Yes, the steps would be basically the same as in the memory leak fix PR, updated the despcription!

staszekscp · 2025-08-22T13:58:58Z

Hey! 👋🏻 I'm back with some news about the regression found by @sobitneupane

I think there is a severe problem with react-native-web and pointerEvents. I discovered that its behaviour differs depending on the way they are passed to components. If we're not passing it via official StyleSheet.create() they don't get generated correctly. It means that box-none and box-only don't work at all on the web. I think the reason is that the following logic runs only when pointer-event is passed via StyleSheet.create(). Example below:

// No pointer-event gets added
<View style={{pointerEvents: 'box-none'}}

// Correct behaviour
<View style={styles.pointerEventNone};

const styles = StyleSheet.create({
  pointerEventNone: {
    pointerEvents: 'box-none'
 }
})

Screen.Recording.2025-08-22.at.11.47.10.mov

The regression in the PR is somehow related. There was an issue created by @tienifr 2 years ago that finally got "fixed". Unfortunately I believe the fix is the reason for a huge mess in the pointer-event propagation. I tested the behaviour of 0.21.1 on a minimal reproduction and it seems like the * CSS selector spreads the pointer-events all over the app overriding previously used properties in many places causing some unexpected behaviour.

When I switched back to 0.20.0 it turned out that the behaviour of pointer-events was correct while passing them via StyleSheet.create(). I suppose that @tienifr could have opened the issue because in Expensify/App we're using JavaScript objects and inline styling. I think this must be fixed before we proceed with the bump. [Reproduction]

I've created an issue, but I'll try to tackle that next week.

This may be also a cause for some regressions on the web when some buttons were not responsive or unexpected navigation actions got triggered.

mountiny · 2025-08-22T17:53:39Z

This may be also a cause for some regressions on the web when some buttons were not responsive or unexpected navigation actions got triggered.

When did we bump to this version? we saw couple of issues that might be related

Thanks for digging, great job!

roryabraham · 2025-08-22T18:04:09Z

Thanks for the investigation and upstream issue @staszekscp. Just to clarify, is this bug something that could be fixed by wrapping our styles in Stylesheet.create?

staszekscp · 2025-08-22T18:46:37Z

When did we bump to this version?

@mountiny During the RN 79 bump we bumped it from 0.19.13 to 0.20.0, nevertheless it may have been in the App for a longer time

Is this bug something that could be fixed by wrapping our styles in Stylesheet.create

@roryabraham Theoretically, but I think that it could cause some new unexpected behaviour, so it would have to be done carefully. I also noticed that there are some other CSS attributes that may have a similar problem. In general it seems like StyleSheet.create() adds some logic on the web, so I think that in the longer term it would be better to use it instead of plain JS objects. Maybe it's time to think about it? Anyways, I'll be back on Monday and I'll see what can be done to fix the problem with the pointerEvents. Have a nice weekend!

mountiny · 2025-08-22T20:08:26Z

Ok, thanks for the explanation. Have a great weekend too

staszekscp · 2025-09-01T06:51:50Z

Hey! Just a quick update: My fix for the regression found by @sobitneupane has been merged. However it seems that Necolas is not interested in fixing the pointerEvents inline styling for the web, so its behaviour will still differ. My suggestion is to enforce using StyleSheet.create() in App for this specific styling prop. Maybe we could also add a special lint rule to make sure that pointerEvents doesn't get passed without directly, without wrapping.

As per the PR I think we can wait for my fix to be released in 0.21.2, then we can proceed

mountiny · 2025-09-01T20:12:55Z

Ok that makes sense @staszekscp thank you! Not much we can do about the pointerEvents i guess

roryabraham · 2025-09-03T04:39:38Z

Put this on HOLD while we wait for 0.21.2: https://github.com/necolas/react-native-web/releases

For what it's worth @staszekscp, I think in some ways it would be simpler to always use Stylesheet.create than to enforce it in one specific use-case. Maybe we should chat about it in slack

Update: @staszekscp posted a proposal for StyleSheet.create here

staszekscp · 2025-10-20T11:08:12Z

Hey @sobitneupane! I've just bumped the react-native-web to the newest version that includes the fix for the issue you've found. Unfortunately the tests are failing because of global node issues, but in general the PR is ready for review

sobitneupane

Seems like the details in patches/react-native-web/details.md are still pending an update.

sobitneupane · 2025-10-20T13:45:19Z

.nvmrc

@@ -1 +1 @@
-20.19.4
+20.19.3


I think this file might have been modified unintentionally.

Suggested change

20.19.3

20.19.4

sobitneupane · 2025-10-20T14:02:35Z

This issue is no longer reproducible.

Screen.Recording.2025-10-20.at.19.46.02.mov

sobitneupane · 2025-10-20T14:04:34Z

Screenshots/Videos

Android: mWeb Chrome

Screen.Recording.2025-10-20.at.19.46.02.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-20.at.19.34.14.mov

sobitneupane · 2025-10-21T08:39:07Z

patches/react-native-web/details.md

 - PR introducing patch: https://github.com/Expensify/App/pull/67552

-### [react-native-web+0.20.0+011+fix-memory-leak.patch](react-native-web+0.20.0+011+fix-memory-leak.patch)
+### [react-native-web+0.21.2+011+fix-memory-leak.patch](react-native-web+0.21.2+011+fix-memory-leak.patch)


Since we’re removing patches/react-native-web/react-native-web+0.20.0+011+fix-memory-leak.patch, should we also remove this block of code?

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mountiny · 2025-10-21T14:36:22Z

@staszekscp This is not on hold anymore right? should that be removed from the title?

staszekscp · 2025-10-21T16:10:00Z

@mountiny Yes, I think it was held because we were waiting for the release

mountiny

LGTM

@roryabraham Should be all yours

OSBotify · 2025-10-22T00:09:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-23T13:08:38Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-24T17:50:49Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bump react-native-web

af3b084

staszekscp requested a review from a team as a code owner August 21, 2025 07:38

melvin-bot bot assigned staszekscp Aug 21, 2025

melvin-bot bot requested review from sobitneupane and removed request for a team August 21, 2025 07:38

mountiny self-requested a review August 21, 2025 11:12

sobitneupane reviewed Aug 21, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into chore/bump-react-nati…

1a8293b

…ve-web

roryabraham requested changes Aug 21, 2025

View reviewed changes

staszekscp mentioned this pull request Aug 27, 2025

Fix: pointerEvents propagation necolas/react-native-web#2802

Closed

roryabraham changed the title ~~[No QA] Chore: Bump react-native-web to 0.21.1~~ [HOLD][No QA] Chore: Bump react-native-web to 0.21.1 Sep 3, 2025

staszekscp added 2 commits October 20, 2025 10:51

Merge branch 'main' into chore/bump-react-native-web

c6a3078

Bump react-native-web to 0.21.2

d5cd931

sobitneupane reviewed Oct 20, 2025

View reviewed changes

staszekscp added 2 commits October 21, 2025 10:09

Update details.md for react-native-web patches

a1cac77

Revert .nvmrc change

827a00b

staszekscp changed the title ~~[HOLD][No QA] Chore: Bump react-native-web to 0.21.1~~ [HOLD][No QA] Chore: Bump react-native-web to 0.21.2 Oct 21, 2025

Retrigger tests, since they pass locally

7797069

sobitneupane reviewed Oct 21, 2025

View reviewed changes

Update details.md for react-native-web patches

2d1d6d3

sobitneupane approved these changes Oct 21, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham October 21, 2025 12:33

mountiny changed the title ~~[HOLD][No QA] Chore: Bump react-native-web to 0.21.2~~ [No QA] Chore: Bump react-native-web to 0.21.2 Oct 21, 2025

mountiny approved these changes Oct 21, 2025

View reviewed changes

roryabraham approved these changes Oct 21, 2025

View reviewed changes

roryabraham merged commit 89e6c6c into Expensify:main Oct 21, 2025
35 checks passed

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

roryabraham mentioned this pull request Oct 24, 2025

[Due for payment 2025-10-31] Upgrade react-native-web to 0.21.1+ #68951

Closed

Conversation

staszekscp commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

mountiny commented Aug 21, 2025

Uh oh!

sobitneupane commented Aug 21, 2025

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

sobitneupane commented Aug 21, 2025

Uh oh!

mountiny commented Aug 21, 2025

Uh oh!

staszekscp commented Aug 21, 2025

Uh oh!

roryabraham Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

staszekscp Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny commented Aug 21, 2025

Uh oh!

staszekscp commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staszekscp commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Aug 22, 2025

Uh oh!

roryabraham commented Aug 22, 2025

Uh oh!

staszekscp commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Aug 22, 2025

Uh oh!

staszekscp commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Sep 1, 2025

Uh oh!

roryabraham commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staszekscp commented Oct 20, 2025

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Uh oh!

sobitneupane Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

staszekscp Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

sobitneupane commented Oct 20, 2025

Uh oh!

sobitneupane commented Oct 20, 2025

Screenshots/Videos

Uh oh!

sobitneupane Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

sobitneupane left a comment

staszekscp commented Aug 21, 2025 •

edited

Loading

staszekscp commented Aug 22, 2025 •

edited

Loading

staszekscp commented Aug 22, 2025 •

edited

Loading

staszekscp commented Aug 22, 2025 •

edited

Loading

staszekscp commented Sep 1, 2025 •

edited

Loading

roryabraham commented Sep 3, 2025 •

edited

Loading