#2 - Fix number format polyfill isn't applied #68923

bernhardoj · 2025-08-21T14:10:06Z

Explanation of Change

Fixed Issues

$ #66784
PROPOSAL: #66784 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open FAB > Create expense
Change the currency to XPF
Verify that the symbol shown is CFPF
Change the currency to XOF
Verify that the symbol shown is F CFA
Change the currency to XCD
Verify that the symbol shown is EC$
Change the currency to XAF
Verify that the symbol shown is FCFA

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-21T14:10:14Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-09-17T05:00:26Z

@abdulrahuman5196 bump for review

abdulrahuman5196 · 2025-09-21T13:48:30Z

@bernhardoj This is the same change as previous right? wouldn't it cause a crash again like here?

#68345

bernhardoj · 2025-09-22T01:33:54Z

@abdulrahuman5196 yes, it's the same change, but as I mentioned here, I can't actually reproduce the issue, so if possible, can you please test it on the hybrid app too?

If you can't repro the crash too, maybe there is some conflict before with other code.

abdulrahuman5196 · 2025-09-25T18:22:41Z

Screen.Recording.2025-09-25.at.11.49.37.PM.mov

Screen.Recording.2025-09-25.at.11.50.55.PM.mov

@bernhardoj I am able to see the crash in Hybrid iOS app.

bernhardoj · 2025-09-29T16:02:27Z

src/setup/index.ts


-    // Polyfill the Intl API if locale data is not as expected
-    intlPolyfill();
-


Hmm, this is hard because I can't use the Hybrid app. My best guess is that, there are some polyfills that are required but not loaded yet because we now only call the polyfill in NumberFormatUtils. I think we should keep this intlPolyfill in setup. Can you try that?

@abdulrahuman5196

@abdulrahuman5196 bump

Hi, Will try to repro this again on this tomorrow. Meanwhile you could also check? Hybrid app setup is actually straightforward now.

@bernhardoj I don't face members crash if we keep this in setup.

Still trying to run the app, facing some problems

@abdulrahuman5196 I can reproduce the crash now on the HybridApp, and adding back the polyfill in setup works. We can continue with the PR.

a.mp4

@abdulrahuman5196 bump

@bernhardoj The code looks fine. In the author's checklist, could you kindly test again in the issue scenario due to new changes and also check in the places where crashes happened due to regression and update the author's checklist screenshot. Currently the screenshot are old during the initial pr raise.

I will do the same from my end once the author's checklist is complete.

@abdulrahuman5196 done

codecov · 2025-10-19T15:08:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/libs/NumberFormatUtils/index.ts	`100.00% <100.00%> (ø)`

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

abdulrahuman5196 · 2025-11-05T09:27:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-05.at.2.38.12.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-11-05.at.2.52.46.PM.mov

iOS: HybridApp

Screen.Recording.2025-11-05.at.2.20.11.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-11-05.at.2.23.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-05.at.1.49.56.PM.mov

MacOS: Desktop

Screen.Recording.2025-11-05.at.2.03.08.PM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Valforte

🎀 👀 🎀
C+ Reviewed

OSBotify · 2025-11-05T14:34:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-05T20:37:22Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.2.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-06T23:19:55Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix number format polyfill isn't applied

aafacf0

bernhardoj requested a review from a team as a code owner August 21, 2025 14:10

melvin-bot bot assigned bernhardoj Aug 21, 2025

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team August 21, 2025 14:10

Merge branch 'main' into fix/66784-inconsistent-currency-symbol

f54cab5

Merge branch 'main' into fix/66784-inconsistent-currency-symbol

5558a8f

bernhardoj commented Sep 29, 2025

View reviewed changes

bernhardoj added 2 commits October 19, 2025 22:54

Merge branch 'main' into fix/66784-inconsistent-currency-symbol

79b6dba

readd polyfill in setup code

006ecaf

bernhardoj added 2 commits November 2, 2025 00:53

Merge branch 'main' into fix/66784-inconsistent-currency-symbol

0983af1

Merge branch 'main' into fix/66784-inconsistent-currency-symbol

a792c53

abdulrahuman5196 approved these changes Nov 5, 2025

View reviewed changes

melvin-bot bot requested a review from Valforte November 5, 2025 09:29

Valforte approved these changes Nov 5, 2025

View reviewed changes

Valforte merged commit d74f9fd into Expensify:main Nov 5, 2025
26 checks passed

OSBotify mentioned this pull request Nov 5, 2025

Deploy Checklist: New Expensify 2025-11-05 #74371

Closed

79 tasks

nlemma mentioned this pull request Nov 6, 2025

[$250] Expense-Inconsistent XOF currency display in amount field and per diem receipt #74437

Open

8 tasks

melvin-bot bot mentioned this pull request Nov 6, 2025

[Due for payment 2025-11-13] [$250] Mweb- specially symbols after WST) are not correctly displayed on mWeb chrome #66784

Closed

8 tasks


		// Polyfill the Intl API if locale data is not as expected
		intlPolyfill();

#2 - Fix number format polyfill isn't applied #68923

#2 - Fix number format polyfill isn't applied #68923

Uh oh!

Conversation

bernhardoj commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 21, 2025

Uh oh!

bernhardoj commented Sep 17, 2025

Uh oh!

abdulrahuman5196 commented Sep 21, 2025

Uh oh!

bernhardoj commented Sep 22, 2025

Uh oh!

abdulrahuman5196 commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abdulrahuman5196 commented Nov 5, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Aug 21, 2025 •

edited

Loading

codecov bot commented Oct 19, 2025 •

edited

Loading