-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[No QA] Fix FAQ header styles in Connect-to-QuickBooks-Online.md #69035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sonialiap |
|
@Julesssss @sonialiap One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No engineer review is needed for this one. @sonialiap, feel free to merge after approving. Thanks! |
|
A preview of your ExpensifyHelp changes have been deployed to https://a84ab3d1.helpdot.pages.dev ⚡️ |
|
@sonialiap looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Not an emergency, was just missing the checklist 👍 |
|
🚀 Deployed to staging by https://github.com/sonialiap in version: 9.2.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
Explanation of Change
A few quick typo & styling fixes:
#header style, but should have a##header style.\at the end of a section title.Fixed Issues
No issue
Tests
No tests
Offline tests
No offline tests
QA Steps
No QA
PR Author Checklist
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Old header styles:
Correct header style from a different article: