Skip to content

Revert "fix: Navigation bar not translucent in modals on Android"#69036

Merged
blimpich merged 1 commit intomainfrom
revert-69004-@chrispader/fix-transparent-navigation-bar-in-modals
Aug 22, 2025
Merged

Revert "fix: Navigation bar not translucent in modals on Android"#69036
blimpich merged 1 commit intomainfrom
revert-69004-@chrispader/fix-transparent-navigation-bar-in-modals

Conversation

@blimpich
Copy link
Copy Markdown
Contributor

@blimpich blimpich commented Aug 22, 2025

Reverts #69004, which I merged without C+ review because I thought it was a low-risk style change, but since its a patch we should probably be more careful.

@blimpich blimpich self-assigned this Aug 22, 2025
@blimpich blimpich requested a review from a team as a code owner August 22, 2025 16:27
@melvin-bot melvin-bot bot requested a review from Julesssss August 22, 2025 16:27
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Aug 22, 2025

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team August 22, 2025 16:27
@blimpich blimpich changed the title Revert "fix: Navigation bar not translucent in modals on Android" [HOLD] Revert "fix: Navigation bar not translucent in modals on Android" Aug 22, 2025
@blimpich
Copy link
Copy Markdown
Contributor Author

blimpich commented Aug 22, 2025

holding as we might not need to revert, discussing in DM with contributor

@blimpich blimpich changed the title [HOLD] Revert "fix: Navigation bar not translucent in modals on Android" Revert "fix: Navigation bar not translucent in modals on Android" Aug 22, 2025
@shubham1206agra
Copy link
Copy Markdown
Contributor

Screenshot 2025-08-22 at 10 05 28 PM

The patch does not work. The workflow will not work as the App is not built.

cc @chrispader

@blimpich blimpich merged commit 6761677 into main Aug 22, 2025
20 of 25 checks passed
@blimpich blimpich deleted the revert-69004-@chrispader/fix-transparent-navigation-bar-in-modals branch August 22, 2025 16:40
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Aug 22, 2025

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich
Copy link
Copy Markdown
Contributor Author

Didn't wait for checks to pass since it's a straight revert

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.98-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants