-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Create central-billing Help article #69121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Creating Central Billing Help article Tracking GH Expensify/Expensify#534621
JS00001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the filename to central-billing.md? It is currently not a markdown file which is causing the preview build to fail
Reviewer Checklist
|
Updated the article name
|
A preview of your ExpensifyHelp changes have been deployed to https://f7ce94d2.helpdot.pages.dev ⚡️ |
JS00001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## How to set up a Central Billing card | ||
|
|
||
| 1. Connect the central billing card to Expensify: | ||
| - For **Expensify Classic**, follow [this guide to connect a company card](link here) or [apply for the Expensify Card](link here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these have links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should! Adding them now!
adding links to some mentions
JS00001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Do we want to wait on @strepanier03 to review as well?
|
Yes! We'll wait for @strepanier03! Thanks for the review @JS00001! |
Updated the file name to be capitalized so the title is capitalized.
Updated some formatting and added the access instructions we should include with every Travel doc.
|
I'll wait for the build and then give it another look before approving. |
strepanier03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the build again, this looks good and we can make any other changes after this is live.
|
Build looked great, since we're all approved I merged. |
|
🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.2.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|

Explanation of Change
Creating Central Billing Help article
Tracking GH https://github.com/Expensify/Expensify/issues/534621
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop