fix scroll reset on back by huult · Pull Request #69128 · Expensify/App

huult · 2025-08-25T03:56:33Z

Details

Fixed Issues

$ #66751
PROPOSAL: #66751 (comment)
$ #68924

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Issue #66751

Open the Expensify app.
Open the Reports page.
Scroll down and select a report that is not near the top.
View the report, then click the Back button in the top-left corner.
Verify the user is returned to the same scroll position on the Reports page as before opening the report.

Issue #68924

Open the app on a mobile device.
Navigate to the "Reports" section.
Scroll down and observe that the search input and filters do not hide.
Verify that when scrolling down, the search input and filters hide with the content.
Verify that when scrolling up slightly, the search input and filters reappear.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-08-14.at.13.04.06.mp4

Android: mWeb Chrome

Screen.Recording.2025-08-14.at.13.04.50.mp4

iOS: Native

Screen.Recording.2025-08-14.at.13.07.43.mp4

iOS: mWeb Safari

Screen.Recording.2025-08-14.at.13.08.33.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-08-14.at.12.52.44.mp4

MacOS: Desktop

Screen.Recording.2025-08-14.at.12.55.57.mp4

melvin-bot · 2025-08-25T03:56:38Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2025-08-25T04:00:03Z

#68924 This issue occurred because onScroll is a worklet, and we were checking its type as a function, which caused the issue. I've updated the condition to fix it. cc @akinwale , @JS00001

JS00001

Screen.Recording.2025-08-25.at.6.47.18.AM.mov

Looks like the main issue this PR fixes isnt working

…set-on-back

huult · 2025-08-25T10:55:30Z

@JS00001 On my side, it’s working.

Screen.Recording.2025-08-25.at.17.54.41.mov

akinwale · 2025-08-25T11:59:19Z

@huult Also confirming that it doesn't work on iOS Safari when I tested on my end.

error-ios-safari.mp4

Please check mWeb and confirm.

huult · 2025-08-25T12:00:32Z

yes i will

huult · 2025-08-26T08:02:00Z

I got the issue https://expensify.slack.com/archives/C01GTK53T8Q/p1756188224505719. I will update it soon.

…set-on-back

huult · 2025-08-27T04:21:49Z

I fixed the issue by adjusting the condition check onScroll a bit

Screen.Recording.2025-08-27.at.11.20.42.mp4

huult · 2025-08-27T04:22:06Z

@akinwale could you review again? thanks

src/components/Search/SearchList/index.tsx

JS00001 · 2025-08-27T15:29:09Z

src/components/Search/SearchList/index.tsx

                onSelectRow={onSelectRow}
                keyExtractor={keyExtractor}
-                onScroll={onScroll}
+                onScroll={onScroll && typeof onScroll === 'function' ? handleScroll : onScroll}


I dont understand this, we check if onscroll exists, and is a function, and if it IS, then we dont call it?

added comment to explain this

JS00001 · 2025-08-27T15:35:31Z

Screen.Recording.2025-08-27.at.11.34.54.AM.mov

Still not working for me

…set-on-back

huult · 2025-08-27T16:26:52Z

@JS00001

Still not working for me

Is it not working on the whole platform, or only on the iOS native app?

huult · 2025-08-27T16:39:07Z

I know the issue here is due to recent changes. I will update it soon, please wait for the next update.

JS00001 · 2025-08-27T16:42:02Z

Is it not working on the whole platform, or only on the iOS native app?

This is on web on chrome

…set-on-back

huult · 2025-08-28T05:13:27Z

@akinwale @JS00001 I have completed the update. Could you review it again?

Screen.Recording.2025-08-28.at.12.10.35.mp4

…set-on-back

huult · 2025-08-28T15:20:50Z

I merged main and encountered some issues due to recent changes. I’m checking them and will inform you when it’s ready

…set-on-back

huult · 2025-08-29T04:50:38Z

Hello @akinwale @JS00001

Screen.Recording.2025-08-29.at.11.46.56.mov

I think recent change is causing the issue with scrollOffset and scrollToIndex. The problem I mentioned is that when going back to the search list, it either scrolls to the top offset or to the index.

With the old BaseSearchList, this didn’t happen (as shown in the video above). I think we should either hold off on this fix or decide whether we still accept this behavior.

What do you think?

trjExpensify

I think we should either hold off on this fix or decide whether we still accept this behavior.

Are you asking whether we still want to fix this bug?

User scrolls the list of report search results
Clicks into a report
Clicks the back caret
User lands at the top of the list of reports and not the scroll position they were at in (2).

If so, then yes, I still think we want to fix that bug.

huult · 2025-09-01T01:40:08Z

@trjExpensify Yes, I think it’s a bug and we need to fix it. Let me find the PR causing this issue. To my knowledge, this issue happened due to recent changes. Five days ago, it didn’t happen.

…set-on-back

huult · 2025-09-03T03:50:02Z

@akinwale #69128 (comment) What do you think? Do you know which PR is causing this issue?

…set-on-back

huult · 2025-09-04T01:56:32Z

Sorry @trjExpensify, I forgot to set animated: false, that’s why the issue showed in my video.

@akinwale @JS00001 I’ve already updated it. Can we proceed with reviewing this PR?

JS00001 · 2025-09-04T11:22:37Z

Yes, @akinwale lets try and get this merged today

akinwale · 2025-09-04T12:07:22Z

@huult The perf test is failing.

JS00001 · 2025-09-04T12:11:29Z

I think its flaky rn, lets continue review

akinwale · 2025-09-04T12:37:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

69128-android-hybrid.mp4

Android: mWeb Chrome

69128-android-chrome.mp4

iOS: HybridApp

69128-ios-hybrid.mp4

iOS: mWeb Safari

69128-ios-safari.mp4

MacOS: Chrome / Safari

69128-web.mp4

MacOS: Desktop

69128-desktop.mp4

akinwale

LGTM.

OSBotify · 2025-09-04T13:37:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-05T20:03:02Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.2-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-09T03:05:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.2-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix scroll reset on back

05ffeec

huult requested a review from a team as a code owner August 25, 2025 03:56

melvin-bot bot assigned huult Aug 25, 2025

melvin-bot bot requested a review from akinwale August 25, 2025 03:56

melvin-bot bot removed the request for review from a team August 25, 2025 03:56

JS00001 self-requested a review August 25, 2025 10:45

JS00001 requested changes Aug 25, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

1b55809

…set-on-back

huult added 2 commits August 27, 2025 09:44

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

0b05d9e

…set-on-back

update the condition check onScroll

5b3485d

JS00001 requested changes Aug 27, 2025

View reviewed changes

huult added 2 commits August 27, 2025 23:19

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

50cf29b

…set-on-back

remove code unused

8b76a0a

huult added 2 commits August 28, 2025 11:27

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

cba64e9

…set-on-back

update logic save offset

af96309

JS00001 previously approved these changes Aug 28, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

c9a4766

…set-on-back

huult dismissed JS00001’s stale review via c9a4766 August 28, 2025 15:06

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

e7d85dd

…set-on-back

huult requested a review from a team as a code owner August 29, 2025 04:08

add requestAnimationFrame

4d7f01d

trjExpensify reviewed Aug 30, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

7c449ca

…set-on-back

huult added 2 commits September 4, 2025 08:42

Merge remote-tracking branch 'upstream/main' into 66751-fix-scroll-re…

8cb0fb2

…set-on-back

disable animated when scroll to offset

8e599b1

akinwale approved these changes Sep 4, 2025

View reviewed changes

melvin-bot bot requested a review from JS00001 September 4, 2025 12:37

JS00001 approved these changes Sep 4, 2025

View reviewed changes

JS00001 merged commit 8de38f4 into Expensify:main Sep 4, 2025
21 of 22 checks passed

OSBotify mentioned this pull request Sep 5, 2025

Deploy Checklist: New Expensify 2025-09-05 #69979

Closed

jponikarchuk mentioned this pull request Sep 8, 2025

[HOLD][$250] Reports - Back button on report view returns to different scroll position #70080

Open

8 tasks

jjcoffee mentioned this pull request Mar 2, 2026

[No QA] Move wide page logic to wide component #83616

Merged

52 tasks

Conversation

huult commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 25, 2025

Uh oh!

huult commented Aug 25, 2025

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Aug 25, 2025

Uh oh!

akinwale commented Aug 25, 2025

Uh oh!

huult commented Aug 25, 2025

Uh oh!

huult commented Aug 26, 2025

Uh oh!

huult commented Aug 27, 2025

Uh oh!

huult commented Aug 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JS00001 Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

huult Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Aug 27, 2025

Uh oh!

huult commented Aug 27, 2025

Uh oh!

huult commented Aug 27, 2025

Uh oh!

JS00001 commented Aug 27, 2025

Uh oh!

huult commented Aug 28, 2025

Uh oh!

huult commented Aug 28, 2025

Uh oh!

huult commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Sep 1, 2025

Uh oh!

huult commented Sep 3, 2025

Uh oh!

huult commented Sep 4, 2025

Uh oh!

JS00001 commented Sep 4, 2025

Uh oh!

akinwale commented Sep 4, 2025

Uh oh!

JS00001 commented Sep 4, 2025

Uh oh!

akinwale commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 4, 2025

Uh oh!

huult commented Aug 25, 2025 •

edited

Loading

huult commented Aug 29, 2025 •

edited

Loading

akinwale commented Sep 4, 2025 •

edited

Loading