Reimplementation of Optimistic report names functionality by sosek108 · Pull Request #69147 · Expensify/App

sosek108 · 2025-08-25T10:57:40Z

Explanation of Change

This PR combines the functionality from three previously reverted PRs:

Optimistic report name computation #65862: Initial optimistic Custom Report Names implementation
[No QA] Fixed reassure tests for optimistic report name computation #68726: Fix for reassure performance tests
Introduce transactions updates into the optimistic report name formula #68737: Extended transaction support for report name computation

Key Features:

Real-time, formula-based report titles that update as expense data changes
Support for report fields: type, startdate, total, currency, policyname, created
Functions: frontpart, substr, domain for string manipulation
Optimistic updates work offline and provide visible changes without network
Transaction updates trigger report name recalculation
Performance optimized with caching and targeted updates
Beta flag controlled: authAutoReportTitle

Implementation Details:

Formula.ts: Formula parsing and computation engine
OptimisticReportNames.ts: Main logic for report name updates
OptimisticReportNamesConnectionManager.ts: Onyx data context manager
Enhanced API middleware to process optimistic data
Performance and unit tests included

Fixed Issues

$ #69175
$ #59689
PROPOSAL:

Tests

Follow QA Steps fields below

Offline tests

Turn on Force offline mode and do same steps as in QA Steps section.

Report titles should be properly formated

QA Steps

Before running tests ensure your account has access to BETA functionality useCustomReportNamesNewExpensify. To add yourself to the beta, please follow the pre-testing steps as described in this document.

The report titles should not flicker in any case. By flicker I mean that you can see the report title change value 2 times on any of described action.

Test Case 1 – All Report Fields Combined

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
{report:type} - {report:total} from {report:policyname} on {report:startdate}
Save the formula
Create new report via FAB
Add at least one expense transaction
Verify title shows:
Custom Expense Report - USD$X.XX from [WorkspaceName] on [StartDate]

Test Case 2 – Date Fields Comparison

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
Created {report:created} vs Started {report:startdate}
Save the formula
Create new report via FAB
Add expense transaction with different date than report creation
Verify title shows both creation date and start date correctly

Test Case 3 – Currency and Total Display

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
{report:currency} {report:total} report
Save the formula
Create new report via FAB
Add expense transaction with amount
Verify title shows: [Currency] [Amount] report

Test Case 4 – Substring Function

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
ID: {report:type|substr:0:3}-{report:total|substr:1:4}
Save the formula
Create new report via FAB
Add expense transaction with amount
Verify title shows truncated type and amount (e.g., ID: Exp-23.5)

Test Case 5 – Transaction Addition Impact

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
Total: {report:total} Start: {report:startdate}
Save the formula
Create new report via FAB
Add first expense transaction (note the title)
Add second expense transaction with different date
Verify title updates total amount and possibly start date

Test Case 6 – Policy Name Change Impact

Go to Workspaces
Select a workspace you admin
Go to Reports section
Edit Default report title with:
Report from {report:policyname}
Save the formula
Create new report via FAB
Note the current report title
Go to Workspace settings
Change workspace name
Return to reports and verify existing report titles updated with the new workspace name

Test case 7 - Transactions

Sign in with an account on OldDot
Open the JS console and enter this to enable the backend beta SSetNameValuePair('useCustomReportNamesNewExpensify', 'true');
Got to Workspaces, select your workspace and go to Reports subpage
Edit Default report title to Report from {report:startdate}
Create new report and add two transactions
a. first with date 2025-08-16
b. second with date 2025-08-17
Check if report's name is equal to Report from 2025-08-16
Go to Account -> Troubleshoot and enable Force offline option
Go back to newly created report
Edit second transaction's date to 2025-08-14
Check if report's name is equal to Report from 2025-08-14
Turn back transaction's date to 2025-08-17
Check if report's name is equal to Report from 2025-08-16
Add new transaction with date 2025-08-05
Check if report's name is equal to Report from 2025-08-05

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Nagranie.z.ekranu.2025-08-11.o.15.24.45.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-08-11.o.15.08.40.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-08-11.o.15.19.39.mov

This PR combines the functionality from three previously reverted PRs: - Expensify#65862: Initial optimistic Custom Report Names implementation - Expensify#68726: Fix for reassure performance tests - Expensify#68737: Extended transaction support for report name computation ### Key Features: - Real-time, formula-based report titles that update as expense data changes - Support for report fields: type, startdate, total, currency, policyname, created - Functions: frontpart, substr, domain for string manipulation - Optimistic updates work offline and provide visible changes without network - Transaction updates trigger report name recalculation - Performance optimized with caching and targeted updates - Beta flag controlled: authAutoReportTitle ### Implementation Details: - Formula.ts: Formula parsing and computation engine - OptimisticReportNames.ts: Main logic for report name updates - OptimisticReportNamesConnectionManager.ts: Onyx data context manager - Enhanced API middleware to process optimistic data - Performance and unit tests included 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2025-08-26T11:18:31Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

sosek108 · 2025-08-28T11:50:59Z

Test is failing, but this comes from main.

Test failing: IOURequestEditReportCommon › RBR › should not show DotIndicator when the report has brickRoadIndicator.
Test was mentioned on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1756286581236359

github-actions · 2025-08-28T13:46:38Z

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-28T14:17:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69147.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69147/index.html	⏩ SKIPPED ⏩
	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

…bined-optimistic-report-names

This is necessary to make use of explit betas.

github-actions · 2025-09-02T15:29:46Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-02T15:29:58Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-02T16:02:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69147.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69147/index.html	⏩ SKIPPED ⏩
	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2025-09-02T16:02:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69147.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69147/index.html	⏩ SKIPPED ⏩
	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

because of unexpected logoff

sosek108

@neil-marcellini I've applied changes according to your comments

src/libs/OptimisticReportNames.ts

src/libs/OptimisticReportNamesConnectionManager.ts

src/libs/API/index.ts

neil-marcellini

Good to go from me. Thanks!

neil-marcellini · 2025-09-09T17:31:30Z

src/libs/OptimisticReportNames.ts

+/**
+ * Extract transaction ID from an Onyx key
+ */
+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- this will be used in near future


NAB: can be done in a follow-up. We can remove this ESLint disable comment because we use this function now.

neil-marcellini · 2025-09-09T17:32:08Z

src/libs/OptimisticReportNames.ts

+}
+
+/**
+ * Get all reports associated with a policy ID


NAB: can be done in a follow up. Please update the comment to make it accurate.

neil-marcellini · 2025-09-09T17:37:44Z

@sosek108 I updated the description with a link to a document that describes how to set up the beta. @akinwale would you please do a C+ review now? If you find any bugs, please report them here, but they also don't need to be blockers as this is under a beta. You should request changes if you see a problem that would affect users outside the beta or if there's some really bad code I missed.

akinwale · 2025-09-10T18:52:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

69147-web-1.mp4

69147-web-2.mp4

MacOS: Desktop

akinwale

LGTM.

OSBotify · 2025-09-10T22:08:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-10T23:29:14Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-09-10T23:37:22Z

@neil-marcellini @trjExpensify Can we use Expensifail account for this PR? Would it be automatically added to BETA?

sosek108 · 2025-09-11T07:53:36Z

@mvtglobally it should be not automatically turned on on Expensifail accounts as there is check if the beta here is explicitly enabled.

It'd be great to check that though

OSBotify · 2025-09-11T11:10:33Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mvtglobally · 2025-09-11T14:36:25Z

@sosek108
thanks for the clarification.
When we run the Pre-testing steps on Web, Can we use the same account on Hybrid app or MWeb and logic will apply or this PR is only executable in the same browser/session where Console changes were applied?

sosek108 · 2025-09-11T17:14:29Z

@mvtglobally these changes are applied to the account, so you'd need different account to test this with / without beta flag

neil-marcellini · 2025-09-11T17:48:38Z

Yes to be extra clear, once it's applied to the account it can be in any browser session or device.

neil-marcellini · 2025-09-11T18:00:28Z

@mvtglobally I recently learned that the beta updates are only sent to app when a user signs in, and not automatically, at least using this beta which is somewhat "special". If you follow the pre-testing steps exactly in the document, setting the beta on OldDot, then signing in on NewDot, it should work as desired.

I will also create an issue to immediately send updates for the beta so that we have more control moving forward.

neil-marcellini · 2025-09-11T22:42:41Z

Immediately send Onyx update for new betas

OSBotify · 2025-09-12T00:16:07Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned sosek108 Aug 25, 2025

sosek108 added 4 commits August 25, 2025 13:16

fixes

f39ed5e

formulatest reintroduction

c85dfa8

Merge branch 'main' into feat/combined-optimistic-report-names

117a693

formulatest reintroduction

eddaf3b

jasperhuangg added the Ready To Build label Aug 26, 2025

This comment has been minimized.

Sign in to view

This was referenced Aug 27, 2025

[Tracking] Optimistic report title formula computation #59689

Closed

[Due for payment 2025-09-19] [$250] Optimistic report name computation causing unexpected log out? #69175

Closed

sosek108 added 3 commits August 28, 2025 13:15

Revert Mobile-Expensify submodule update from eddaf3b

38ea7c7

Merge branch 'main' into feat/combined-optimistic-report-names

88bfd79

Changes to the implementation

be49678

sosek108 mentioned this pull request Aug 29, 2025

[$250] 69038 - PR68737 - Report title is not update offline #69186

Closed

8 tasks

sosek108 added 3 commits September 1, 2025 12:30

Merge branch 'main' into feat/combined-optimistic-report-names

36279fe

Merge remote-tracking branch 'exfy/neil-explicit-betas' into feat/com…

ecdf717

…bined-optimistic-report-names

Introduce beta configuration into optimistic report name computation.

809a1ae

This is necessary to make use of explit betas.

sosek108 mentioned this pull request Sep 1, 2025

[OLD] Title field in report NVP for optimistic report names computation #69605

Closed

51 tasks

sosek108 added 2 commits September 2, 2025 10:00

Merge branch 'main' into feat/combined-optimistic-report-names

7b3055f

Merge branch 'main' into feat/combined-optimistic-report-names

6079f50

sosek108 added 2 commits September 5, 2025 15:40

Merge branch 'main' into feat/combined-optimistic-report-names

c359d70

Remove Timing / Performance from OptimisticReportNames entry point

a8c6324

because of unexpected logoff

sosek108 dismissed trjExpensify’s stale review via 1a97d27 September 9, 2025 10:47

sosek108 commented Sep 9, 2025

View reviewed changes

sosek108 added 2 commits September 9, 2025 13:03

remove unintended changes

efa8973

remove unintended changes

4267e54

sosek108 requested a review from neil-marcellini September 9, 2025 11:22

neil-marcellini approved these changes Sep 9, 2025

View reviewed changes

neil-marcellini mentioned this pull request Sep 9, 2025

[$250] Report name in preview doesn't update #70134

Closed

2 tasks

mohammadjafarinejad mentioned this pull request Sep 10, 2025

[HOLD til outta beta] Full story : Report title displays raw template formula instead of resolved values #70147

Closed

16 tasks

akinwale approved these changes Sep 10, 2025

View reviewed changes

melvin-bot bot requested a review from neil-marcellini September 10, 2025 18:53

akinwale approved these changes Sep 10, 2025

View reviewed changes

neil-marcellini merged commit b7cd111 into Expensify:main Sep 10, 2025
23 of 26 checks passed

OSBotify mentioned this pull request Sep 10, 2025

Deploy Checklist: New Expensify 2025-09-10 #70325

Closed

jponikarchuk mentioned this pull request Sep 12, 2025

Web - Reports - Reports - Report title total not updating immediately after adding expense #70465

Closed

8 tasks

lanitochka17 mentioned this pull request Sep 12, 2025

[$250] Incorrect report start date reflects in report title, date displays previous day #70474

Closed

16 tasks

mohammadjafarinejad mentioned this pull request Sep 14, 2025

[Due for payment 2025-12-12] [$250] [ORTF] Currency formatting options #68965

Closed

NJ-2020 mentioned this pull request Sep 16, 2025

[HOLD 67823][$250] [ORTF] - report:created and report:startdate not optimistically computed #68803

Closed

16 tasks

Conversation

sosek108 commented Aug 25, 2025 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Key Features:

Implementation Details:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

This comment has been minimized.

sosek108 commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

sosek108 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Sep 9, 2025

Uh oh!

akinwale commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

mvtglobally commented Sep 10, 2025

Uh oh!

sosek108 commented Sep 11, 2025

Uh oh!

OSBotify commented Sep 11, 2025

Uh oh!

mvtglobally commented Sep 11, 2025

Uh oh!

sosek108 commented Sep 11, 2025

Uh oh!

neil-marcellini commented Sep 11, 2025

Uh oh!

neil-marcellini commented Sep 11, 2025

Uh oh!

neil-marcellini commented Sep 11, 2025

Uh oh!

sosek108 commented Aug 25, 2025 •

edited by neil-marcellini

Loading

akinwale commented Sep 10, 2025 •

edited

Loading