-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: hovering over the new user avatar does not display email #69219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-08-26.at.11.08.19.PM.movAndroid: mWeb ChromeScreen.Recording.2025-08-26.at.11.06.23.PM.moviOS: HybridAppScreen.Recording.2025-08-26.at.11.01.51.PM.moviOS: mWeb SafariScreen.Recording.2025-08-26.at.10.58.49.PM.movMacOS: Chrome / SafariScreen.Recording.2025-08-26.at.10.57.28.PM.movMacOS: DesktopScreen.Recording.2025-08-26.at.10.56.35.PM.mov |
eh2077
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.0-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀
|
Explanation of Change
Fixed Issues
$ #68687
PROPOSAL: #68687 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_2025-08-26_at_16.34.47.mov
Android: mWeb Chrome
am.mov
iOS: Native
Screen_Recording_2025-08-26_at_16.34.47.mov
iOS: mWeb Safari
im.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
d.mov