Fix - Expense - Paying the expense removed the amount violation, but it re-appeared later #69291

FitseTLT · 2025-08-26T19:12:34Z

Details

Fixed Issues

$ #67328
PROPOSAL: #67328 (comment)

Tests

Launch app
Create a Workspace
Tap overview - change plan to control
Go to workspace chat
Create a manual expense with 8 digit number which shows violation for amount
Submit, approve and pay elsewhere via top dropdown
Verify paying the expense will remove RBR from the LHN and report preview and transaction item from the transaction list but the violation will be seen on the details transaction view.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-26T19:12:40Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2025-08-28T15:13:09Z

Overall the change set lood good, i'll update checklist soon. @FitseTLT could you please resolve the conflict?

FitseTLT · 2025-08-28T15:22:11Z

done

suneox · 2025-08-31T09:23:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-31.at.16.15.23.mp4

Android: mWeb Chrome

Screen.Recording.2025-08-31.at.16.17.57.mp4

iOS: HybridApp

Screen.Recording.2025-08-31.at.16.19.58.mp4

iOS: mWeb Safari

Screen.Recording.2025-08-31.at.16.21.10.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-08-31.at.16.11.20.mp4

MacOS: Desktop

Screen.Recording.2025-08-31.at.16.14.03.mp4

suneox · 2025-08-31T09:24:59Z

@FitseTLT Could you please fix the ESLint and typecheck issues? We may also need to merge with the latest main branch to resolve the flaky tests.

FitseTLT · 2025-09-01T14:41:11Z

@FitseTLT Could you please fix the ESLint and typecheck issues? We may also need to merge with the latest main branch to resolve the flaky tests.

Still failing

FitseTLT · 2025-09-02T12:51:54Z

@suneox Tests passed

suneox · 2025-09-02T14:28:49Z

@suneox Tests passed

@FitseTLT Great! However, there’s a new conflict — could you please resolve it?

FitseTLT · 2025-09-02T19:13:15Z

Resolved

trjExpensify · 2025-09-03T14:47:33Z

@JmillsExpensify is assigned on the parent issue, leaving this to you.

github-actions · 2025-09-04T03:22:17Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

mollfpr

All yours @JmillsExpensify

FitseTLT · 2025-09-12T17:17:09Z

bump @JmillsExpensify

FitseTLT · 2025-09-23T12:20:15Z

@mollfpr @JmillsExpensify we are stuck here for more than two weeks now.

codecov · 2025-09-25T22:21:51Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/TransactionItemRow/index.tsx	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

FitseTLT · 2025-09-25T22:30:50Z

@trjExpensify Updated according to your suggestion here
REsult:

2025-09-26.01-29-07.mp4

github-actions · 2025-09-30T02:15:52Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-09-30T02:49:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69291.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69291/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69291/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69291/NewExpensify.dmg	https://69291.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

JmillsExpensify

Everything looks good and is in line with the product behavior discussed internally here: https://expensify.slack.com/archives/C01GTK53T8Q/p1758755795727589?thread_ts=1758723368.658059&cid=C01GTK53T8Q

JmillsExpensify · 2025-09-30T11:00:56Z

@mollfpr all yours

OSBotify · 2025-10-02T11:20:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-03T17:56:06Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.2.23-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-10-04T13:57:47Z

Failing with original KI on all platforms
https://platform.applause.com/services/links/v1/external/3240b1d8642f75bcf8b41235f5700a5625ea93547ade940e75b68c342de4e557
https://platform.applause.com/services/links/v1/external/f89b3cab7081de01834b3ea6c25a9679634373836c7e9b3262939e191882ff76
https://platform.applause.com/services/links/v1/external/bcb67afdc2a6cc6cc369ac5650bb4114daa0e5617177d6067f44d2a44a26a1c3
https://platform.applause.com/services/links/v1/external/33cff95d88368bdf46133f9addbd265cd4b12bca3a3f30aba925291c2c18e01d
https://platform.applause.com/services/links/v1/external/3fd2cb6ec9a705150eb5c7ed0b8374d1b02185585d5fcbb2c9e670d59bd8cd8f

suneox · 2025-10-06T06:51:18Z

It looks like the backend has been updated. Since last month, it has still worked on the checklist. @FitseTLT, could you please double-check this one?

FitseTLT · 2025-10-06T15:01:08Z

Failing with original KI on all platforms https://platform.applause.com/services/links/v1/external/3240b1d8642f75bcf8b41235f5700a5625ea93547ade940e75b68c342de4e557 https://platform.applause.com/services/links/v1/external/f89b3cab7081de01834b3ea6c25a9679634373836c7e9b3262939e191882ff76 https://platform.applause.com/services/links/v1/external/bcb67afdc2a6cc6cc369ac5650bb4114daa0e5617177d6067f44d2a44a26a1c3 https://platform.applause.com/services/links/v1/external/33cff95d88368bdf46133f9addbd265cd4b12bca3a3f30aba925291c2c18e01d https://platform.applause.com/services/links/v1/external/3fd2cb6ec9a705150eb5c7ed0b8374d1b02185585d5fcbb2c9e670d59bd8cd8f

@m-natarajan Very sorry, I forgot to update the steps after we changed the expected behavior. The violation will still be shown on the details transaction view. The RBR only need to be removed from other places as the LHN, report preview or transaction item from the transaction list. I have now updated the step. Thx.

IuliiaHerets · 2025-10-06T18:01:53Z

PR is passed on Web, mWeb/Chrome and Android app, but only in case we set limits manually, to be able to test if the violation disappeared after paying the expense

screen-20251006-135204.mp4

screen-20251006-134628.mp4

bandicam.2025-10-06.20-19-55-077.mp4

OSBotify · 2025-10-06T19:48:54Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hide violations for settled reports

812b134

FitseTLT requested a review from a team as a code owner August 26, 2025 19:12

melvin-bot bot assigned FitseTLT Aug 26, 2025

melvin-bot bot requested review from suneox and removed request for a team August 26, 2025 19:12

Merge branch 'main' into fix-showing-rbr-for-settled-report

6ade374

Merge branch 'main' into fix-showing-rbr-for-settled-report

5412649

FitseTLT requested a review from a team as a code owner September 1, 2025 14:25

Merge branch 'main' into fix-showing-rbr-for-settled-report

e15455c

FitseTLT added 2 commits September 2, 2025 22:06

Merge branch 'main' into fix-showing-rbr-for-settled-report

53dac16

add isSettled prop

b533282

suneox approved these changes Sep 3, 2025

View reviewed changes

melvin-bot bot requested a review from mollfpr September 3, 2025 09:24

mollfpr added the Ready To Build label Sep 4, 2025

This comment has been minimized.

Sign in to view

mollfpr previously approved these changes Sep 9, 2025

View reviewed changes

FitseTLT added 2 commits September 12, 2025 20:11

Merge branch 'main' into fix-showing-rbr-for-settled-report

306a77f

Merge branch 'main' into fix-showing-rbr-for-settled-report

485b212

FitseTLT dismissed mollfpr’s stale review via 485b212 September 12, 2025 17:14

Merge branch 'main' into fix-showing-rbr-for-settled-report

57a885a

revert unnecessary change

8457da8

JmillsExpensify approved these changes Sep 30, 2025

View reviewed changes

mollfpr approved these changes Oct 2, 2025

View reviewed changes

mollfpr merged commit 8f1f87a into Expensify:main Oct 2, 2025
21 checks passed

OSBotify mentioned this pull request Oct 3, 2025

Deploy Checklist: New Expensify 2025-10-03 #71822

Closed

58 tasks

melvin-bot bot mentioned this pull request Oct 6, 2025

[Due for payment 2025-10-13] [$250] Expense - Paying the expense removed the amount violation, but it re-appeared later #67328

Closed

16 tasks

Fix - Expense - Paying the expense removed the amount violation, but it re-appeared later #69291

Fix - Expense - Paying the expense removed the amount violation, but it re-appeared later #69291

Uh oh!

Conversation

FitseTLT commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 26, 2025

Uh oh!

suneox commented Aug 28, 2025

Uh oh!

FitseTLT commented Aug 28, 2025

Uh oh!

suneox commented Aug 31, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox commented Aug 31, 2025

Uh oh!

FitseTLT commented Sep 1, 2025

Uh oh!

FitseTLT commented Sep 2, 2025

Uh oh!

suneox commented Sep 2, 2025

Uh oh!

FitseTLT commented Sep 2, 2025

Uh oh!

trjExpensify commented Sep 3, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

This comment has been minimized.

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Sep 12, 2025

Uh oh!

FitseTLT commented Sep 23, 2025

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

FitseTLT commented Sep 25, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Sep 30, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

OSBotify commented Oct 3, 2025

Uh oh!

m-natarajan commented Oct 4, 2025

Uh oh!

suneox commented Oct 6, 2025

Uh oh!

FitseTLT commented Oct 6, 2025

Uh oh!

IuliiaHerets commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

FitseTLT commented Aug 26, 2025 •

edited

Loading

codecov bot commented Sep 25, 2025 •

edited

Loading