[CP Staging] Hover Preview - follow ups #69337

borys3kk · 2025-08-27T08:40:35Z

Explanation of Change

Added isAuthTokenRequired to distanceEReceipt to resolve 403 error
Added display name for receiptPreview
Added explanation for eReceiptWithSizeCalculation props and a new one to handle displaying in receiptPreview

Fixed Issues

$ #69240
$ #69279
PROPOSAL:

Tests

WEB / DESKTOP

Open reports tab
Go to staging.new.expensify.com
Create a workspace.
Go to Reports > Expenses.
Open FAB > Create expense > Distance.
Submit a distance expense to the workspace chat.
Immediately hover over the receipt thumbnail on the expense row after submitting the distance expense.
The distanceEReceipt should be displayed like the one below (no 403 error should be displayed in the map)

Android, IOS:
The e-Receipt preview is misaligned test steps:
Prerequisite: Have an account with eReceipt or follow below steps:
To get an expense with eReceipt:

Open the HybridApp
Enable company cards in the workspace
Navigate to company cards in the workspace settings
Tap add cards
Choose United States -> Direct Feed -> American Express
Complete the flow with credentials from "American Express - Work - Direct Feed" from 1Password
Select the 2 available cards and complete the flow
Tap Assign Card and complete assigning a card

Steps

Open the HybridApp
Go to Reports and find the expense with eReceipt
Try to open the expense with the eReceipt
Verify that eReceipt thumbnail in the preview is centered and zoomed in

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

e-Receipt preview is not misaligned anymore

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-08-29.at.11.03.53.mov

Screen.Recording.2025-08-28.at.10.38.47.mov

MacOS: Desktop

github-actions · 2025-08-28T08:06:00Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-08-28T08:36:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69337.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69337/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69337/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69337/NewExpensify.dmg	https://69337.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

borys3kk · 2025-08-28T08:39:54Z

Tested on adhoc and couldn't reproduce 403 error anymore
Earlier today I've tested if the eReceipt preview is still misaligned in App on Android device and it showed how it was supposed to so I think it was also resolved

Screen.Recording.2025-08-28.at.10.38.47.mov

borys3kk · 2025-08-28T08:45:07Z

Additionaly the failing test in this PR is random
On the first try it failed but on the second it went through without problems :D

Screen.Recording.2025-08-28.at.10.44.25.mov

mountiny · 2025-08-28T18:13:52Z

@borys3kk ok thanks can you make this PR ready for a review so we can merge the fix?

mountiny · 2025-08-28T18:16:12Z

@allroundexperts Can you please test the PR for the 403 error?

src/components/EReceiptWithSizeCalculation.tsx

melvin-bot · 2025-08-29T09:08:53Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-08-29T10:59:05Z

Asked @allroundexperts for review

allroundexperts · 2025-08-29T17:44:47Z

@mountiny Asked you a question here

allroundexperts · 2025-08-29T20:52:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-08-30.at.1.29.15.AM.mov

iOS: HybridApp

Screen.Recording.2025-08-30.at.1.22.46.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-08-30.at.12.47.18.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-30.at.12.41.02.AM.mov

MacOS: Desktop

Screen.Recording.2025-08-30.at.12.44.53.AM.mov

allroundexperts · 2025-08-29T20:56:35Z

One observation (not sure if its a blocker or not)

Distance receipt which has not loaded yet shows an empty modal.

allroundexperts

Single comment. Looks good otherwise.

trjExpensify

Yeah, I'd think if you hover over an empty state thumbnail we don't open the popover. CC: @Expensify/design for vis too.

borys3kk · 2025-08-31T10:06:47Z

I'd just like to point out that when there's no thumbnail, it means there's no preview shown on hover
In the case of distanceEReceipt, an empty hover briefly appears just before the eReceipt is generated

dubielzyk-expensify · 2025-09-01T01:26:52Z

Yeah, I'd think if you hover over an empty state thumbnail we don't open the popover.

Agree 👍

JmillsExpensify · 2025-09-01T09:35:41Z

Also agree on no popover on an empty state.

borys3kk · 2025-09-01T12:20:27Z

To clear things up
When hovering over expense without any thumbnail / image no preview is shown
On my dev env when hovering over newly created distance request the eReceipt with map 'loading' state is shown and after map loads in it shows as it's supposed to do

Screen.Recording.2025-09-01.at.14.14.22.mov

You can see it on the recording above

Does it look different in your dev env @allroundexperts
If so can you provide repro steps?

trjExpensify · 2025-09-01T15:15:59Z

Interesting yeah, it'll be good to get repro steps from @allroundexperts, because the blank popover doesn't look great.

mountiny

From my understanding this should fix more things than the empty preview issue that is being discussed and other than @allroundexperts we could not reproduce so I will move this PR ahead but @allroundexperts please share your reproduction steps if you can still reproduce the blank preview issue

OSBotify · 2025-09-01T21:56:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…-error Hover Preview - follow ups (cherry picked from commit 06cc002) (cherry-picked to staging by mountiny)

OSBotify · 2025-09-02T14:41:25Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.0-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-02T18:55:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.0-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-02T22:19:48Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T22:47:52Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-02T23:13:01Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-05T19:34:51Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add isAuthTokenRequired for distanceEReceipts

41382b2

melvin-bot bot assigned borys3kk Aug 27, 2025

borys3kk added 2 commits August 27, 2025 11:16

fix eReceipt preview misaligned

a6a6a71

update name for future reference

19c4e46

borys3kk changed the title ~~Expense - Map shows 403 error in the receipt when hovered~~ Hover Preview - follow ups Aug 27, 2025

add display name

734a4e9

borys3kk mentioned this pull request Aug 27, 2025

Hover-to-view for receipt thumbnails v2 #68276

Merged

51 tasks

update main

8c5a33f

mountiny requested a review from allroundexperts August 28, 2025 08:05

blazejkustra suggested changes Aug 29, 2025

View reviewed changes

src/components/EReceiptWithSizeCalculation.tsx Show resolved Hide resolved

src/components/EReceiptWithSizeCalculation.tsx Show resolved Hide resolved

fix jsdoc

2a74866

borys3kk force-pushed the borys3kk-fix-403-error branch from 5a3163a to 2a74866 Compare August 29, 2025 08:56

blazejkustra approved these changes Aug 29, 2025

View reviewed changes

borys3kk marked this pull request as ready for review August 29, 2025 09:08

borys3kk requested review from a team as code owners August 29, 2025 09:08

melvin-bot bot requested a review from mountiny August 29, 2025 09:08

melvin-bot bot removed the request for review from a team August 29, 2025 09:08

allroundexperts approved these changes Aug 29, 2025

View reviewed changes

trjExpensify reviewed Aug 30, 2025

View reviewed changes

mountiny approved these changes Sep 1, 2025

View reviewed changes

mountiny merged commit 06cc002 into Expensify:main Sep 1, 2025
28 of 32 checks passed

mountiny mentioned this pull request Sep 1, 2025

Better RHP view v2 - Extract MoneyRequestReceiptView #69533

Merged

51 tasks

mountiny changed the title ~~Hover Preview - follow ups~~ [CP Staging] Hover Preview - follow ups Sep 2, 2025

OSBotify pushed a commit that referenced this pull request Sep 2, 2025

Merge pull request #69337 from software-mansion-labs/borys3kk-fix-403…

1c2e5c0

…-error Hover Preview - follow ups (cherry picked from commit 06cc002) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 2, 2025

OSBotify mentioned this pull request Sep 2, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

jponikarchuk mentioned this pull request Sep 2, 2025

[Due for payment 2025-09-26] [$250] Reports- Hover preview shows blank preview when distance expense is created on Reports offline #69670

Closed

8 tasks

This was referenced Sep 2, 2025

[Due for payment 2025-09-09] Expense - Map shows 403 error in the receipt when hovered #69240

Closed

[Due for payment 2025-09-09] Android - Expense - e-Receipt preview is misaligned #69279

Closed

[CP Staging] Hover Preview - follow ups #69337

[CP Staging] Hover Preview - follow ups #69337

Uh oh!

Conversation

borys3kk commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

borys3kk commented Aug 28, 2025

Uh oh!

borys3kk commented Aug 28, 2025

Uh oh!

mountiny commented Aug 28, 2025

Uh oh!

mountiny commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Aug 29, 2025

Uh oh!

mountiny commented Aug 29, 2025

Uh oh!

allroundexperts commented Aug 29, 2025

Uh oh!

allroundexperts commented Aug 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

borys3kk commented Aug 31, 2025

Uh oh!

dubielzyk-expensify commented Sep 1, 2025

Uh oh!

JmillsExpensify commented Sep 1, 2025

Uh oh!

borys3kk commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Sep 1, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 1, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

borys3kk commented Aug 27, 2025 •

edited

Loading

allroundexperts commented Aug 29, 2025 •

edited

Loading

borys3kk commented Sep 1, 2025 •

edited

Loading