Skip to content

Removing accountID from Report_UpdateLastRead #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MonilBhavsar merged 3 commits into from
Jan 21, 2022
Merged

Removing accountID from Report_UpdateLastRead #6943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce3ab97
Removing accountID from Report_UpdateLastRead
chiragsalian Dec 29, 2021
fa75c49
Merge branch 'main' into chirag-removing-accountID-param
chiragsalian Jan 19, 2022
48c3769
Merge branch 'main' into chirag-removing-accountID-param
chiragsalian Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libs/API.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,14 +679,13 @@ function Report_EditComment(parameters) {

/**
* @param {Object} parameters
* @param {Number} parameters.accountID
* @param {Number} parameters.reportID
* @param {Number} parameters.sequenceNumber
* @returns {Promise}
*/
function Report_UpdateLastRead(parameters) {
const commandName = 'Report_UpdateLastRead';
requireParameters(['accountID', 'reportID', 'sequenceNumber'], parameters, commandName);
requireParameters(['reportID', 'sequenceNumber'], parameters, commandName);
return Network.post(commandName, parameters);
}

Expand Down
1 change: 0 additions & 1 deletion src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,6 @@ function updateLastReadActionID(reportID, sequenceNumber) {

// Mark the report as not having any unread items
API.Report_UpdateLastRead({
accountID: currentUserAccountID,
reportID,
sequenceNumber: lastReadSequenceNumber,
});
Expand Down