[CP Staging] Render description as text in the reports page #69451

youssef-lr · 2025-08-28T13:42:57Z

Explanation of Change

This PR will allow rendering the description as text if it's in HTML, to allow sorting, and truncating text, and also to not mess the row heights if it's multi line text/HTML. Users can still see the markdown version when opening the expense details.

Fixed Issues

$ #69405
$ #69402
$ #69403

Tests

Verify that no errors appear in the JS console

Verify that description with html is converted to text in the reports page.
Verify that it is truncated if it's too long.
Verify user mention looks like a plain email
Verify for IOUs with no merchant and the description containing only user mention, is shown as plain email.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Verify that description with html is converted to text in the reports page.
Verify that it is truncated if it's too long.
Verify user mention looks like a plain email
Verify for IOUs with no merchant and the description containing only user mention, is shown as plain email.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Uploading Screen Recording 2025-08-28 at 14.30.41.mov…

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-28T13:43:04Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-08-28T13:43:11Z

@rushatgabhane @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-08-28T14:04:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-08-28.at.9.31.35.PM.mov

iOS: HybridApp

Screen.Recording.2025-08-28.at.9.09.21.PM.mov

Screen.Recording.2025-08-28.at.9.07.48.PM.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-28.at.20.58.06.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-08-28.at.8.50.36.PM.mov

Screen.Recording.2025-08-28.at.8.32.00.PM.mov

MacOS: Desktop

Screen.Recording.2025-08-28.at.9.22.45.PM.mov

Screen.Recording.2025-08-28.at.9.22.06.PM.mov

ishpaul777 · 2025-08-28T14:09:22Z

Reports - Long expense description is not truncated #69402

this is still reproducible

ishpaul777 · 2025-08-28T14:10:30Z

@youssef-lr please 👀 on jest test failing

ishpaul777 · 2025-08-28T14:12:43Z

Expense - Expenses are not sorted after clicking on Description table header #69403

this one is also still reproducible

Screen.Recording.2025-08-28.at.7.41.40.PM.mov

grgia

@youssef-lr would you update the QA steps?

Also can you confirm this PR will not cause additional blockers?

youssef-lr · 2025-08-28T14:25:54Z

Also can you confirm this PR will not cause additional blockers?

Yeah this concerns only the reports table view where we never showed the description on its own before.

youssef-lr · 2025-08-28T14:31:32Z

I'm not really sure what to do with this one #69451 (comment). I'm thinking to only grab the first line of a multi line description for now.

ishpaul777 · 2025-08-28T14:42:17Z

src/components/TransactionItemRow/DataCells/MerchantCell.tsx

+    const text = useMemo(() => {
+        if (!isDescription) {
            return merchantOrDescription;
        }
-        return Parser.replace(merchantOrDescription, {shouldEscapeText: false});
-    }, [merchantOrDescription, shouldRenderAsHTML]);
+        return Parser.htmlToText(merchantOrDescription);
+    }, [merchantOrDescription, isDescription]);


const text = useMemo(() => { if (!isDescription) { return merchantOrDescription; } let value = Parser.htmlToText(merchantOrDescription) return value.replace(/\n/g, ' '); }, [merchantOrDescription, isDescription]);

Screen.Recording.2025-08-28.at.8.12.46.PM.mov

@youssef-lr should we replace \n with " " ?

nice one! yes I like that.

youssef-lr · 2025-08-28T14:51:26Z

Regarding the sorting by description in th report view. It looks tricky because in the report view we have access to raw transactions and not the ones from the Reports page that come from the Search API. They do not have "description", the description is in the comment.comment property. I think it's not a big deal to demote that issue and work on it separately. But I'll try to come up with something now if I can.

youssef-lr · 2025-08-28T15:09:49Z

ok fixed! please test again @ishpaul777

ishpaul777

lgtm!

melvin-bot · 2025-08-28T16:07:09Z

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-08-28T16:09:04Z

@youssef-lr can you please update the QA steps

youssef-lr · 2025-08-28T18:24:12Z

Done. cc @grgia

ishpaul777 · 2025-08-28T18:25:25Z

@youssef-lr we have conflicts

luacmartins

LGTM

OSBotify · 2025-08-28T20:12:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Render description as text in the reports page (cherry picked from commit f99598b) (cherry-picked to staging by thienlnam)

…310344268-4 🍒 Cherry pick PR #69451 to staging 🍒

OSBotify · 2025-08-29T01:05:48Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.0-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-08-29T01:50:55Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.0-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-02T22:20:12Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	failure ❌
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-02T22:49:07Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.2.1-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-02T23:13:25Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.0-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-05T19:35:48Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Render description as text in the reports page

84e8632

youssef-lr self-assigned this Aug 28, 2025

youssef-lr requested a review from a team as a code owner August 28, 2025 13:42

melvin-bot bot requested review from parasharrajat and removed request for a team August 28, 2025 13:43

youssef-lr requested review from a team and ishpaul777 and removed request for parasharrajat August 28, 2025 13:43

melvin-bot bot requested review from grgia and rushatgabhane and removed request for a team August 28, 2025 13:43

youssef-lr removed the request for review from rushatgabhane August 28, 2025 13:43

grgia reviewed Aug 28, 2025

View reviewed changes

youssef-lr added 2 commits August 28, 2025 15:29

Merge branch 'main' into youssef_fix_description_column

1f1ed5a

Allow sorting description in report view

312b3f0

Revert unneeded change

c1e5b95

ishpaul777 reviewed Aug 28, 2025

View reviewed changes

youssef-lr added 2 commits August 28, 2025 15:49

Fix multi line description and show them in one line

f1f65c8

Fix in progress: sort description

4d2e7b4

Allow sorting by desription

9812d4a

ishpaul777 approved these changes Aug 28, 2025

View reviewed changes

melvin-bot bot requested a review from Valforte August 28, 2025 16:07

youssef-lr removed the request for review from Valforte August 28, 2025 18:23

Merge branch 'main' into youssef_fix_description_column

2a651c1

luacmartins approved these changes Aug 28, 2025

View reviewed changes

luacmartins merged commit f99598b into main Aug 28, 2025
24 checks passed

luacmartins deleted the youssef_fix_description_column branch August 28, 2025 20:02

youssef-lr changed the title ~~Render description as text in the reports page~~ [CP Staging] Render description as text in the reports page Aug 28, 2025

os-botify bot mentioned this pull request Aug 29, 2025

🍒 Cherry pick PR #69451 to staging 🍒 #69516

Merged

49 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 29, 2025

thienlnam pushed a commit that referenced this pull request Aug 29, 2025

Merge pull request #69451 from Expensify/youssef_fix_description_column

5e67c52

Render description as text in the reports page (cherry picked from commit f99598b) (cherry-picked to staging by thienlnam)

thienlnam added a commit that referenced this pull request Aug 29, 2025

Merge pull request #69516 from Expensify/cherry-pick-staging-69451-17…

a9034b1

…310344268-4 🍒 Cherry pick PR #69451 to staging 🍒

OSBotify mentioned this pull request Aug 29, 2025

Deploy Checklist: New Expensify 2025-08-28 #69401

Closed

70 tasks

Pujan92 mentioned this pull request Aug 30, 2025

[$250] Text in description col is rendered without markdown at Report page #68344

Closed

8 tasks

[CP Staging] Render description as text in the reports page #69451

[CP Staging] Render description as text in the reports page #69451

Uh oh!

Conversation

youssef-lr commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Aug 28, 2025

Uh oh!

melvin-bot bot commented Aug 28, 2025

Uh oh!

ishpaul777 commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Aug 28, 2025

Reports - Long expense description is not truncated #69402

Uh oh!

ishpaul777 commented Aug 28, 2025

Uh oh!

ishpaul777 commented Aug 28, 2025

Expense - Expenses are not sorted after clicking on Description table header #69403

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Aug 28, 2025

Uh oh!

youssef-lr commented Aug 28, 2025

Uh oh!

ishpaul777 Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youssef-lr Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Aug 28, 2025

Uh oh!

youssef-lr commented Aug 28, 2025

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Aug 28, 2025

Uh oh!

ishpaul777 commented Aug 28, 2025

Uh oh!

youssef-lr commented Aug 28, 2025

Uh oh!

ishpaul777 commented Aug 28, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Aug 28, 2025

Uh oh!

OSBotify commented Aug 29, 2025

Uh oh!

OSBotify commented Aug 29, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 2, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

youssef-lr commented Aug 28, 2025 •

edited

Loading

ishpaul777 commented Aug 28, 2025 •

edited

Loading

ishpaul777 Aug 28, 2025 •

edited

Loading