-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore(63871): update react-native-pdf to 6.7.7 #69600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
1647c1d to
93e9c21
Compare
93e9c21 to
475958c
Compare
ff9ba50 to
944c8ed
Compare
|
This one also seems to be passing. Wondering if you would have a minute to review it alongside the other two, @jayeshmangwani |
|
Yes, I’m on it. I checked the rnmapbox/maps PR , it worked well. Now I’m working on this one, and then I’ll move on to the onfido-sdk PR. |
|
Refactor PR, doesn’t have any new product considerations. Removing the tag and unsubscribing myself. |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb Chromemweb-chrome.moviOS: HybridAppiOS.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.2-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.2-8 🚀
|
Explanation of Change
Update react-native-pdf version and apply a new patch to enable 16Kb memory pages (
align=0x4000), which is required for Android 15+ compatibility.armeabi-v7alibs remain at 4 KB alignment, which is expected since Android 15+ devices no longer run 32-bit code.MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13661
Fixed Issues
$ #63871
PROPOSAL: #63871
Tests
llvm-readelf -lon allarm64-v8a.so files and confirmedp_align=0x4000(16 KB) for each.zipalign -c -P 16.scripts/check-16kb-android.shwith the path to the APK to check all alignments in the bundle.Offline tests
QA Steps
Same as tests:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop