-
Notifications
You must be signed in to change notification settings - Fork 3.5k
chore(63871): update react-native-blob-util and expo-image #69649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
@Kureev expo-image fails to run on iOS. |
|
@jayeshmangwani when you teseted this, are you sure you pulled the correct submodule? https://github.com/Expensify/Mobile-Expensify/pull/13661 |
|
@Kureev I tried this on a standalone app (not a hybrid app), so I’m not sure if it’s a submodule issue. |
|
@Kureev, please let me know if I need to do any additional setup to test this on iOS. I’ve pulled the PR, ran |
|
yeah, I'm currently figuring this one out. Will keep you posted! |
3175cb5 to
077de80
Compare
|
fixed the build, @jayeshmangwani |
|
oh, seems there are some patches for the outdated versions of the expo packages. Will fix in a few mins |
|
tests seems to be flaky, locally they pass without issues. will rebase on top of latest main and trigger them again |
49faea3 to
e45240e
Compare
|
some tests are failing, but I'm sure it is not related to this PR. Likely, someone updated the typescript version somewhere in the main branch |
e45240e to
f2f1285
Compare
|
@jayeshmangwani I think it is ready for review now. Should be all good with the builds |
|
Cool, I’m on the review now. |
|
@Kureev tsc is failing |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.mp4Android: mWeb Chromemweb-chrome.moviOS: HybridAppiOS.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
@Kureev typecheck is failing on this PR only because of the line |
f2f1285 to
1e5a547
Compare
|
@jayeshmangwani rebased on top of the main, let's keep an eye on the tests, hopefully everything pass now |
|
@Kureev This issue might be due to the updated expo-image version, since it’s only failing on our PR. You can verify by running |
b41bd39 to
c79e654
Compare
|
Okay, it seems the problem was in the |
|
@Kureev , I don’t think we want to commit the Mobile-Expensify changes in this PR. |
|
ah right, probably slipped in one of the merges. Let me fix this real quick |
|
@jayeshmangwani reverted submodule to the current |
jayeshmangwani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR works well, lgtm 🚀
|
Do we have a Mobile-Expensify counterpart for this PR? |
|
@roryabraham not this one |
|
Reassure is failing everywhere, going to ignore it for now. slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1757971409580299?thread_ts=1757006279.943369&cid=C01GTK53T8Q |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.15-0 🚀
|
|
The TSConfig changes made to |
see #69649 (comment) |
[CP Staging] Revert "Merge pull request #69649 from margelo/kureev/63871-part4"
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.2.15-15 🚀
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|



Explanation of Change
Update react-native-blob-util and expo-image versions to enable 16Kb memory pages (
align=0x4000), which is required for Android 15+ compatibility.armeabi-v7alibs remain at 4 KB alignment, which is expected since Android 15+ devices no longer run 32-bit code.MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13661
Fixed Issues
$ #63871
PROPOSAL: #63871
Tests
llvm-readelf -lon allarm64-v8a.so files and confirmedp_align=0x4000(16 KB) for each.zipalign -c -P 16.scripts/check-16kb-android.shwith the path to the APK to check all alignments in the bundle.Offline tests
QA Steps
Same as tests:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop