Skip to content

Conversation

@Kureev
Copy link
Contributor

@Kureev Kureev commented Sep 2, 2025

Explanation of Change

Update react-native-blob-util and expo-image versions to enable 16Kb memory pages (align=0x4000), which is required for Android 15+ compatibility.
armeabi-v7a libs remain at 4 KB alignment, which is expected since Android 15+ devices no longer run 32-bit code.

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13661

Fixed Issues

$ #63871
PROPOSAL: #63871

Tests

  1. Ran llvm-readelf -l on all arm64-v8a .so files and confirmed p_align=0x4000 (16 KB) for each.
  2. Verified that the APK/AAB passes zipalign -c -P 16.
  3. Alternatively, run scripts/check-16kb-android.sh with the path to the APK to check all alignments in the bundle.
  4. Installed the app on an Android 15 emulator and verified that it launches and runs without native crashes.
  5. Confirmed no regressions in core flows (sign-in, navigation, chat, attachments).
  • Verify that no errors appear in the JS console

Offline tests

  1. Tested launching the app with airplane mode enabled → verified it falls back gracefully (no native crashes).
  2. Spotty connection simulation → verified chat messages queue and sync after reconnection.

QA Steps

Same as tests:

  1. Confirm that the app installs and runs on Android 15 devices without native crashes.
  2. Confirm normal behavior in core flows (login, messaging, navigation).
  3. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@Kureev Kureev requested a review from a team as a code owner September 2, 2025 12:43
@melvin-bot melvin-bot bot requested review from jayeshmangwani and removed request for a team September 2, 2025 12:43
@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2025

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@jayeshmangwani
Copy link
Contributor

@Kureev expo-image fails to run on iOS.
Screenshot 2025-09-03 at 8 13 31 PM

@Kureev
Copy link
Contributor Author

Kureev commented Sep 3, 2025

@jayeshmangwani when you teseted this, are you sure you pulled the correct submodule? https://github.com/Expensify/Mobile-Expensify/pull/13661

@jayeshmangwani
Copy link
Contributor

@Kureev I tried this on a standalone app (not a hybrid app), so I’m not sure if it’s a submodule issue.

@jayeshmangwani
Copy link
Contributor

@Kureev, please let me know if I need to do any additional setup to test this on iOS. I’ve pulled the PR, ran npm i and npm run pod-install, and then hit this error on iOS for the standalone app.

@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

yeah, I'm currently figuring this one out. Will keep you posted!

@Kureev Kureev force-pushed the kureev/63871-part4 branch from 3175cb5 to 077de80 Compare September 5, 2025 10:35
@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

fixed the build, @jayeshmangwani

@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

oh, seems there are some patches for the outdated versions of the expo packages. Will fix in a few mins

@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

tests seems to be flaky, locally they pass without issues.

will rebase on top of latest main and trigger them again

@Kureev Kureev force-pushed the kureev/63871-part4 branch from 49faea3 to e45240e Compare September 5, 2025 11:19
@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

some tests are failing, but I'm sure it is not related to this PR. Likely, someone updated the typescript version somewhere in the main branch

@Kureev Kureev force-pushed the kureev/63871-part4 branch from e45240e to f2f1285 Compare September 5, 2025 13:41
@Kureev
Copy link
Contributor Author

Kureev commented Sep 5, 2025

@jayeshmangwani I think it is ready for review now. Should be all good with the builds

@jayeshmangwani
Copy link
Contributor

Cool, I’m on the review now.

@roryabraham
Copy link
Contributor

@Kureev tsc is failing

@jayeshmangwani
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android.mp4
Android: mWeb Chrome
mweb-chrome.mov
iOS: HybridApp
iOS.mov
iOS: mWeb Safari
mweb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

@jayeshmangwani
Copy link
Contributor

@Kureev typecheck is failing on this PR only because of the line "moduleResolution": "node" in tsconfig.json.
Screenshot 2025-09-07 at 6 21 27 PM
On the main, typecheck passes.

@Kureev Kureev force-pushed the kureev/63871-part4 branch from f2f1285 to 1e5a547 Compare September 8, 2025 09:04
@Kureev
Copy link
Contributor Author

Kureev commented Sep 8, 2025

@jayeshmangwani rebased on top of the main, let's keep an eye on the tests, hopefully everything pass now

@jayeshmangwani
Copy link
Contributor

@Kureev This issue might be due to the updated expo-image version, since it’s only failing on our PR. You can verify by runningnpm run typecheck locally.

@Kureev Kureev force-pushed the kureev/63871-part4 branch from b41bd39 to c79e654 Compare September 8, 2025 14:04
@Kureev
Copy link
Contributor Author

Kureev commented Sep 14, 2025

Okay, it seems the problem was in the main branch and not related to this PR (after merging main it went away). Ready for review/merge

@Kureev Kureev requested a review from roryabraham September 14, 2025 14:53
@jayeshmangwani
Copy link
Contributor

@Kureev , I don’t think we want to commit the Mobile-Expensify changes in this PR.
Screenshot 2025-09-15 at 11 59 59 PM

@Kureev
Copy link
Contributor Author

Kureev commented Sep 15, 2025

ah right, probably slipped in one of the merges. Let me fix this real quick

@Kureev
Copy link
Contributor Author

Kureev commented Sep 15, 2025

@jayeshmangwani reverted submodule to the current main

Copy link
Contributor

@jayeshmangwani jayeshmangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works well, lgtm 🚀

@roryabraham
Copy link
Contributor

Do we have a Mobile-Expensify counterpart for this PR?

@Kureev
Copy link
Contributor Author

Kureev commented Sep 15, 2025

@roryabraham not this one

@roryabraham
Copy link
Contributor

Reassure is failing everywhere, going to ignore it for now. slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1757971409580299?thread_ts=1757006279.943369&cid=C01GTK53T8Q

@roryabraham roryabraham merged commit 8ddfa01 into Expensify:main Sep 15, 2025
29 of 30 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.15-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@roryabraham
Copy link
Contributor

The TSConfig changes made to scripts/tsconfig.json are causing all sorts of problems for me while working on scripts. I still don't really understand how updating react-native-blob-util and expo-image necessitated tsconfig changes to .github/tsconfig.json and scripts/tsconfig.json

@Kureev
Copy link
Contributor Author

Kureev commented Sep 17, 2025

The TSConfig changes made to scripts/tsconfig.json are causing all sorts of problems for me while working on scripts. I still don't really understand how updating react-native-blob-util and expo-image necessitated tsconfig changes to .github/tsconfig.json and scripts/tsconfig.json

see #69649 (comment)

Kureev added a commit to margelo/Expensify that referenced this pull request Sep 17, 2025
…part4"

This reverts commit 8ddfa01, reversing
changes made to 262cf37.
mountiny added a commit that referenced this pull request Sep 17, 2025
[CP Staging] Revert "Merge pull request #69649 from margelo/kureev/63871-part4"
OSBotify pushed a commit that referenced this pull request Sep 17, 2025
[CP Staging] Revert "Merge pull request #69649 from margelo/kureev/63871-part4"

(cherry picked from commit aaa84b9)

(cherry-picked to staging by Beamanator)
@Kureev Kureev mentioned this pull request Sep 18, 2025
51 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.2.15-15 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.16-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants