Skip to content

Remove Onyx.connect() for the key: ONYXKEYS.ARE_TRANSLATIONS_LOADING in src/libs/PersonalDetailsUtils.ts #69651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 4 commits into from
Oct 23, 2025
Merged

Remove Onyx.connect() for the key: ONYXKEYS.ARE_TRANSLATIONS_LOADING in src/libs/PersonalDetailsUtils.ts #69651

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95db8c8
remove connect method
DylanDylann Oct 20, 2025
e5efbbe
chore: update translation
DylanDylann Oct 21, 2025
ef89a2d
fixx eslint
DylanDylann Oct 21, 2025
49ac1be
Merge branch 'main' into refactor-302
DylanDylann Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions src/libs/PersonalDetailsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,31 +36,15 @@ Onyx.connect({
},
});

let hiddenTranslation = '';
let youTranslation = '';

Onyx.connect({
key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
initWithStoredValues: false,
callback: (value) => {
if (value ?? true) {
return;
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
hiddenTranslation = translateLocal('common.hidden');
// eslint-disable-next-line @typescript-eslint/no-deprecated
youTranslation = translateLocal('common.you').toLowerCase();
},
});

const regexMergedAccount = new RegExp(CONST.REGEX.MERGED_ACCOUNT_PREFIX);

function getDisplayNameOrDefault(
passedPersonalDetails?: Partial<PersonalDetails> | null,
defaultValue = '',
shouldFallbackToHidden = true,
shouldAddCurrentUserPostfix = false,
youAfterTranslation = youTranslation,
// eslint-disable-next-line @typescript-eslint/no-deprecated
youAfterTranslation = translateLocal('common.you').toLowerCase(),
): string {
let displayName = passedPersonalDetails?.displayName ?? '';

Expand Down Expand Up @@ -100,8 +84,8 @@ function getDisplayNameOrDefault(
if (login) {
return login;
}

return shouldFallbackToHidden ? hiddenTranslation : '';
// eslint-disable-next-line @typescript-eslint/no-deprecated
return shouldFallbackToHidden ? translateLocal('common.hidden') : '';
}

/**
Expand Down
Loading