[NO QA] Better RHP view v3 - Implement wide RHP functionality

[adamgrzybowski]

Explanation of Change

This PR prepares the functionality of the wide RHP from the navigation perspective. It hasn't been used yet in any flow, so you can't test it or see it in the app. It will be used in the next PR.

It's a part of the bigger chain of changes:

• [NO QA] Better RHP view v1 - Pre cleaning
• Better RHP view v2 - Extract MoneyRequestReceiptView
• [NO QA] Better RHP view v3 - Implement wide RHP functionality
• Better RHP view v3 - Use wide RHP for receipts

Fixed Issues

$ #64025
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

NO QA

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[trjExpensify]

t hasn't been used yet in any flow, so you can't test it or see it in the app. It will be used in the next PR.

Removing the product-PR label for this one. 👍

[parasharrajat]

@adamgrzybowski is this ready for review?

[adamgrzybowski]

@parasharrajat, yes, I thought you started your review already 🤔

[parasharrajat]

I mean to ask whether you fixed the conflicts code and its ready for another review.

[adamgrzybowski]

@parasharrajat I reacted with thumbs up emoji, but just to be sure you will get the notification 😄 Yes, it is ready for the next round of review

[parasharrajat]

I approved this as I didn't find any issues. Let's wait for the pending comments to be resolved.

[parasharrajat]

Bump @mountiny

[mountiny]

@adamgrzybowski can you please sync with main

[adamgrzybowski]

@mountiny synced

[mountiny]

@adamgrzybowski Are you sure this is NoQA? Some of the changes look quite low level to me

[mountiny]

I only see it used once so I am hesitant to add another usage. I think you can create the utils file with the appropriate platforms split and then import these styles from there @adamgrzybowski Could you update two cases from here to use that approach? then we could clean up the other cases of Platform.OS ===

[adamgrzybowski]

@adamgrzybowski Are you sure this is NoQA? Some of the changes look quite low level to me

@mountiny, There is no new functionality to test. In theory, everything should be the same as before. But we can run some tests. However, I don't know how to describe them except "make sure that everything works the same as on main"

[adamgrzybowski]

I only see it used once so I am hesitant to add another usage. I think you can create the utils file with the appropriate platforms split and then import these styles from there @adamgrzybowski Could you update two cases from here to use that approach? then we could clean up the other cases of Platform.OS ===

There are 5 cases with Platform.OS. Adding a systematic solution for platform-dependent styles sounds like a great idea, but let's maybe do it in a separate PR. A future-proof solution would probably require eslint rule, some explanation in the docs, and the solution itself. I can look for somebody in SWM for that if you want.

cc: @mountiny

[adamgrzybowski]

@mountiny, besides the open discussions, all change requests should be implemented.

I can still add videos and test steps if you want

[parasharrajat]

I am already discussing this internally to create a ESLInt rule for Platform.OS but I am waiting on internal discussion to wrap up.

[mountiny]

Thanks!

[adamgrzybowski]

@mountiny, what are the next steps on this one? Merging this PR would unblock the last PR

[mountiny]

@adamgrzybowski the jest is still failing here, can you sync with main again, I dont see this same test failing on main

[adamgrzybowski]

@mountiny done

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.9-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.11-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MonilBhavsar]

It appears like this PR caused #70379. Can anyone please take a look, thanks!

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅