[CP Staging] Expense - App crashes after splitting expense by WojtekBoman · Pull Request #69765 · Expensify/App

WojtekBoman · 2025-09-03T11:11:13Z

Explanation of Change

This PR fixes #69696. It handles the case when searchResults is equal to {data: {}} and we try to read searchResults?.search.type. The optional chaining usage here fixes the problem.

The app behaviour after being fixed:

Screen.Recording.2025-09-03.at.13.21.51.mov

Fixed Issues

$ #69696
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Open the app.
Create a workspace.
Go to workspace chat.
Submit an expense to the workspace chat.
Click on the expense preview.
Click More > Split.
Click Save.
Verify if the app doesn't crash.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open the app.
Create a workspace.
Go to workspace chat.
Submit an expense to the workspace chat.
Click on the expense preview.
Click More > Split.
Click Save.
Verify if the app doesn't crash.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-03T11:26:00Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2025-09-03T12:51:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

20250903184407370.mp4

Android: mWeb Chrome

20250903182306197.mp4

iOS: HybridApp

failed to build the app locally.

iOS: mWeb Safari

20250903181644943.mp4

MacOS: Chrome / Safari

20250903161532910.mp4

20250903170252765.mp4

Untitled.mp4

MacOS: Desktop

20250903184551808.mp4

ahmedGaber93 · 2025-09-03T13:20:04Z

@WojtekBoman Still crash on offline mode

20250903161743486.mp4

the crash details

20250903162334640.mp4

ahmedGaber93 · 2025-09-03T14:09:56Z

Another crash
Steps:

Create a workspace.
Go to workspace chat.
Create and Submit an expense to the workspace chat.
Click on the expense preview.
Click More > Split.
Click Save.
Go to reports > Explore > expenses

20250903170908237.mp4

ahmedGaber93

LGTM!

carlosmiceli · 2025-09-03T16:00:16Z

@ahmedGaber93 @WojtekBoman should the performance tests failing here hold us back frmo merging?

arosiclair

Perf tests are broken for everyone. Let's merge.

arosiclair · 2025-09-03T16:56:22Z

@carlosmiceli please request a CP 🙏

OSBotify · 2025-09-03T16:56:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…e-crash [CP Staging] Expense - App crashes after splitting expense (cherry picked from commit 83a172d) (cherry-picked to staging by arosiclair)

OSBotify · 2025-09-03T21:06:08Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.1-9 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-03T22:53:21Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.1-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-05T19:37:33Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.1-20 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-05T20:05:16Z

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.2.2-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2025-09-09T03:07:58Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.2-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned WojtekBoman Sep 3, 2025

WojtekBoman marked this pull request as ready for review September 3, 2025 11:25

WojtekBoman requested review from a team as code owners September 3, 2025 11:25

melvin-bot bot requested review from ahmedGaber93 and removed request for a team September 3, 2025 11:25

mountiny changed the title ~~Expense - App crashes after splitting expense~~ [CP Staging] Expense - App crashes after splitting expense Sep 3, 2025

WojtekBoman force-pushed the fix/split-expense-crash branch 2 times, most recently from 59b4c2c to 97db9c7 Compare September 3, 2025 13:56

WojtekBoman force-pushed the fix/split-expense-crash branch from 97db9c7 to deffc07 Compare September 3, 2025 14:51

Fix issue: Expense - App crashes after splitting expense

1f248bd

WojtekBoman force-pushed the fix/split-expense-crash branch from deffc07 to 1f248bd Compare September 3, 2025 15:20

ahmedGaber93 approved these changes Sep 3, 2025

View reviewed changes

melvin-bot bot requested a review from carlosmiceli September 3, 2025 15:47

carlosmiceli approved these changes Sep 3, 2025

View reviewed changes

arosiclair approved these changes Sep 3, 2025

View reviewed changes

arosiclair merged commit 83a172d into Expensify:main Sep 3, 2025
21 of 22 checks passed

arosiclair mentioned this pull request Sep 3, 2025

[Due for payment 2025-09-16] Expense - App crashes after splitting expense #69696

Closed

8 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 3, 2025

OSBotify mentioned this pull request Sep 3, 2025

Deploy Checklist: New Expensify 2025-09-02 #69693

Closed

Conversation

WojtekBoman commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 3, 2025

Uh oh!

ahmedGaber93 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Sep 3, 2025

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arosiclair commented Sep 3, 2025

Uh oh!

OSBotify commented Sep 3, 2025

Uh oh!

OSBotify commented Sep 3, 2025

Uh oh!

OSBotify commented Sep 3, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

OSBotify commented Sep 5, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WojtekBoman commented Sep 3, 2025 •

edited

Loading

ahmedGaber93 commented Sep 3, 2025 •

edited

Loading

ahmedGaber93 commented Sep 3, 2025 •

edited

Loading

ahmedGaber93 commented Sep 3, 2025 •

edited

Loading