-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Bump onyx to v2.0.139 #69872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump onyx to v2.0.139 #69872
Conversation
|
|
Reviewer Checklist
Screenshots/VideosScreen.Recording.2025-09-09.at.01.07.54.movSimulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-09.at.01.09.57.mp4 |
Pujan92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now!
mountiny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.3-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.5-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.8-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀
|
Explanation of Change
Check the discussion: #66801 (comment)
Adds these onyx updates: Expensify/react-native-onyx#681
Update batching to be applied to useOnyx if they come from
Onyx.update.Before, the batch updates logic in the onyx was working for
withOnyxsubscribers only.This PR extends that batching mechanism to also include
useOnyxsubscribers, if the updates come fromOnyx.update.Previously,
useOnyxsubscribers could receiveOnyx.updateupdates slightly out of sync, as some updates would arrive a bit earlier than others, causing extra re-renders and data missing -> it was reported here. It should be fixed with this PR.Fixed Issues
$ #66799
PROPOSAL: N/A
Tests
The app should work the same way as before:
Offline tests
Same, as in the Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in the Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android1.mp4
android2.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios1.mp4
iOS: mWeb Safari
ios_web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4