Chore/upgrade plaid link sdk

[rohit9625]

Explanation of Change

We were using react-native-plaid-link-sdk version 11.11.0, which doesn't handle edge-to-edge insets for Android 15+ devices. So, I upgraded the library version to 12.4.0 as it was the latest stable release, which handles edge-to-edge correctly.

I also removed an outdated patch for react-native-plaid-link-sdk as the patch fix was included in version 11.12.1. So, no need to maintain that patch.

Fixed Issues

$ #69115
PROPOSAL: $ #69115 (comment)

Tests

1. Open the Android app
2. Navigate to the Workflows in the Workspace Settings
3. Tap on the Add bank account in the payment section
4. Tap on the Log into your bank
5. Tap on the Confirm button
6. Notice the cross/plaid icon at the top and buttons on the bottom don't overlap with system bars

• Verify that no errors appear in the JS console

Offline tests

Can't test in Offline Mode as theAdd Bank Account button is disabled in Offline Mode which is the expected behavior.

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-05.at.11.10.27.PM.mov

Android: mWeb Chrome

Screen_recording_20250905_232035.mp4

iOS: Native

Screen.Recording.2025-09-05.at.10.47.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-09-05.at.10.50.58.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-05.at.10.53.24.PM.mov

MacOS: Desktop

Screen.Recording.2025-09-05.at.11.24.47.PM.mov

[melvin-bot]

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[rohit9625]

The prettier check is failing on main as well. I'll merge main once resolved :)

[akinwale]

@rohit9625 The app crashes on launch for me on the iOS 18.3 simulator.

[rohit9625]

Sorry, I misread the version. On which simulator device do you test, @akinwale?

[rohit9625]

I just tested on iOS 18.3 Simulator and the app didn't crash. Are you sure @akinwale, that the app is not crashing on main?

Screen.Recording.2025-09-07.at.8.51.14.AM.mov

[rohit9625]

Hi, @akinwale
Did you tried pod install because some changes also made in the Podfile as well?

[akinwale]

@rohit9625 I'll try a new clean build today. Please merge the latest main as well.

[akinwale]

@rohit9625 I am no longer experiencing the crash on launch after a full rebuild on iOS.

I am seeing this error on iOS and Android native the first time I tap on the Add bank account button. Could you check and verify if it was introduced by this PR or if it is happening on main?

[rohit9625]

Hi @akinwale, I tested on main and can confirm that the issue is not caused by this PR. This was reproducible even before I created this PR.

Screen.Recording.2025-09-09.at.11.13.46.AM.mov

[akinwale]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

69971-android-hybrid.mp4

Android: mWeb Chrome

69971-android-chrome.mp4

iOS: HybridApp

69971-ios-hybrid.mp4

iOS: mWeb Safari

69971-ios-safari.mp4

MacOS: Chrome / Safari

69971-web.mp4

MacOS: Desktop

69971-desktop.mp4

[akinwale]

LGTM.

[justinpersaud]

I'm going to do an adhoc build for this and request QA do testing on plaid flows

[rohit9625]

Seems like Adhoc is failing, @justinpersaud on main.

[github-actions]

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

[justinpersaud]

You want a new adhoc build from this branch? I can do another one if that is what we want.

[rohit9625]

Yes, please trigger a new build. Thanks 🙂

[github-actions]

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

[rohit9625]

Hey @justinpersaud, the build is failing because of Node version mismatch. I think we need to install node version 20.19.4 for Hybrid codebase. Seems like it's recently upgraded.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69971 Mobile-Expensify PR Expensify/Mobile-Expensify#13694.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69971/NewExpensify.dmg	https://69971.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[github-actions]

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69971 Mobile-Expensify PR Expensify/Mobile-Expensify#13694.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69971/NewExpensify.dmg	https://69971.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[justinpersaud]

Looking into the node issue

[war-in]

Guys, both Android & iOS adhoc build issues are unrelated to this PR and should already be fixed

• Android failed due to a Maven outage and was present on other branches too (is already resolved)
• iOS failed because of build issue on main (PR that caused the regression has been reverted)

I'd recommend merging the latest main

I also can't find the MOBILE-EXPENSIFY entry in the PR description with the linked OldDot PR. We will need one to apply the Podfile.lock changes in the old repo

cc @rohit9625

[rohit9625]

Thanks for the bump, @war-in
I'm merging main now

[rohit9625]

I just saw that the checks are failing on main. Should I really merge now or wait for them to resolve on main?

[war-in]

@rohit9625 Let's wait for the fix...
I already pinged the PR author

[rohit9625]

Sure, thanks 😊

[war-in]

@rohit9625 PR with the fix has been merged 🚀

[roryabraham]

@rohit9625 you've got conflicts here

[rohit9625]

Thanks for the bump, @roryabraham and @war-in

The checks were failing when I checked yesterday. But now everything looks great. So, I'm merging main resolving the conflicts.

[rohit9625]

Hi @justinpersaud, I freshly merged main to this branch. Could you please trigger an Adhoc build as previous ones were failing for Android and iOS?
Thank you :)

[github-actions]

🚧 @justinpersaud has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #69971 Mobile-Expensify PR Expensify/Mobile-Expensify#13694.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/69971/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/69971/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/69971/NewExpensify.dmg	https://69971.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[justinpersaud]

Build is done. Can you check if the issue is resolved now?

[rohit9625]

The above issue has been resolved now :)

Screen.Recording.2025-09-23.at.7.48.39.PM.mov

Thank you so much, everyone. Please proceed with final review, @justinpersaud

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.2.17-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.17-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅