Implement infinite sessions #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
requested changes
Aug 8, 2020
src/store/actions/SessionActions.js
Outdated
Comment on lines
109
to
111
| .catch((err) => { | ||
| Store.set(STOREKEYS.SESSION, {error: err.message}); | ||
| }); |
Contributor
There was a problem hiding this comment.
Suggested change
| .catch((err) => { | |
| Store.set(STOREKEYS.SESSION, {error: err.message}); | |
| }); | |
| .catch(err => Store.set(STOREKEYS.SESSION, {error: err.message})); |
Make sure your linter is working, because this should have thrown a listing error. Also, it's maybe better to use merge() here so it doesn't blow away the rest of the stuff on that key. I can do that in a followup PR too since this branch doesn't have merge yet.
Contributor
Author
There was a problem hiding this comment.
Ah yeah, the session is going to be tricky not to blow away
tgolen
requested changes
Aug 8, 2020
tgolen
approved these changes
Aug 8, 2020
Julesssss
pushed a commit
that referenced
this pull request
Apr 7, 2021
Contributor
|
🚀 [Deployed](https://github.com/Expensify/Expensify.cash
|
11 tasks
6 tasks
Deploying helpdot with
|
| Latest commit: |
7cd00c9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://759d03c3.helpdot.pages.dev |
MrMuzyk
added a commit
to MrMuzyk/App
that referenced
this pull request
Jan 24, 2024
* feat: Added missing validation and QOL change on UBO confirm step * fix: add missing prop
Deploying new-help with
|
| Latest commit: |
06f5b66
|
| Status: | 🚫 Build failed. |
Deploying newhelp with
|
| Latest commit: |
3634670
|
| Status: | 🚫 Build failed. |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented infinite sessions:
useExpensifyLogin = truefor the firstAuthenticatewhich will create a new login viaCreateLoginCreateLoginuseReact-Native-Chat-${guid}for the login name and${guid}for the passwordverifyAuthTokencheck the last time, if it's more than 90 minutes use the random login and password to call authenticate