use getLocalMomentFromTimestamp #7022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
parasharrajat and
tgolen
and removed request for
a team
parasharrajat
suggested changes
Jan 4, 2022
Member
|
Could you please add videos for remaining platforms as well? |
tgolen
requested changes
Jan 4, 2022
Member
Author
|
@tgolen @parasharrajat |
tgolen
requested changes
Jan 4, 2022
Contributor
tgolen
left a comment
tgolen
left a comment
There was a problem hiding this comment.
Thanks for the quick update! I had mentioned this in the original issue and I think it would help to improve this code a little further.
Member
Author
|
bump @tgolen |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Member
|
cc: @tgolen Actually, sorry that is on staging and working fine on this PR. |
21 tasks
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
fixed date format flicker in details page
Fixed Issues
$ #6779
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2022-01-04.at.6.42.45.PM.mov
Mobile Web
Screen.Recording.2022-01-04.at.6.44.46.PM.mov
Desktop
Screen.Recording.2022-01-04.at.11.04.44.PM.mov
iOS
Screen.Recording.2022-01-04.at.10.55.31.PM.mov
Android
Screen.Recording.2022-01-04.at.10.54.57.PM.mov