Remove the `react-native-modal` library #70289

mhawryluk · 2025-09-10T16:05:45Z

Explanation of Change

Removes the react-native-modal library as the final step of the migration to a custom react-native-reanimated component. All of the usages have been migrated already, so this shouldn't change any behavior, this is just a necessary cleanup and optimization. It also removes some no-longer necessary props, specific to the library being removed.

Fixed Issues

$ #64775
PROPOSAL: N/A

Tests

Log in with a new account
Complete the onboarding
Check if the test-drive modal appears correctly, can be dismissed and animates by fading in and out.

Also:

Open the help modal anywhere by clicking on the question mark icon. (set Onyx.set('nvp_sidePanel', {}); to enable the feature)
See if the content inside is scrollable.

Also:

Click on FAB
See if appears correctly, with no animations and can be dismissed

Also:

Go to Reports tab
Click on the Date filter
Click On
Click on the year (2025)
See if the year picker modal and its backdrop appear correctly (by sliding from the right and fading in respectively)
See if the modal can be dismissed and the animations work

Also:

Open a chat
Sent a picture
Click on the picture on the chat
See if the attachment modal is correctly placed and animates in and out

Offline tests

N/A

QA Steps

Same as tests.

and also:

Create a new account
Enter name
Skip adding people you already know. Continue.
Select "Manage my team's expenses". Continue.
Select 1 - 10 employees. Continue.
Select "None". Continue.
Select "Start test drive"
Fullscreen test drive demo modal shows and is interactive

and:

Delete a message in a chat
See if the confirm modal appears, animates correctly and can be dismissed.

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2025-09-11.o.14.44.19.mov

Nagranie.z.ekranu.2025-09-11.o.14.45.58.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2025-09-11.o.13.18.49.mov

Nagranie.z.ekranu.2025-09-11.o.13.20.26.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-09-11.at.13.07.50.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-09-11.at.13.09.04.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-09-11.at.13.04.03.mp4

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-09-11.at.13.04.03-kopia.2.mp4

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-09-11.o.12.47.12.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-09-11.o.12.50.51.mov

github-actions · 2025-09-10T16:05:54Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

staszekscp

Great job! 🎉

blazejkustra

This is satisfying, lgtm 🚀

blazejkustra · 2025-09-12T09:19:05Z

config/webpack/webpack.common.ts

 const PreloadWebpackPlugin = require('@vue/preload-webpack-plugin') as PreloadWebpackPluginClass;

 const includeModules = [
-    'react-native-animatable',


Let's remove react-native-animatable reference in eslintrc as well

melvin-bot · 2025-09-12T10:01:24Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-09-15T09:21:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading Запись экрана 2025-09-15 в 12.03.12.mov…

Android: mWeb Chrome

2025-09-15.12.03.12.mov

iOS: HybridApp

2025-09-15.11.57.36.mov

iOS: mWeb Safari

2025-09-15.11.59.25.mov

MacOS: Chrome / Safari

2025-09-15.11.51.36.mov

MacOS: Desktop

2025-09-15.11.51.36.mov

ZhenjaHorbach · 2025-09-15T10:10:56Z

LGTM !

src/components/Modal/BaseModal.tsx

mountiny

All good, I see how its structured now! We should be good to move it ahead. Thank you very much!

OSBotify · 2025-09-15T14:11:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-16T18:32:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.15-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-19T22:23:59Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.2.15-15 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…/remove-react-native-modal" This reverts commit 17b4214, reversing changes made to 5f82c64.

OSBotify · 2025-12-05T18:28:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-12-05T19:11:56Z

@mhawryluk @mountiny Seems this PR from old build, do we need to test it? Thank you

mountiny · 2025-12-06T10:40:54Z

@izarutskaya you dont need to

OSBotify · 2025-12-09T09:57:36Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.73-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove the react-native-modal library

e830732

melvin-bot bot assigned mhawryluk Sep 10, 2025

mhawryluk added 3 commits September 11, 2025 10:49

Fix typo

5608b7b

Merge branch 'main' into remove-react-native-modal

44243cd

Merge branch 'main' into remove-react-native-modal

b3236d9

staszekscp approved these changes Sep 11, 2025

View reviewed changes

Merge branch 'main' into remove-react-native-modal

783edeb

blazejkustra approved these changes Sep 12, 2025

View reviewed changes

mhawryluk added 2 commits September 12, 2025 11:26

Remove react-native-animatable from eslint rules

8164fb3

Merge branch 'main' into remove-react-native-modal

fc39c82

mhawryluk marked this pull request as ready for review September 12, 2025 10:01

mhawryluk requested review from a team as code owners September 12, 2025 10:01

melvin-bot bot requested a review from ZhenjaHorbach September 12, 2025 10:01

melvin-bot bot removed the request for review from a team September 12, 2025 10:01

ZhenjaHorbach approved these changes Sep 15, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny September 15, 2025 10:11

mountiny reviewed Sep 15, 2025

View reviewed changes

src/components/Modal/BaseModal.tsx Show resolved Hide resolved

mountiny approved these changes Sep 15, 2025

View reviewed changes

mountiny merged commit 17b4214 into Expensify:main Sep 15, 2025
39 checks passed

OSBotify mentioned this pull request Sep 16, 2025

Deploy Checklist: New Expensify 2025-09-16 #70674

Closed

91 tasks

neil-marcellini mentioned this pull request Sep 16, 2025

Revert "Remove the react-native-modal library" #70697

Closed

49 tasks

lakchote mentioned this pull request Sep 17, 2025

[Due for payment 2025-10-13] Android - Status - Emoji picker opens at the top #70692

Closed

16 tasks

neil-marcellini mentioned this pull request Sep 18, 2025

[$250] Android - Chat - Tapping device back button from concierge navigates to inbox #70764

Closed

16 tasks

melvin-bot bot mentioned this pull request Sep 19, 2025

[Due for payment 2025-12-16] [Due for payment 2025-09-26] [$250] [Tracking] Use react-native-reanimated in the ModalComponent #64775

Closed

chrispader added a commit to margelo/Expensify that referenced this pull request Oct 4, 2025

Revert "Merge pull request Expensify#70289 from software-mansion-labs…

5bd84d7

…/remove-react-native-modal" This reverts commit 17b4214, reversing changes made to 5f82c64.

OSBotify mentioned this pull request Dec 5, 2025

Deploy Checklist: New Expensify 2025-12-05 #76837

Closed

73 tasks

Remove the react-native-modal library #70289

Remove the react-native-modal library #70289

Uh oh!

Conversation

mhawryluk commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

staszekscp left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Sep 12, 2025

Uh oh!

ZhenjaHorbach commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Sep 15, 2025

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 15, 2025

Uh oh!

OSBotify commented Sep 16, 2025

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

OSBotify commented Dec 5, 2025

Uh oh!

izarutskaya commented Dec 5, 2025

Uh oh!

mountiny commented Dec 6, 2025

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Remove the `react-native-modal` library #70289

Remove the `react-native-modal` library #70289

mhawryluk commented Sep 10, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 15, 2025 •

edited

Loading