Remove onyx.connect from DraftCommentUtils

[kubabutkiewicz]

Explanation of Change

Fixed Issues

$ #66308
PROPOSAL:

Tests

1. Open report
2. Write a draft message
3. Go back to LHN
4. Check if draft pencil icon is correctly displayed
5. Check if report position in the list has changed properly
6. Open the same report
7. Check if draft is correctly displayed
8. Remove message
9. Go back to LHN
10. Check if draft icon disappeared
11. Check if report position changed to original one

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

@kubabutkiewicz Please fix failed GH actions

[DylanDylann]

@kubabutkiewicz Please ping me when this PR is ready again

[kubabutkiewicz]

@DylanDylann Will do it 👍

[DylanDylann]

@kubabutkiewicz It seems we’ve run into an interesting case with the failed test.

1. Regarding your solution, let’s take a closer look. In perf: optimize useSidebarOrderedReports hook #68038, it looks like the author forgot to update the dependency. Since eslint is disabled on that line, this missing was overlooked. cc @OlimpiaZurek @hoangzinh (tag you because you guys worked on perf: optimize useSidebarOrderedReports hook #68038)

2. What’s more puzzling is why this failed test doesn’t occur on main. That’s still a question I haven’t been able to answer.

[DylanDylann]

If @OlimpiaZurek can confirm that we can update the dependency from reportsToDisplayInLHN to deepComparedReportsToDisplayInLHN, then I think we can move forward and set aside my second point above.

On the other hand, if not, we’ll need to dig deeper into point 2 to clarify it which could take quite a bit of time.

[hoangzinh]

I recall it will cause this bug if we use deepComparedReportsToDisplayInLHN as dependency

[DylanDylann]

@hoangzinh Thanks for the reminder. @kubabutkiewicz Look like we need to revert this line

[kubabutkiewicz]

hey, yeah I will confirm if this bug is still there firstly if yes I will revert this line and try to figure out the solution

[kubabutkiewicz]

@DylanDylann I pushed new fix for test, I checked it locally and the test is passing, and I dont see this problem which @hoangzinh mentioned

[DylanDylann]

@kubabutkiewicz I’m writing to ask for a main merge 😄

[DylanDylann]

Why do we need to add deepComparedReportsDrafts to dependency list? It is intentional to keep reportsToDisplayInLHN and localeCompare only in the dependency list (see detail here: #63980)

[DylanDylann]

@kubabutkiewicz Kindly bump

[kubabutkiewicz]

Yes I am on it, earlier without deepComparedReportsDrafts there was a problem that when we add the draft message, the LHN wasnt updated, I want to check it but have some problems with running the native app locally

[kubabutkiewicz]

Ok, I was able to test this, so without deepComparedReportsDrafts in the dependecy array we are not sorting the LHN items when we add draft to some report, so I think it needs to be there + also tests for useSidebarOrderedReports is passing which means that this hook only rerenderes when the report id is changing which is what we want

[danieldoglas]

is it possible to break this down into smaller PRs?

[kubabutkiewicz]

@danieldoglas I think its not possible for this PR, we are removing module DraftCommentsUtils, and we need to adjust all the places which are using this module at once :(

[DylanDylann]

@danieldoglas Sorry for the inconvenience. The changes gradually expanded during the review process. We’ll make sure to split big PRs better in future PRs. Since this one is almost complete, could we proceed with it here for now? Many thanks

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅