Skip to content

Fix viewport is scrolled in some pages on iOS mWeb#70643

Merged
tylerkaraszewski merged 10 commits intoExpensify:mainfrom
bernhardoj:fix/67351-scroll-issue-on-ws-search
Mar 12, 2026
Merged

Fix viewport is scrolled in some pages on iOS mWeb#70643
tylerkaraszewski merged 10 commits intoExpensify:mainfrom
bernhardoj:fix/67351-scroll-issue-on-ws-search

Conversation

@bernhardoj
Copy link
Contributor

@bernhardoj bernhardoj commented Sep 16, 2025

Explanation of Change

Fixed Issues

$ #67351
PROPOSAL: #67351 (comment)

Tests

Prerequisite: have more than 15 workspaces

Only for mWeb/iOS/Android

  1. Open Workspaces list page
  2. Focus on the search input. Make sure the keyboard is shown
  3. Search anything so that only 1 WS show
  4. Verify the page is not scrollable
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari Screenshot 2025-09-16 at 18 05 30
MacOS: Desktop Screenshot 2025-09-16 at 18 16 57

@bernhardoj bernhardoj requested a review from a team as a code owner September 16, 2025 10:30
@melvin-bot melvin-bot bot requested a review from sobitneupane September 16, 2025 10:30
@melvin-bot
Copy link

melvin-bot bot commented Sep 16, 2025

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team September 16, 2025 10:30
@bernhardoj
Copy link
Contributor Author

Recording for the other pages:

ios.mweb.mp4

@bernhardoj
Copy link
Contributor Author

Having trouble running the Android

image

@sobitneupane
Copy link
Contributor

@bernhardoj We currently close the keyboard for all lists except Workspace. Do you know why that is? Could we also close it on the Workspace page? I think we’ve discussed this before.

@sobitneupane
Copy link
Contributor

After the keyboard is opened, some padding is added above it.

Screen.Recording.2025-09-23.at.19.19.09.mov

@sobitneupane
Copy link
Contributor

Some part of the last workspace is cut off by the keyboard.

Screen.Recording.2025-09-23.at.19.08.41.mov

@bernhardoj
Copy link
Contributor Author

@sobitneupane Sorry for missing this.

We currently close the keyboard for all lists except Workspace. Do you know why that is? Could we also close it on the Workspace page? I think we’ve discussed this before.

You mean close the keyboard while scrolling? We close on scrolling when using SelectionList.

const defaultOnScroll = () => {
// Only dismiss the keyboard whenever the user scrolls the screen or `shouldHideKeyboardOnScroll` is true
if (!isScreenTouched || !shouldHideKeyboardOnScroll) {
return;
}
Keyboard.dismiss();
};

But the WS list page uses FlatList.

<FlatList
ref={flatlistRef}
data={filteredWorkspaces}
onScrollToIndexFailed={(info) => {
flatlistRef.current?.scrollToOffset({
offset: info.averageItemLength * info.index,
animated: true,
});
}}
renderItem={getMenuItem}
ListHeaderComponent={listHeaderComponent}
keyboardShouldPersistTaps="handled"
/>

Should we add onScroll and dismiss the keyboard too?

After the keyboard is opened, some padding is added above it.

I can't reproduce this one, but most likely it's the viewport autoscroll of Safari.

Some part of the last workspace is cut off by the keyboard.

Can't repro this one either.

@bernhardoj
Copy link
Contributor Author

@sobitneupane bump

@sobitneupane
Copy link
Contributor

Should we add onScroll and dismiss the keyboard too?

I think it makes sense for consistency. What do you think?

I'll try reproducing the other issues and update you soon.

@sobitneupane
Copy link
Contributor

I can still reproduce this issue on mWeb/Safari. @bernhardoj Could you please test it again?

Screen.Recording.2025-10-07.at.14.56.16.mov

I can still reproduce this issue on IOS/native. However, this should no longer be a problem once we implement this fix.

Screen.Recording.2025-10-07.at.15.03.06.mov

@bernhardoj Both issues are consistently reproducible on my end. These issues are not reproducible in main.

@bernhardoj
Copy link
Contributor Author

I can reproduce the first issue now. It also happens on main and staging.

ios.mweb.mp4

The 2nd issue also happens on main.

ios.mp4

I think it makes sense for consistency. What do you think?

I'm not 100% sure. I think it's best to replace the FlatList to SelectionList if we want the keyboard dismiss on scroll behavior (but I'm afraid this would cause regressions). Otherwise, we need to create a hook(?) to DRY up the logic and create a separate native and non native files.

@sobitneupane
Copy link
Contributor

sobitneupane commented Oct 14, 2025

In this issue, I am talking about the highlighted area (spacing above the keyboard). I can not reproduce it on main.

Screenshot 2025-10-14 at 20 40 37

@sobitneupane
Copy link
Contributor

I'm not 100% sure. I think it's best to replace the FlatList to SelectionList if we want the keyboard dismiss on scroll behavior (but I'm afraid this would cause regressions). Otherwise, we need to create a hook(?) to DRY up the logic and create a separate native and non native files.

In that case, let's focus on the issue described in the OP.

@sobitneupane
Copy link
Contributor

The 2nd issue also happens on main.

I was also able to reproduce the issue on main. 👍

@sobitneupane
Copy link
Contributor

Bump @bernhardoj

@bernhardoj
Copy link
Contributor Author

bernhardoj commented Oct 18, 2025

In #70643 (comment) issue, I am talking about the highlighted area (spacing above the keyboard). I can not reproduce it on main.

Ah, I see. That happens because of the shouldEnableMaxHeight. It happens to all components that use it. For example,

image

@bernhardoj
Copy link
Contributor Author

@sobitneupane bump

@sobitneupane
Copy link
Contributor

Sorry for the delay @bernhardoj

It’s been a busy week, but I’ll do my best to get it done by the weekend.

@sobitneupane
Copy link
Contributor

sobitneupane commented Oct 29, 2025

@bernhardoj I could not reproduce this issue on staging.

Screenshot 2025-10-29 at 19 54 48

@sobitneupane
Copy link
Contributor

Before After
Screenshot 2025-10-29 at 19 52 35 Screenshot 2025-10-29 at 19 54 34

@sobitneupane
Copy link
Contributor

I'm keeping a close eye on that issue. There aren't any proposals yet. I think we can merge this PR once we confirm that the solution in #74559 actually fixes the problem here.

@sobitneupane
Copy link
Contributor

sobitneupane commented Nov 28, 2025

Same as above — no progress yet on the linked issue.

@sobitneupane
Copy link
Contributor

PR on HOLD

Same as above — no progress yet on the linked issue.

@bernhardoj bernhardoj changed the title Fix viewport is scrolled in some pages on iOS mWeb [HOLD #74559] Fix viewport is scrolled in some pages on iOS mWeb Dec 16, 2025
@bernhardoj
Copy link
Contributor Author

@sobitneupane the other PR is merged. This issue is now fixed.

@bernhardoj bernhardoj changed the title [HOLD #74559] Fix viewport is scrolled in some pages on iOS mWeb Fix viewport is scrolled in some pages on iOS mWeb Feb 28, 2026
@bernhardoj bernhardoj requested a review from a team as a code owner February 28, 2026 04:50
@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team February 28, 2026 04:50
Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No product concerns from me.

@bernhardoj
Copy link
Contributor Author

@sobitneupane just merged with main. Ready for your review.

Copy link
Contributor

@sobitneupane sobitneupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate.

Copy link
Contributor

@sobitneupane sobitneupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-11.at.13.15.17.mov
Android: mWeb Chrome
Screen.Recording.2026-03-11.at.13.23.37.mov
iOS: HybridApp
Screen.Recording.2026-03-11.at.13.56.41.mov
iOS: mWeb Safari
Screen.Recording.2026-03-11.at.13.29.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-11.at.13.12.24.mov

@sobitneupane
Copy link
Contributor

@bernhardoj Could you please check why is the ESLint check failing?

@bernhardoj
Copy link
Contributor Author

It's unrelated to this PR

image

Copy link
Contributor

@sobitneupane sobitneupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@melvin-bot melvin-bot bot requested a review from tylerkaraszewski March 12, 2026 04:05
@tylerkaraszewski tylerkaraszewski merged commit be374c7 into Expensify:main Mar 12, 2026
30 checks passed
@github-actions
Copy link
Contributor

🚧 @tylerkaraszewski has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 9.3.37-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants